Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a skeletal animation sample using ozz-animation library #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dxd39
Copy link

@dxd39 dxd39 commented Apr 5, 2021

add a sample demonstrates how to integrate ozz-animation library into an application to play skeletal animation.

… an application to play skeletal animation.
@TheMostDiligent
Copy link
Contributor

@dxd39 Thanks for submitting the PR. While ozz-animation seems to be a good solution for skeletal animation, there are a few concerns that I have (not to mention the fact that PR does not pass the CI checks):

  • GLTF loader and renderer already supports skeletal animation and there is even a model in the GLTF viewer that demonstrates it
  • ozz-animation does not seem to be officially supported (or at least tested) on iOS, Universal Windows and Android platforms
  • ozz-animation needs to be added as another submodule (and will pull its own dependencies, some of which will be duplicate), which will add complexity

So while this is a good example, I don't see the direct need to have it in the main repo. What I suggest is to add a reference to this example in your fork of the repository to the readme. What do you think?

@dxd39
Copy link
Author

dxd39 commented Apr 6, 2021

ok, your concerns are reasonable.

@dxd39 dxd39 closed this Apr 6, 2021
@TheMostDiligent
Copy link
Contributor

@dxd39 I am going to create a separate repository for community contributions. Would you consider re-submitting this PR to this repository?

@dxd39
Copy link
Author

dxd39 commented Apr 12, 2021

@TheMostDiligent ok, you can send me the repository url.

@TheMostDiligent
Copy link
Contributor

TheMostDiligent commented Apr 14, 2021

I added the new repository for community contributions:
https://github.com/DiligentGraphics/DiligentCommunity
The repo should be cloned at the same level as other modules, and the main CMake script will pick it up.

Please submit your PR to this repo.
Few comments:

  • Please make sure that your code follows formatting style.
  • Please resize your gifs to 640x480 so that they are consistent with the other samples/tutorials
  • Please add description of your project with the attributions to the main readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants