Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sdk 33 #312

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/sdk 33 #312

wants to merge 2 commits into from

Conversation

asajim
Copy link

@asajim asajim commented Nov 26, 2022

πŸš€ Description

  • Update SDK version to 33

πŸ“„ Motivation and Context

πŸ§ͺ How Has This Been Tested?

  • Tested it on devices running android 13 and older android versions

πŸ“· Screenshots (if appropriate)

  • No UI is changed

πŸ“¦ Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

βœ… Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@wahyuafendi
Copy link

belum bisa bang?

@qadir227
Copy link

How can I use this fix? I using this library and recently noticed its not working in Android 33 version. Can you guid me through this please?

@@ -21,3 +21,4 @@
/captures
.externalNativeBuild
.idea/encodings.xml
.idea/inspectionProfiles

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this ignore ?

@DevGemiDroid
Copy link

Hello @asajim,
I saw your changes, but I think in Android 13+, there is a permission restriction we should respect it.
You can check here: https://developer.android.com/about/versions/13/behavior-changes-13#granular-media-permissions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants