-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish dxDiagram types, arrange "commands" props types (T1227506) #27344
Merged
mpreyskurantov
merged 13 commits into
DevExpress:24_1
from
mpreyskurantov:24_1-T1227506
May 21, 2024
Merged
Publish dxDiagram types, arrange "commands" props types (T1227506) #27344
mpreyskurantov
merged 13 commits into
DevExpress:24_1
from
mpreyskurantov:24_1-T1227506
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpreyskurantov
changed the title
Publish dxDiagram Types (T1227506)
Publish dxDiagram Types, arrange props of dxDiagramCustomCommand | DiagramCommand types (T1227506)
May 10, 2024
mpreyskurantov
added a commit
to mpreyskurantov/devextreme-documentation
that referenced
this pull request
May 10, 2024
mpreyskurantov
changed the title
Publish dxDiagram Types, arrange props of dxDiagramCustomCommand | DiagramCommand types (T1227506)
Publish dxDiagram types, arrange "commands" props types (T1227506)
May 11, 2024
romanresh
previously approved these changes
May 13, 2024
IlyaKhD
previously approved these changes
May 20, 2024
IlyaKhD
approved these changes
May 20, 2024
mpreyskurantov
added a commit
to mpreyskurantov/DevExtreme
that referenced
this pull request
May 21, 2024
…evExpress#27344) (cherry picked from commit b4d9b2d)
mpreyskurantov
added a commit
to mpreyskurantov/devextreme-demos
that referenced
this pull request
May 21, 2024
…27344) (cherry picked from DevExpress/DevExtreme#27344)
This was referenced May 23, 2024
mpreyskurantov
added a commit
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks
Changelog:
@public
+@namespace DevExpress.ui.dxDiagram
(with thedxDiagram
scope - to avoid naming conflicts in a bundle similar to the other components)@public
(@namespace DevExpress.ui
already exists - no thedxDiagram
scope - the type name already starts withdxDiagram
, i.e., an unique / component-basis prefix), interface -> type(dx)Diagram
prefixAll published types become available in framework packages re-exports
Array<dxDiagramCustomCommand>|Array<Enums.DiagramCommand>
- now have this type in d.ts (Array<CustomCommand | Command>
) without doc tag override (note that in react we cannot add a real enum / union type import, but use indi acc values instead, otherwise - BC)as any
Docs:
DevExpress/devextreme-documentation#6302
DevExpress/devextreme-documentation#6322