Add support for the ExternalReferences field in components #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykter
force-pushed
the
component-external-references
branch
from
64dff39
to
146b70d
Compare
Signed-off-by: Michael Macnair <michaelmacnair@monzo.com>
mykter
force-pushed
the
component-external-references
branch
from
146b70d
to
96444d1
Compare
nscuro
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API includes an
externalReferencesfield in components, but this is currently ignore by the Go client. This PR adds the field to the type, so it will be captured when deserialised.I suggest hiding whitespace when reviewing.
Tested by using the forked version - all of the fields get correctly populated.