Hotfix/always show council #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirginiaDooley
changed the title
VirginiaDooley
force-pushed
the
hotfix/always-show-council
branch
from
5dfb133
to
b5bac03
Compare
VirginiaDooley
changed the title
|
There are two more cases to consider here:
See the logic here: I expect we can just use the wording we use there. |
VirginiaDooley
force-pushed
the
hotfix/always-show-council
branch
5 times, most recently
from
cb88de4
to
db687f2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
VirginiaDooley
force-pushed
the
hotfix/always-show-council
branch
7 times, most recently
from
a6e23e3
to
e96246e
Compare
VirginiaDooley
force-pushed
the
hotfix/always-show-council
branch
6 times, most recently
from
41af72b
to
a047ef9
Compare
VirginiaDooley
force-pushed
the
hotfix/always-show-council
branch
2 times, most recently
from
f934864
to
89c1905
Compare
- Removes unused code - Updates logic for council v registration given change in context - Reformats registration deadline date - Fixes logic for is_before_registration_deadline - Removes the advice about registering by post - Fixes logic for past_registration_deadline to use datetime comparison
VirginiaDooley
force-pushed
the
hotfix/always-show-council
branch
from
89c1905
to
c850b1e
Compare
symroe
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://app.asana.com/0/1204880927741389/1207218844713564/f
Always show council contact details regardless of whether a polling station is known. Show the registration office details if they differ from the council. For NI, the council should be EONI.
In NI
