Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD]test_task_packed_picking: add module #5

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

DemchukM
Copy link
Owner

No description provided.

Copy link
Collaborator

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Please check comments and also add USAGE.rst to have some idea of the usage flow


def create_new_package(
self, stock_picking_id, package_name, location_id, location_dest_id
):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always add docstrings to functions

@@ -7,7 +7,7 @@
"category": "Test",
"license": "LGPL-3",
"depends": [
"base",
"sale_management",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need sale_management here?
If you really need both sale and stock there is a sale_stock module which you can inherit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants