-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD]test_task_packed_picking: add module #5
base: 16.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Please check comments and also add USAGE.rst to have some idea of the usage flow
test_task_packed_picking/tests/test_create_picking_and_put_product_a_package.py
Outdated
Show resolved
Hide resolved
test_task_packed_picking/tests/test_create_picking_and_put_product_a_package.py
Show resolved
Hide resolved
|
||
def create_new_package( | ||
self, stock_picking_id, package_name, location_id, location_dest_id | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always add docstrings to functions
@@ -7,7 +7,7 @@ | |||
"category": "Test", | |||
"license": "LGPL-3", | |||
"depends": [ | |||
"base", | |||
"sale_management", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need sale_management here?
If you really need both sale and stock there is a sale_stock module which you can inherit
No description provided.