-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving date of discovery filter #10204
Conversation
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🟢 Risk threshold not exceeded. Change Summary (click to expand)The following is a summary of changes in this pull request made by me, your security buddy 🤖. Summary: The changes in this pull request focus on improving the handling of placeholder text for input fields and select elements in the For select elements with the From an application security perspective, these changes do not introduce any obvious security concerns. The code is focused on improving the user experience by setting appropriate placeholder text for form elements, which is a common practice in web application development. However, it's important to review the overall codebase and ensure that there are no other security vulnerabilities, such as cross-site scripting (XSS), SQL injection, or improper input validation, as these could potentially impact the application's security. Files Changed:
Powered by DryRun Security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
[sc-5885]
Fixed missing filter on Discovery Date. Now able to specify a range with from and to.
Test results
Tested locally and includes a fix for when labels are 'missing' in the report builder html.