Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation overay #108

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Segmentation overay #108

wants to merge 6 commits into from

Conversation

lullulalal
Copy link
Collaborator

exact-browser-sync.js

  • Display the segmentation images list.
  • Split the segmentation overlay and registration handlers.

exact-overlay-opacity.js

  • Event handlers related to the segmentation overlay.

annotate.html

  • Include the newly added exact-overlay-opacity.js file.

model.py

  • Modify to allow uploading .hdf5 files.

requirements.txt

  • Add the h5py package
  • Update Django version. In the latest version of Django, no errors occur with CharFields.

@maubreville
Copy link
Collaborator

Hey @lullulalal. Thanks for the contributions. I think we need to briefly discuss the architectural change here, since it changes the way EXACT handles files.
Maybe we can nicely merge this with other efforts that also changed how EXACT handles files provided by my recent PR (#109).

Some questions from the top of my head:

  • Is hdf5 the right file format for masks, as it is very general-purpose? Shouldn't we go for something that is more in the direction of sparse matrices?
  • Additionally, HDF5 might be too general and might yield to complications if people use the internal file structure differently.

Regardless, I think the handler for segmentation masks could ne neatly integrated into the new getSlideHandler() mechanism.

@FraukeWilm: Since I think you are also involved: Could we briefly meet to discuss this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants