Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add source type info #17572

Merged
merged 4 commits into from
May 15, 2024
Merged

add source type info #17572

merged 4 commits into from
May 15, 2024

Conversation

clarkb7
Copy link
Contributor

@clarkb7 clarkb7 commented May 15, 2024

What does this PR do?

Add source_type info to windows event log integration

Motivation

https://datadoghq.atlassian.net/browse/WINA-798

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@clarkb7 clarkb7 added qa/skip-qa Automatically skip this PR for the next QA assets/no-dry-run Run asset publishing github checks in staging labels May 15, 2024
@clarkb7 clarkb7 requested review from a team as code owners May 15, 2024 17:00
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

lrbhatia
lrbhatia approved these changes May 15, 2024
View reviewed changes
Copy link

@lrbhatia lrbhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clarkb7 clarkb7 merged commit a74d16d into master May 15, 2024
51 checks passed
@clarkb7 clarkb7 deleted the branden.clark/event-log-apw branch May 15, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moreauowen moreauowen moreauowen approved these changes

@lrbhatia lrbhatia lrbhatia approved these changes

Assignees
No one assigned
Labels
assets/no-dry-run Run asset publishing github checks in staging changelog/no-changelog documentation integration/win32_event_log qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations team/documentation team/windows-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clarkb7 @moreauowen @lrbhatia