Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for dependency confusion #17567

Merged
merged 1 commit into from
May 16, 2024

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented May 14, 2024

What does this PR do?

This part 1 of the fix to address the misunderstanding that some users may have about the requirements-agent-release.txt's purpose.

It focuses on making the file unusable with pip directly. We also add a note to the file warning users against modifying the file or passing it to pip.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@iliakur iliakur requested a review from a team as a code owner May 14, 2024 11:16
@iliakur iliakur merged commit 474d918 into master May 16, 2024
59 checks passed
@iliakur iliakur deleted the ik/AI-3891/quickfix-for-dependency-confusion branch May 16, 2024 04:48
datadog-agent-integrations-bot bot pushed a commit that referenced this pull request May 16, 2024
Kyle-Neale pushed a commit that referenced this pull request May 16, 2024
(cherry picked from commit 474d918)

Co-authored-by: Ilia Kurenkov <ilia.kurenkov@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants