Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Teleport Overview Dashboard #17460

Merged
merged 2 commits into from May 13, 2024

Conversation

NouemanKHAL
Copy link
Contributor

What does this PR do?

Adds the Overview dashboard for the Teleport Integration

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, found a docs link that doesn't work, but you can either remove or make docs public to resolve!

"id": 6942437579739040,
"definition": {
"type": "note",
"content": "Resources:\n\n- [Documentation for Teleport Integration](https://docs.datadoghq.com/integrations/teleport)\n \n- [Teleport Health Monitoring](https://goteleport.com/docs/management/diagnostics/monitoring/)\n \n- [Teleport metrics](https://goteleport.com/docs/management/diagnostics/monitoring/)\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have to change this "display_on_public_website": false in the manifest.json, the docs link doesn't work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link doesn't work because the integration hasn't been released yet. I added it preemptively.

@NouemanKHAL NouemanKHAL merged commit 50d77c7 into master May 13, 2024
42 checks passed
@NouemanKHAL NouemanKHAL deleted the noueman/add-teleport-overview-dashboard branch May 13, 2024 09:41
github-actions bot pushed a commit that referenced this pull request May 13, 2024
* add dashboard file

* update manifest.json 50d77c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants