Changing the mysql.innodb.lock_structs metric type to gauge #17452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldrickdev
added
bugfix/regression
and removed
documentation
integration/mysql
team/agent-integrations
labels
Test Results 18 files 18 suites 17m 13s ⏱️ Results for commit 9e8f53d. ♻️ This comment has been updated with latest results. |
cswatt
approved these changes
Apr 25, 2024
lu-zhengda
approved these changes
Apr 30, 2024
steveny91
approved these changes
May 1, 2024
Kyle-Neale
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR will change the metric type of mysql.innodb.lock_structs to a gauge instead of rate.
Motivation
The motivation for this fix was a support case when the agent was generating the log below:
This caused the metric to never be reported.
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged