Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger dependency build-related jobs on release branches too #17449

Merged
merged 1 commit into from Apr 30, 2024

Conversation

alopezz
Copy link
Contributor

@alopezz alopezz commented Apr 25, 2024

What does this PR do?

It does the equivalent to what is currently already done in master w.r.t. dependency builds, uploads and lockfile updates to release branches.

Motivation

With the new dependency build process, there's no good way to cherry pick individual dependency changes to release branches (or to update individual dependencies within a release branch, for that matter). This is because lockfiles are resolved for a predefined set of direct dependencies (as defined in agent_requirements.in); cherry picking a dependency update out of many updates would result in a new set of direct dependencies that would need separate resolution.

Additional Notes

The auto-PR should, according to the documentation for the Action that we use to generate it, inherit the base branch from the PR that triggered the workflow, which is what we want.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@alopezz alopezz merged commit f66e707 into master Apr 30, 2024
58 of 59 checks passed
@alopezz alopezz deleted the alopez/build-deps-for-releases branch April 30, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants