Add MacOS dependency build #16615
Merged
Add MacOS dependency build #16615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
alopezz
force-pushed
the
alopez/builders-macos
branch
from
3e0108f
to
0b91019
Compare
alopezz
force-pushed
the
alopez/builders-macos
branch
13 times, most recently
from
4a387de
to
2f19e93
Compare
alopezz
force-pushed
the
alopez/builders-macos
branch
8 times, most recently
from
dd2af07
to
b2eada5
Compare
alopezz
force-pushed
the
alopez/builders-macos
branch
2 times, most recently
from
63fbd2f
to
891671a
Compare
While leaving cyrus-sasl out of the wheel like in Linux
alopezz
force-pushed
the
alopez/builders-macos
branch
3 times, most recently
from
a193dbc
to
520561b
Compare
alopezz
force-pushed
the
alopez/builders-macos
branch
from
520561b
to
f6c9eaa
Compare
ofek
approved these changes
Jan 25, 2024
|
|
||
| - name: Set up Python | ||
| env: | ||
| # Despite the name, this is built for the macOS 11 SDK on arm64 and 10.9+ on intel |
There was a problem hiding this comment.
I don't understand the question.
There was a problem hiding this comment.
As in how is the binary running successfully if it was built for a different architecture?
There was a problem hiding this comment.
Universal2 binaries are compatible with both Intel and arm64 (https://en.wikipedia.org/wiki/Universal_binary), the comment means to explain that the 11 in the package name refers to the SDK version used for the arm64 variant, whereas for intel (which is the one we're actually using in the build) it is built with 10.9, meaning we should be able to build wheels with support for MacOS versions 10.9+.
ofek
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements the build of dependency wheels for MacOS.
Motivation
APL-2768
Additional Notes
There's potential for caching of the libraries we build to speed up the build time, but can be left for later.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.