Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLMObs setup update #23149

Closed
wants to merge 94 commits into from
Closed

LLMObs setup update #23149

wants to merge 94 commits into from

Conversation

lievan
Copy link
Contributor

@lievan lievan commented May 14, 2024

What does this PR do? What is the motivation?

Merge instructions

  • Please merge after reviewing

Additional notes

jhgilbert and others added 20 commits May 13, 2024 16:55
…63-llm-obs' into jen.gilbert/DOCS-7663-llm-obs
Co-authored-by: Barry Eom <31739208+barieom@users.noreply.github.com>
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
…63-llm-obs' into jen.gilbert/DOCS-7663-llm-obs
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
…63-llm-obs' into jen.gilbert/DOCS-7663-llm-obs
@lievan lievan requested a review from a team as a code owner May 14, 2024 01:59
@lievan lievan changed the title setup update LLMObs setup update May 14, 2024
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@lievan lievan requested a review from Yun-Kim May 14, 2024 02:38
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggestions, let me know if anything the changed the meaning of the sentence.


- If you do not have Datadog APM set up, set `dd_llmobs_no_apm` to `True`. This configures the `ddtrace` library to not send any data that requires Datadog APM.
**Note**: `LLMObs.enable()` automatically turns automatic tracing for support LLM Observability integrations (Bedrock, OpenAI, Langchain). To only enable a certain subset of these integrations, use the `integrations` argument.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Note**: `LLMObs.enable()` automatically turns automatic tracing for support LLM Observability integrations (Bedrock, OpenAI, Langchain). To only enable a certain subset of these integrations, use the `integrations` argument.
**Note**: `LLMObs.enable()` turns on automatic tracing for supported LLM Observability integrations (Bedrock, OpenAI, Langchain). To only enable it for a subset of these integrations, use the `integrations` argument.

@@ -32,19 +32,19 @@ pip install git+https://github.com/DataDog/dd-trace-py.git@main

Enable LLM Observability through the `LLMOBs.enable()` function, as shown in the example below.

- Use the `integrations` argument to turn on automatic tracing for supported LLM Observability integrations (OpenAI, Bedrock, and LangChain).
**Note**: If you do not have Datadog APM set up, set `dd_llmobs_no_apm` to `True`. This configures the `ddtrace` library to not send any data that requires Datadog APM.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Note**: If you do not have Datadog APM set up, set `dd_llmobs_no_apm` to `True`. This configures the `ddtrace` library to not send any data that requires Datadog APM.
**Note**: If you do not have Datadog APM set up, set `dd_llmobs_no_apm` to `true`. This configures the `ddtrace` library to not send any data that requires Datadog APM.

Base automatically changed from jen.gilbert/DOCS-7663-llm-obs to master May 14, 2024 20:32
@jhgilbert jhgilbert added the editorial review Waiting on a more in-depth review label May 15, 2024
@jhgilbert jhgilbert self-requested a review May 15, 2024 14:51
@lievan lievan closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants