Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service_definitions.md #23143

Merged
merged 8 commits into from May 13, 2024
Merged

Update service_definitions.md #23143

merged 8 commits into from May 13, 2024

Conversation

crunchypistachiobutter
Copy link
Contributor

add endpoint info for v3.0

What does this PR do? What is the motivation?

add v3.0 definition API endpoints

Merge instructions

  • Please merge after reviewing

Additional notes

add endpoint info for v3.0
@crunchypistachiobutter crunchypistachiobutter requested a review from a team as a code owner May 13, 2024 18:34
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback to comply with docs style guide, but otherwise looks good!

content/en/service_catalog/service_definitions.md Outdated Show resolved Hide resolved
content/en/service_catalog/service_definitions.md Outdated Show resolved Hide resolved
content/en/service_catalog/service_definitions.md Outdated Show resolved Hide resolved
content/en/service_catalog/service_definitions.md Outdated Show resolved Hide resolved
content/en/service_catalog/service_definitions.md Outdated Show resolved Hide resolved
crunchypistachiobutter and others added 5 commits May 13, 2024 14:50
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rtrieu rtrieu merged commit 4fc98b9 into master May 13, 2024
11 of 12 checks passed
@rtrieu rtrieu deleted the brooke/service-catalog-v3 branch May 13, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants