Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a page for Test Visibility flaky test retries feature + fix supported trace JS versions in Selenium RUM page #23129

Merged
merged 5 commits into from
May 28, 2024
Merged

Add a page for Test Visibility flaky test retries feature + fix supported trace JS versions in Selenium RUM page #23129

merged 5 commits into from
May 28, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

What does this PR do? What is the motivation?

Adds a documentation page for a new Test Visibility feature: flaky test retries.
Fixes supported dd-trace-js versions in Selenium RUM integration page.

Merge instructions

  • Please merge after reviewing

Additional notes

@github-actions github-actions bot added Architecture Everything related to the Doc backend Images Images are added/removed with this PR labels May 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

juan-fernandez
juan-fernandez requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@juan-fernandez juan-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the feature flag for being able to activate this in the UI enabled?

content/en/tests/flaky_test_retries/_index.md Outdated Show resolved Hide resolved
@nikita-tkachenko-datadog
Copy link
Contributor Author

nikita-tkachenko-datadog commented May 13, 2024 •
edited

is the feature flag for being able to activate this in the UI enabled?

I was about to enable it but apparently we have some UI issues around it, so let's put this on pause for now

@rtrieu
Copy link
Contributor

rtrieu commented May 13, 2024

Created DOCS-7952 for docs team review.

@rtrieu rtrieu added the editorial review Waiting on a more in-depth review label May 13, 2024
rtrieu
rtrieu requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small feedback, but otherwise looks good. Please re-request a review when you are ready!

content/en/tests/flaky_test_retries/_index.md Outdated Show resolved Hide resolved
content/en/tests/flaky_test_retries/_index.md Outdated Show resolved Hide resolved
@nikita-tkachenko-datadog
Copy link
Contributor Author

is the feature flag for being able to activate this in the UI enabled?

The UI issues have been resolved and we're ready for enabling the feature flag. As soon as this doc is merged we'll proceed to do it.

juan-fernandez
juan-fernandez approved these changes May 24, 2024
View reviewed changes
content/en/tests/browser_tests.md Outdated Show resolved Hide resolved
@nikita-tkachenko-datadog @juan-fernandez
Update content/en/tests/browser_tests.md
2d8de43 
Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
rtrieu
rtrieu approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtrieu rtrieu merged commit b0d74b9 into master May 28, 2024
14 checks passed
@rtrieu rtrieu deleted the nikita-tkachenko/flaky-test-retries branch May 28, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan-fernandez juan-fernandez juan-fernandez approved these changes

@rtrieu rtrieu rtrieu approved these changes

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review Images Images are added/removed with this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nikita-tkachenko-datadog @rtrieu @juan-fernandez