-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-7907 Visual Studio Documentation Update #23083
base: master
Are you sure you want to change the base?
Conversation
|
||
Static Analysis supports scanning across multiple programming languages. For a complete list, see [Static Analysis Rules][15]. For file types belonging to supported languages, issues are shown in the source code editor using Visual Studio's code inspection system, and suggested fixes can be applied directly: | ||
|
||
{{< img src="/developers/ide_plugins/visual_studio/TBD.png" alt="A static analysis rule violation and recommended fix." style="width:100%;" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be replaced: image in dark mode @markazerdd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlonAm to add the screenshot in here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a new screenshot, let me know what you think, thanks
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a suggestion for content reuse
- name: IDE Plugins | ||
url: developers/ide_plugins | ||
parent: code_analysis | ||
identifier: code_analysis_ide_plugins | ||
weight: 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried a full-page reuse here? Might be a good use case for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like reusing a passage would be more appropriate here since if we actually want to display the docs directly under Code Analysis, then only the "Static Analysis" portion would be relevant out of the IDE Integration docs
Hi all, Alon brought this PR to my attention. I had another (related) PR #23376 approved and merged yesterday and it will cause a conflict with this one so you'll want to update to |
- name: IDE Plugins | ||
url: developers/ide_plugins | ||
parent: code_analysis | ||
identifier: code_analysis_ide_plugins | ||
weight: 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like reusing a passage would be more appropriate here since if we actually want to display the docs directly under Code Analysis, then only the "Static Analysis" portion would be relevant out of the IDE Integration docs
What does this PR do? What is the motivation?
Adds IDE Plugins section to the Code Analysis TOC + a Static Analysis section in the Visual Studio doc page.
Chatted with Mark about it on Slack. We are waiting for a screenshot of the working example (in dark mode) to be replaced.
Merge instructions
Additional notes