Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rollup.md to include the updates to interval logic and minimum interval logic #22393

Merged
merged 3 commits into from Mar 28, 2024

Conversation

mhintz
Copy link
Contributor

@mhintz mhintz commented Mar 28, 2024

What does this PR do? What is the motivation?

We've updated the default interval logic for time series graphs, including lowering the minimum intervals substantially. The docs don't yet reflect these changes, so this PR updates them to describe the system more accurately and in a bit more detail

Merge instructions

  • Please merge after reviewing

… interval logic

We've updated the default interval logic for time series graphs, including lowering the minimum intervals substantially. The docs don't yet reflect these changes, so this PR updates them to describe the system more accurately and in a bit more detail
@mhintz mhintz requested a review from a team as a code owner March 28, 2024 14:18
@@ -52,9 +52,9 @@ When graphing, Datadog imposes a limit on the number of points per graph. To res
| The past day | 5m | 20m | 5m |
| The past two days | 10m | 30m | 10m |
| The past week | 1hr | 2hr | 1hr |
| The past month | 2hr | 12hr | 4hr |
| The past month | 4hr | 12hr | 4hr |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line graphs were aligned with what the API returns for a 1-month time frame

Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback, but otherwise looks good!

content/en/dashboards/functions/rollup.md Outdated Show resolved Hide resolved
content/en/dashboards/functions/rollup.md Outdated Show resolved Hide resolved
mhintz and others added 2 commits March 28, 2024 10:30
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
rtrieu

This comment was marked as duplicate.

Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rtrieu rtrieu merged commit 8b899d0 into master Mar 28, 2024
12 checks passed
@rtrieu rtrieu deleted the mhintz/interval-docs-update branch March 28, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants