Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable telemetry logs for IAST, CI Visibility and Dynamic Instrumentation users #7017

Merged
merged 2 commits into from
May 30, 2024
Merged

Enable telemetry logs for IAST, CI Visibility and Dynamic Instrumentation users #7017

merged 2 commits into from
May 30, 2024
+31 −9

Conversation

smola
Copy link
Member

@smola smola commented May 13, 2024 •
edited by jira bot

What Does This Do

  • Enable telemetry logs by default if IAST or CI Visibility are activated.

Motivation

  • This is part of a gradual rollout of telemetry logs, prioritizing first products that need it the most.

Additional Notes

  • This code will be removed once telemetry logs are fully enabled by default. If everything goes well, that should be in about 2 releases after this PR.
  • Jira ticket: APPSEC-53106

@smola smola added the comp: telemetry Telemetry label May 13, 2024
@pr-commenter
Copy link

pr-commenter bot commented May 13, 2024 •
edited

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/telemetry-logs-partial-rollout-1
git_commit_date 1716998220 1717052047
git_commit_sha e2a66df 5b6984f
release_version 1.35.0-SNAPSHOT~e2a66dfea5 1.35.0-SNAPSHOT~5b6984fc63
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717054825 1717054825
ci_job_id 526810795 526810795
ci_pipeline_id 35426526 35426526
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~5b6984fc63, baseline=1.35.0-SNAPSHOT~e2a66dfea5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057052
Total [baseline] (8.604 s) : 0, 8603534
Agent [candidate] (1.054 s) : 0, 1054476
Total [candidate] (8.54 s) : 0, 8539679
section iast
Agent [baseline] (1.189 s) : 0, 1188925
Total [baseline] (9.006 s) : 0, 9005809
Agent [candidate] (1.164 s) : 0, 1163823
Total [candidate] (8.999 s) : 0, 8998654
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.186 s) : 0, 1185863
Total [baseline] (9.002 s) : 0, 9002337
Agent [candidate] (1.165 s) : 0, 1165221
Total [candidate] (9.022 s) : 0, 9021591
section iast_TELEMETRY_OFF
Agent [baseline] (1.184 s) : 0, 1183881
Total [baseline] (9.04 s) : 0, 9040227
Agent [candidate] (1.162 s) : 0, 1161655
Total [candidate] (9.017 s) : 0, 9016703
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.189 s 131.873 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.186 s 128.811 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.184 s 126.829 ms (12.0%)
Total tracing 8.604 s -
Total iast 9.006 s 402.276 ms (4.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.002 s 398.803 ms (4.6%)
Total iast_TELEMETRY_OFF 9.04 s 436.694 ms (5.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.164 s 109.346 ms (10.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.165 s 110.745 ms (10.5%)
Agent iast_TELEMETRY_OFF 1.162 s 107.179 ms (10.2%)
Total tracing 8.54 s -
Total iast 8.999 s 458.974 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.022 s 481.912 ms (5.6%)
Total iast_TELEMETRY_OFF 9.017 s 477.023 ms (5.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~5b6984fc63, baseline=1.35.0-SNAPSHOT~e2a66dfea5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (651.855 ms) : 0, 651855
BytebuddyAgent [candidate] (650.167 ms) : 0, 650167
GlobalTracer [baseline] (312.754 ms) : 0, 312754
GlobalTracer [candidate] (312.012 ms) : 0, 312012
AppSec [baseline] (49.766 ms) : 0, 49766
AppSec [candidate] (49.755 ms) : 0, 49755
Remote Config [baseline] (662.296 µs) : 0, 662
Remote Config [candidate] (663.31 µs) : 0, 663
Telemetry [baseline] (7.627 ms) : 0, 7627
Telemetry [candidate] (7.54 ms) : 0, 7540
section iast
BytebuddyAgent [baseline] (781.662 ms) : 0, 781662
BytebuddyAgent [candidate] (777.183 ms) : 0, 777183
GlobalTracer [baseline] (292.31 ms) : 0, 292310
GlobalTracer [candidate] (292.179 ms) : 0, 292179
AppSec [baseline] (51.07 ms) : 0, 51070
AppSec [candidate] (48.92 ms) : 0, 48920
Remote Config [baseline] (592.31 µs) : 0, 592
Remote Config [candidate] (593.635 µs) : 0, 594
Telemetry [baseline] (6.671 ms) : 0, 6671
Telemetry [candidate] (7.848 ms) : 0, 7848
IAST [baseline] (21.95 ms) : 0, 21950
IAST [candidate] (23.844 ms) : 0, 23844
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (776.45 ms) : 0, 776450
BytebuddyAgent [candidate] (777.686 ms) : 0, 777686
GlobalTracer [baseline] (292.86 ms) : 0, 292860
GlobalTracer [candidate] (291.898 ms) : 0, 291898
AppSec [baseline] (48.584 ms) : 0, 48584
AppSec [candidate] (48.38 ms) : 0, 48380
Remote Config [baseline] (592.476 µs) : 0, 592
Remote Config [candidate] (604.534 µs) : 0, 605
Telemetry [baseline] (7.337 ms) : 0, 7337
Telemetry [candidate] (7.726 ms) : 0, 7726
IAST [baseline] (25.618 ms) : 0, 25618
IAST [candidate] (25.625 ms) : 0, 25625
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (775.939 ms) : 0, 775939
BytebuddyAgent [candidate] (774.647 ms) : 0, 774647
GlobalTracer [baseline] (293.175 ms) : 0, 293175
GlobalTracer [candidate] (292.101 ms) : 0, 292101
AppSec [baseline] (47.348 ms) : 0, 47348
AppSec [candidate] (48.908 ms) : 0, 48908
Remote Config [baseline] (612.372 µs) : 0, 612
Remote Config [candidate] (610.412 µs) : 0, 610
Telemetry [baseline] (6.59 ms) : 0, 6590
Telemetry [candidate] (7.562 ms) : 0, 7562
IAST [baseline] (25.693 ms) : 0, 25693
IAST [candidate] (24.564 ms) : 0, 24564
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~5b6984fc63, baseline=1.35.0-SNAPSHOT~e2a66dfea5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056697
Total [baseline] (10.317 s) : 0, 10316961
Agent [candidate] (1.061 s) : 0, 1061118
Total [candidate] (10.449 s) : 0, 10448789
section appsec
Agent [baseline] (1.178 s) : 0, 1178473
Total [baseline] (10.52 s) : 0, 10519940
Agent [candidate] (1.174 s) : 0, 1173922
Total [candidate] (10.486 s) : 0, 10486290
section iast
Agent [baseline] (1.194 s) : 0, 1193759
Total [baseline] (10.828 s) : 0, 10827798
Agent [candidate] (1.175 s) : 0, 1174979
Total [candidate] (10.811 s) : 0, 10811378
section profiling
Agent [baseline] (1.258 s) : 0, 1258084
Total [baseline] (10.688 s) : 0, 10688175
Agent [candidate] (1.269 s) : 0, 1268709
Total [candidate] (10.664 s) : 0, 10664356
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent appsec 1.178 s 121.776 ms (11.5%)
Agent iast 1.194 s 137.063 ms (13.0%)
Agent profiling 1.258 s 201.387 ms (19.1%)
Total tracing 10.317 s -
Total appsec 10.52 s 202.979 ms (2.0%)
Total iast 10.828 s 510.838 ms (5.0%)
Total profiling 10.688 s 371.214 ms (3.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent appsec 1.174 s 112.804 ms (10.6%)
Agent iast 1.175 s 113.861 ms (10.7%)
Agent profiling 1.269 s 207.591 ms (19.6%)
Total tracing 10.449 s -
Total appsec 10.486 s 37.502 ms (0.4%)
Total iast 10.811 s 362.589 ms (3.5%)
Total profiling 10.664 s 215.567 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~5b6984fc63, baseline=1.35.0-SNAPSHOT~e2a66dfea5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (651.857 ms) : 0, 651857
BytebuddyAgent [candidate] (653.498 ms) : 0, 653498
GlobalTracer [baseline] (312.32 ms) : 0, 312320
GlobalTracer [candidate] (314.601 ms) : 0, 314601
AppSec [baseline] (49.915 ms) : 0, 49915
AppSec [candidate] (50.193 ms) : 0, 50193
Remote Config [baseline] (659.768 µs) : 0, 660
Remote Config [candidate] (669.064 µs) : 0, 669
Telemetry [baseline] (7.63 ms) : 0, 7630
Telemetry [candidate] (7.661 ms) : 0, 7661
section appsec
BytebuddyAgent [baseline] (676.01 ms) : 0, 676010
BytebuddyAgent [candidate] (673.498 ms) : 0, 673498
GlobalTracer [baseline] (295.813 ms) : 0, 295813
GlobalTracer [candidate] (295.653 ms) : 0, 295653
AppSec [baseline] (152.771 ms) : 0, 152771
AppSec [candidate] (152.62 ms) : 0, 152620
Remote Config [baseline] (630.257 µs) : 0, 630
Remote Config [candidate] (631.339 µs) : 0, 631
Telemetry [baseline] (9.455 ms) : 0, 9455
Telemetry [candidate] (7.74 ms) : 0, 7740
IAST [baseline] (18.701 ms) : 0, 18701
IAST [candidate] (18.778 ms) : 0, 18778
section iast
BytebuddyAgent [baseline] (782.295 ms) : 0, 782295
BytebuddyAgent [candidate] (784.794 ms) : 0, 784794
GlobalTracer [baseline] (294.87 ms) : 0, 294870
GlobalTracer [candidate] (294.291 ms) : 0, 294291
AppSec [baseline] (48.421 ms) : 0, 48421
AppSec [candidate] (49.283 ms) : 0, 49283
Remote Config [baseline] (604.634 µs) : 0, 605
Remote Config [candidate] (605.266 µs) : 0, 605
Telemetry [baseline] (7.426 ms) : 0, 7426
Telemetry [candidate] (8.485 ms) : 0, 8485
IAST [baseline] (25.633 ms) : 0, 25633
IAST [candidate] (24.155 ms) : 0, 24155
section profiling
BytebuddyAgent [baseline] (662.566 ms) : 0, 662566
BytebuddyAgent [candidate] (666.55 ms) : 0, 666550
GlobalTracer [baseline] (385.035 ms) : 0, 385035
GlobalTracer [candidate] (388.48 ms) : 0, 388480
AppSec [baseline] (50.732 ms) : 0, 50732
AppSec [candidate] (51.06 ms) : 0, 51060
Remote Config [baseline] (844.185 µs) : 0, 844
Remote Config [candidate] (861.963 µs) : 0, 862
Telemetry [baseline] (7.449 ms) : 0, 7449
Telemetry [candidate] (7.527 ms) : 0, 7527
ProfilingAgent [baseline] (94.924 ms) : 0, 94924
ProfilingAgent [candidate] (97.176 ms) : 0, 97176
Profiling [baseline] (94.948 ms) : 0, 94948
Profiling [candidate] (97.2 ms) : 0, 97200

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-30T07:12:52 2024-05-30T07:19:44
git_branch master smola/telemetry-logs-partial-rollout-1
git_commit_date 1716998220 1717052047
git_commit_sha e2a66df 5b6984f
release_version 1.35.0-SNAPSHOT~e2a66dfea5 1.35.0-SNAPSHOT~5b6984fc63
start_time 2024-05-30T07:12:38 2024-05-30T07:19:30
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717053931 1717053931
ci_job_id 526810796 526810796
ci_pipeline_id 35426526 35426526
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~5b6984fc63, baseline=1.35.0-SNAPSHOT~e2a66dfea5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.359 ms) : 1340, 1379
.   : milestone, 1359,
appsec (1.721 ms) : 1696, 1746
.   : milestone, 1721,
appsec_no_iast (1.727 ms) : 1702, 1751
.   : milestone, 1727,
iast (1.485 ms) : 1462, 1508
.   : milestone, 1485,
profiling (1.56 ms) : 1534, 1586
.   : milestone, 1560,
tracing (1.468 ms) : 1443, 1492
.   : milestone, 1468,
section candidate
no_agent (1.363 ms) : 1344, 1383
.   : milestone, 1363,
appsec (1.729 ms) : 1705, 1753
.   : milestone, 1729,
appsec_no_iast (1.74 ms) : 1716, 1763
.   : milestone, 1740,
iast (1.495 ms) : 1473, 1517
.   : milestone, 1495,
profiling (1.545 ms) : 1520, 1571
.   : milestone, 1545,
tracing (1.47 ms) : 1446, 1494
.   : milestone, 1470,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.359 ms [1.34 ms, 1.379 ms] -
appsec 1.721 ms [1.696 ms, 1.746 ms] 361.985 µs (26.6%)
appsec_no_iast 1.727 ms [1.702 ms, 1.751 ms] 367.855 µs (27.1%)
iast 1.485 ms [1.462 ms, 1.508 ms] 125.777 µs (9.3%)
profiling 1.56 ms [1.534 ms, 1.586 ms] 201.132 µs (14.8%)
tracing 1.468 ms [1.443 ms, 1.492 ms] 108.746 µs (8.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.363 ms [1.344 ms, 1.383 ms] -
appsec 1.729 ms [1.705 ms, 1.753 ms] 365.706 µs (26.8%)
appsec_no_iast 1.74 ms [1.716 ms, 1.763 ms] 376.11 µs (27.6%)
iast 1.495 ms [1.473 ms, 1.517 ms] 131.674 µs (9.7%)
profiling 1.545 ms [1.52 ms, 1.571 ms] 181.805 µs (13.3%)
tracing 1.47 ms [1.446 ms, 1.494 ms] 106.712 µs (7.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~5b6984fc63, baseline=1.35.0-SNAPSHOT~e2a66dfea5
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.596 µs) : 357, 396
.   : milestone, 377,
iast (490.499 µs) : 469, 512
.   : milestone, 490,
iast_FULL (552.802 µs) : 532, 574
.   : milestone, 553,
iast_GLOBAL (511.269 µs) : 490, 533
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (484.22 µs) : 462, 506
.   : milestone, 484,
iast_INACTIVE (458.911 µs) : 438, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (478.165 µs) : 456, 500
.   : milestone, 478,
tracing (456.259 µs) : 434, 478
.   : milestone, 456,
section candidate
no_agent (367.424 µs) : 347, 388
.   : milestone, 367,
iast (489.66 µs) : 468, 511
.   : milestone, 490,
iast_FULL (556.825 µs) : 536, 578
.   : milestone, 557,
iast_GLOBAL (509.685 µs) : 489, 531
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (491.608 µs) : 470, 513
.   : milestone, 492,
iast_INACTIVE (456.1 µs) : 435, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (477.99 µs) : 456, 500
.   : milestone, 478,
tracing (449.4 µs) : 428, 470
.   : milestone, 449,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.596 µs [357.326 µs, 395.866 µs] -
iast 490.499 µs [469.112 µs, 511.887 µs] 113.903 µs (30.2%)
iast_FULL 552.802 µs [531.656 µs, 573.948 µs] 176.205 µs (46.8%)
iast_GLOBAL 511.269 µs [489.553 µs, 532.985 µs] 134.673 µs (35.8%)
iast_HARDCODED_SECRET_DISABLED 484.22 µs [462.072 µs, 506.368 µs] 107.623 µs (28.6%)
iast_INACTIVE 458.911 µs [437.794 µs, 480.028 µs] 82.315 µs (21.9%)
iast_TELEMETRY_OFF 478.165 µs [455.843 µs, 500.487 µs] 101.568 µs (27.0%)
tracing 456.259 µs [434.195 µs, 478.323 µs] 79.663 µs (21.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.424 µs [347.037 µs, 387.81 µs] -
iast 489.66 µs [468.449 µs, 510.871 µs] 122.236 µs (33.3%)
iast_FULL 556.825 µs [535.607 µs, 578.044 µs] 189.402 µs (51.5%)
iast_GLOBAL 509.685 µs [488.618 µs, 530.752 µs] 142.262 µs (38.7%)
iast_HARDCODED_SECRET_DISABLED 491.608 µs [470.395 µs, 512.822 µs] 124.185 µs (33.8%)
iast_INACTIVE 456.1 µs [435.084 µs, 477.116 µs] 88.676 µs (24.1%)
iast_TELEMETRY_OFF 477.99 µs [455.743 µs, 500.237 µs] 110.567 µs (30.1%)
tracing 449.4 µs [428.395 µs, 470.404 µs] 81.976 µs (22.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/telemetry-logs-partial-rollout-1
git_commit_date 1716998220 1717052047
git_commit_sha e2a66df 5b6984f
release_version 1.35.0-SNAPSHOT~e2a66dfea5 1.35.0-SNAPSHOT~5b6984fc63
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1717054444 1717054444
ci_job_id 526810797 526810797
ci_pipeline_id 35426526 35426526
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~5b6984fc63, baseline=1.35.0-SNAPSHOT~e2a66dfea5
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.033 s) : 15033000, 15033000
.   : milestone, 15033000,
appsec (15.246 s) : 15246000, 15246000
.   : milestone, 15246000,
iast (18.569 s) : 18569000, 18569000
.   : milestone, 18569000,
iast_GLOBAL (18.077 s) : 18077000, 18077000
.   : milestone, 18077000,
profiling (15.052 s) : 15052000, 15052000
.   : milestone, 15052000,
tracing (15.172 s) : 15172000, 15172000
.   : milestone, 15172000,
section candidate
no_agent (15.461 s) : 15461000, 15461000
.   : milestone, 15461000,
appsec (15.09 s) : 15090000, 15090000
.   : milestone, 15090000,
iast (18.623 s) : 18623000, 18623000
.   : milestone, 18623000,
iast_GLOBAL (17.949 s) : 17949000, 17949000
.   : milestone, 17949000,
profiling (15.371 s) : 15371000, 15371000
.   : milestone, 15371000,
tracing (15.009 s) : 15009000, 15009000
.   : milestone, 15009000,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.033 s [15.033 s, 15.033 s] -
appsec 15.246 s [15.246 s, 15.246 s] 213.0 ms (1.4%)
iast 18.569 s [18.569 s, 18.569 s] 3.536 s (23.5%)
iast_GLOBAL 18.077 s [18.077 s, 18.077 s] 3.044 s (20.2%)
profiling 15.052 s [15.052 s, 15.052 s] 19.0 ms (0.1%)
tracing 15.172 s [15.172 s, 15.172 s] 139.0 ms (0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.461 s [15.461 s, 15.461 s] -
appsec 15.09 s [15.09 s, 15.09 s] -371.0 ms (-2.4%)
iast 18.623 s [18.623 s, 18.623 s] 3.162 s (20.5%)
iast_GLOBAL 17.949 s [17.949 s, 17.949 s] 2.488 s (16.1%)
profiling 15.371 s [15.371 s, 15.371 s] -90.0 ms (-0.6%)
tracing 15.009 s [15.009 s, 15.009 s] -452.0 ms (-2.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~5b6984fc63, baseline=1.35.0-SNAPSHOT~e2a66dfea5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1474
.   : milestone, 1462,
appsec (2.233 ms) : 2198, 2267
.   : milestone, 2233,
iast (1.959 ms) : 1919, 1999
.   : milestone, 1959,
iast_GLOBAL (1.979 ms) : 1939, 2019
.   : milestone, 1979,
profiling (1.845 ms) : 1812, 1879
.   : milestone, 1845,
tracing (1.823 ms) : 1791, 1854
.   : milestone, 1823,
section candidate
no_agent (1.463 ms) : 1451, 1474
.   : milestone, 1463,
appsec (2.208 ms) : 2174, 2242
.   : milestone, 2208,
iast (1.965 ms) : 1925, 2006
.   : milestone, 1965,
iast_GLOBAL (2.012 ms) : 1971, 2053
.   : milestone, 2012,
profiling (1.85 ms) : 1818, 1882
.   : milestone, 1850,
tracing (1.838 ms) : 1806, 1870
.   : milestone, 1838,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.474 ms] -
appsec 2.233 ms [2.198 ms, 2.267 ms] 770.3 µs (52.7%)
iast 1.959 ms [1.919 ms, 1.999 ms] 496.942 µs (34.0%)
iast_GLOBAL 1.979 ms [1.939 ms, 2.019 ms] 516.443 µs (35.3%)
profiling 1.845 ms [1.812 ms, 1.879 ms] 383.16 µs (26.2%)
tracing 1.823 ms [1.791 ms, 1.854 ms] 360.28 µs (24.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.451 ms, 1.474 ms] -
appsec 2.208 ms [2.174 ms, 2.242 ms] 745.439 µs (51.0%)
iast 1.965 ms [1.925 ms, 2.006 ms] 502.376 µs (34.3%)
iast_GLOBAL 2.012 ms [1.971 ms, 2.053 ms] 548.848 µs (37.5%)
profiling 1.85 ms [1.818 ms, 1.882 ms] 387.275 µs (26.5%)
tracing 1.838 ms [1.806 ms, 1.87 ms] 375.216 µs (25.7%)

@smola smola changed the title Enable telemetry logs for IAST and CI Visibility users Enable telemetry logs for IAST, CI Visibility and Dynamic Instrumentation users May 16, 2024
@smola smola force-pushed the smola/telemetry-logs-partial-rollout-1 branch 2 times, most recently from 0547959 to 40229a5 Compare May 16, 2024 08:29
@smola smola marked this pull request as ready for review May 16, 2024 09:27
@smola smola requested a review from a team as a code owner May 16, 2024 09:27
@smola smola requested review from dougqh and nayeem-kamal May 16, 2024 09:27
@smola smola force-pushed the smola/telemetry-logs-partial-rollout-1 branch from 40229a5 to 025ea41 Compare May 22, 2024 09:43
@smola smola requested a review from OmerRaviv May 29, 2024 07:32
@smola smola force-pushed the smola/telemetry-logs-partial-rollout-1 branch from d7cf2d1 to 99e8647 Compare May 29, 2024 09:29
@smola smola merged commit d46ec26 into master May 30, 2024
81 checks passed
@smola smola deleted the smola/telemetry-logs-partial-rollout-1 branch May 30, 2024 07:49
@github-actions github-actions bot added this to the 1.35.0 milestone May 30, 2024
@OmerRaviv
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbempel jpbempel jpbempel approved these changes

@nikita-tkachenko-datadog nikita-tkachenko-datadog nikita-tkachenko-datadog approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

@OmerRaviv OmerRaviv Awaiting requested review from OmerRaviv

Assignees
No one assigned
Labels
comp: telemetry Telemetry
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smola @OmerRaviv @jpbempel @nikita-tkachenko-datadog