Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1109 #6937

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: #1109 #6937

wants to merge 1 commit into from

Conversation

AndesKrrrrrrrrrrr
Copy link

@AndesKrrrrrrrrrrr AndesKrrrrrrrrrrr commented Apr 23, 2024 •
edited

The default time format is causing issues for automatic log parsing.

See #1109 (comment)

@AndesKrrrrrrrrrrr AndesKrrrrrrrrrrr requested a review from a team as a code owner April 23, 2024 12:23
@PerfectSlayer
Copy link
Contributor

Hi @AndesKrrrrrrrrrrr

Thanks for you contribution!
I will try to find what’s the impact of this change to make sure it won’t break any other features.
In the same time, can you run ./gradlew :dd-java-agent:agent-bootstrap:spotlessApply to fix formatting and allow the CI tests to run? Thanks

@PerfectSlayer PerfectSlayer added type: bug tag: community Community contribution labels Apr 23, 2024
@PerfectSlayer PerfectSlayer marked this pull request as draft May 2, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer PerfectSlayer is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
tag: community Community contribution type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndesKrrrrrrrrrrr @PerfectSlayer