Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump JMXFetch to 0.49.1 #6935

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump JMXFetch to 0.49.1 #6935

wants to merge 1 commit into from
+2 −2

Conversation

carlosroman
Copy link

What Does This Do

Motivation

Bumps JMXFetch to 0.49.1 as it adds ZGC Major and Minor Cycles and ZGC Major and Minor Pauses beans support out of the box (Generational ZGC support).

Additional Notes

Changes since last update:

@carlosroman carlosroman added the comp: metrics Metrics label Apr 23, 2024
@carlosroman carlosroman requested a review from a team as a code owner April 23, 2024 10:20
@carlosroman carlosroman force-pushed the carlosroman/AMLII-1643-bump-jmxfetch branch from 03f771f to 08455e3 Compare April 23, 2024 10:28
@PerfectSlayer PerfectSlayer added the tag: dependencies Dependencies related changes label Apr 23, 2024
@PerfectSlayer PerfectSlayer changed the title JMXFetch 0.49.1 Bump JMXFetch to 0.49.1 Apr 23, 2024
@lcaproni-pp lcaproni-pp mentioned this pull request May 29, 2024
Open
@mcculls mcculls force-pushed the carlosroman/AMLII-1643-bump-jmxfetch branch from 08455e3 to 5fc113f Compare May 29, 2024 22:16
mcculls
mcculls requested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some failing JMXFetch tests that need fixing before this can be merged

@pr-commenter
Copy link

pr-commenter bot commented May 29, 2024 •
edited

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master carlosroman/AMLII-1643-bump-jmxfetch
git_commit_date 1717055384 1717056063
git_commit_sha d46ec26 5d2bf85
release_version 1.35.0-SNAPSHOT~d46ec26ae2 1.35.0-SNAPSHOT~5d2bf85915
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717058832 1717058832
ci_job_id 526868071 526868071
ci_pipeline_id 35430629 35430629
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~5d2bf85915, baseline=1.35.0-SNAPSHOT~d46ec26ae2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063756
Total [baseline] (8.582 s) : 0, 8581637
Agent [candidate] (1.063 s) : 0, 1062765
Total [candidate] (8.547 s) : 0, 8546550
section iast
Agent [baseline] (1.166 s) : 0, 1166270
Total [baseline] (9.016 s) : 0, 9016152
Agent [candidate] (1.165 s) : 0, 1164946
Total [candidate] (8.982 s) : 0, 8982126
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1174421
Total [baseline] (9.008 s) : 0, 9007915
Agent [candidate] (1.172 s) : 0, 1171941
Total [candidate] (8.984 s) : 0, 8983591
section iast_TELEMETRY_OFF
Agent [baseline] (1.163 s) : 0, 1162768
Total [baseline] (9.021 s) : 0, 9021064
Agent [candidate] (1.163 s) : 0, 1162527
Total [candidate] (8.992 s) : 0, 8991553
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent iast 1.166 s 102.514 ms (9.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.174 s 110.665 ms (10.4%)
Agent iast_TELEMETRY_OFF 1.163 s 99.012 ms (9.3%)
Total tracing 8.582 s -
Total iast 9.016 s 434.515 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.008 s 426.278 ms (5.0%)
Total iast_TELEMETRY_OFF 9.021 s 439.427 ms (5.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.165 s 102.181 ms (9.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 109.176 ms (10.3%)
Agent iast_TELEMETRY_OFF 1.163 s 99.762 ms (9.4%)
Total tracing 8.547 s -
Total iast 8.982 s 435.576 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.984 s 437.041 ms (5.1%)
Total iast_TELEMETRY_OFF 8.992 s 445.003 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~5d2bf85915, baseline=1.35.0-SNAPSHOT~d46ec26ae2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (656.5 ms) : 0, 656500
BytebuddyAgent [candidate] (656.046 ms) : 0, 656046
GlobalTracer [baseline] (314.197 ms) : 0, 314197
GlobalTracer [candidate] (313.781 ms) : 0, 313781
AppSec [baseline] (50.195 ms) : 0, 50195
AppSec [candidate] (50.003 ms) : 0, 50003
Remote Config [baseline] (667.669 µs) : 0, 668
Remote Config [candidate] (680.631 µs) : 0, 681
Telemetry [baseline] (7.685 ms) : 0, 7685
Telemetry [candidate] (7.62 ms) : 0, 7620
section iast
BytebuddyAgent [baseline] (779.216 ms) : 0, 779216
BytebuddyAgent [candidate] (777.594 ms) : 0, 777594
GlobalTracer [baseline] (292.279 ms) : 0, 292279
GlobalTracer [candidate] (291.266 ms) : 0, 291266
AppSec [baseline] (49.267 ms) : 0, 49267
AppSec [candidate] (48.374 ms) : 0, 48374
Remote Config [baseline] (601.466 µs) : 0, 601
Remote Config [candidate] (590.919 µs) : 0, 591
Telemetry [baseline] (6.962 ms) : 0, 6962
Telemetry [candidate] (9.909 ms) : 0, 9909
IAST [baseline] (24.696 ms) : 0, 24696
IAST [candidate] (23.957 ms) : 0, 23957
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (784.378 ms) : 0, 784378
BytebuddyAgent [candidate] (783.096 ms) : 0, 783096
GlobalTracer [baseline] (294.197 ms) : 0, 294197
GlobalTracer [candidate] (293.287 ms) : 0, 293287
AppSec [baseline] (48.785 ms) : 0, 48785
AppSec [candidate] (48.361 ms) : 0, 48361
Remote Config [baseline] (598.923 µs) : 0, 599
Remote Config [candidate] (585.393 µs) : 0, 585
Telemetry [baseline] (9.9 ms) : 0, 9900
Telemetry [candidate] (6.889 ms) : 0, 6889
IAST [baseline] (23.196 ms) : 0, 23196
IAST [candidate] (26.337 ms) : 0, 26337
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (775.912 ms) : 0, 775912
BytebuddyAgent [candidate] (775.483 ms) : 0, 775483
GlobalTracer [baseline] (291.874 ms) : 0, 291874
GlobalTracer [candidate] (292.37 ms) : 0, 292370
AppSec [baseline] (51.808 ms) : 0, 51808
AppSec [candidate] (51.298 ms) : 0, 51298
Remote Config [baseline] (590.375 µs) : 0, 590
Remote Config [candidate] (603.759 µs) : 0, 604
Telemetry [baseline] (8.202 ms) : 0, 8202
Telemetry [candidate] (7.481 ms) : 0, 7481
IAST [baseline] (21.08 ms) : 0, 21080
IAST [candidate] (21.96 ms) : 0, 21960
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~5d2bf85915, baseline=1.35.0-SNAPSHOT~d46ec26ae2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059599
Total [baseline] (10.43 s) : 0, 10429980
Agent [candidate] (1.065 s) : 0, 1064774
Total [candidate] (10.302 s) : 0, 10302311
section appsec
Agent [baseline] (1.182 s) : 0, 1181846
Total [baseline] (10.541 s) : 0, 10541283
Agent [candidate] (1.174 s) : 0, 1174480
Total [candidate] (10.486 s) : 0, 10485939
section iast
Agent [baseline] (1.184 s) : 0, 1183608
Total [baseline] (10.863 s) : 0, 10863215
Agent [candidate] (1.169 s) : 0, 1169479
Total [candidate] (10.853 s) : 0, 10853111
section profiling
Agent [baseline] (1.258 s) : 0, 1258031
Total [baseline] (10.627 s) : 0, 10626504
Agent [candidate] (1.262 s) : 0, 1262432
Total [candidate] (10.674 s) : 0, 10673885
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent appsec 1.182 s 122.247 ms (11.5%)
Agent iast 1.184 s 124.009 ms (11.7%)
Agent profiling 1.258 s 198.432 ms (18.7%)
Total tracing 10.43 s -
Total appsec 10.541 s 111.303 ms (1.1%)
Total iast 10.863 s 433.236 ms (4.2%)
Total profiling 10.627 s 196.525 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent appsec 1.174 s 109.706 ms (10.3%)
Agent iast 1.169 s 104.705 ms (9.8%)
Agent profiling 1.262 s 197.658 ms (18.6%)
Total tracing 10.302 s -
Total appsec 10.486 s 183.628 ms (1.8%)
Total iast 10.853 s 550.8 ms (5.3%)
Total profiling 10.674 s 371.573 ms (3.6%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~5d2bf85915, baseline=1.35.0-SNAPSHOT~d46ec26ae2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (654.034 ms) : 0, 654034
BytebuddyAgent [candidate] (656.908 ms) : 0, 656908
GlobalTracer [baseline] (312.983 ms) : 0, 312983
GlobalTracer [candidate] (314.466 ms) : 0, 314466
AppSec [baseline] (49.988 ms) : 0, 49988
AppSec [candidate] (50.294 ms) : 0, 50294
Remote Config [baseline] (658.468 µs) : 0, 658
Remote Config [candidate] (672.309 µs) : 0, 672
Telemetry [baseline] (7.535 ms) : 0, 7535
Telemetry [candidate] (7.677 ms) : 0, 7677
section appsec
BytebuddyAgent [baseline] (679.1 ms) : 0, 679100
BytebuddyAgent [candidate] (673.605 ms) : 0, 673605
GlobalTracer [baseline] (296.762 ms) : 0, 296762
GlobalTracer [candidate] (295.117 ms) : 0, 295117
AppSec [baseline] (153.143 ms) : 0, 153143
AppSec [candidate] (152.637 ms) : 0, 152637
Remote Config [baseline] (632.988 µs) : 0, 633
Remote Config [candidate] (630.332 µs) : 0, 630
Telemetry [baseline] (8.116 ms) : 0, 8116
Telemetry [candidate] (8.707 ms) : 0, 8707
IAST [baseline] (18.834 ms) : 0, 18834
IAST [candidate] (18.815 ms) : 0, 18815
section iast
BytebuddyAgent [baseline] (790.686 ms) : 0, 790686
BytebuddyAgent [candidate] (780.644 ms) : 0, 780644
GlobalTracer [baseline] (296.301 ms) : 0, 296301
GlobalTracer [candidate] (294.145 ms) : 0, 294145
AppSec [baseline] (48.173 ms) : 0, 48173
AppSec [candidate] (50.779 ms) : 0, 50779
Remote Config [baseline] (595.912 µs) : 0, 596
Remote Config [candidate] (591.068 µs) : 0, 591
Telemetry [baseline] (9.26 ms) : 0, 9260
Telemetry [candidate] (7.695 ms) : 0, 7695
IAST [baseline] (25.218 ms) : 0, 25218
IAST [candidate] (22.38 ms) : 0, 22380
section profiling
BytebuddyAgent [baseline] (661.978 ms) : 0, 661978
BytebuddyAgent [candidate] (665.253 ms) : 0, 665253
GlobalTracer [baseline] (384.961 ms) : 0, 384961
GlobalTracer [candidate] (385.506 ms) : 0, 385506
AppSec [baseline] (50.321 ms) : 0, 50321
AppSec [candidate] (50.475 ms) : 0, 50475
Remote Config [baseline] (839.178 µs) : 0, 839
Remote Config [candidate] (925.344 µs) : 0, 925
Telemetry [baseline] (7.481 ms) : 0, 7481
Telemetry [candidate] (7.414 ms) : 0, 7414
ProfilingAgent [baseline] (95.962 ms) : 0, 95962
ProfilingAgent [candidate] (95.942 ms) : 0, 95942
Profiling [baseline] (95.986 ms) : 0, 95986
Profiling [candidate] (95.966 ms) : 0, 95966

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-30T08:17:50 2024-05-30T08:24:40
git_branch master carlosroman/AMLII-1643-bump-jmxfetch
git_commit_date 1717055384 1717056063
git_commit_sha d46ec26 5d2bf85
release_version 1.35.0-SNAPSHOT~d46ec26ae2 1.35.0-SNAPSHOT~5d2bf85915
start_time 2024-05-30T08:17:36 2024-05-30T08:24:26
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717057826 1717057826
ci_job_id 526868072 526868072
ci_pipeline_id 35430629 35430629
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~5d2bf85915, baseline=1.35.0-SNAPSHOT~d46ec26ae2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.348 ms) : 1328, 1367
.   : milestone, 1348,
appsec (1.748 ms) : 1723, 1772
.   : milestone, 1748,
appsec_no_iast (1.714 ms) : 1689, 1739
.   : milestone, 1714,
iast (1.479 ms) : 1457, 1501
.   : milestone, 1479,
profiling (1.48 ms) : 1457, 1503
.   : milestone, 1480,
tracing (1.489 ms) : 1464, 1515
.   : milestone, 1489,
section candidate
no_agent (1.34 ms) : 1321, 1359
.   : milestone, 1340,
appsec (1.736 ms) : 1713, 1759
.   : milestone, 1736,
appsec_no_iast (1.719 ms) : 1694, 1744
.   : milestone, 1719,
iast (1.481 ms) : 1459, 1504
.   : milestone, 1481,
profiling (1.497 ms) : 1471, 1523
.   : milestone, 1497,
tracing (1.482 ms) : 1458, 1506
.   : milestone, 1482,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.328 ms, 1.367 ms] -
appsec 1.748 ms [1.723 ms, 1.772 ms] 399.847 µs (29.7%)
appsec_no_iast 1.714 ms [1.689 ms, 1.739 ms] 366.283 µs (27.2%)
iast 1.479 ms [1.457 ms, 1.501 ms] 131.505 µs (9.8%)
profiling 1.48 ms [1.457 ms, 1.503 ms] 132.548 µs (9.8%)
tracing 1.489 ms [1.464 ms, 1.515 ms] 141.522 µs (10.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.34 ms [1.321 ms, 1.359 ms] -
appsec 1.736 ms [1.713 ms, 1.759 ms] 395.948 µs (29.5%)
appsec_no_iast 1.719 ms [1.694 ms, 1.744 ms] 378.201 µs (28.2%)
iast 1.481 ms [1.459 ms, 1.504 ms] 141.049 µs (10.5%)
profiling 1.497 ms [1.471 ms, 1.523 ms] 156.88 µs (11.7%)
tracing 1.482 ms [1.458 ms, 1.506 ms] 141.441 µs (10.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~5d2bf85915, baseline=1.35.0-SNAPSHOT~d46ec26ae2
    dateFormat X
    axisFormat %s
section baseline
no_agent (368.844 µs) : 349, 389
.   : milestone, 369,
iast (488.75 µs) : 467, 510
.   : milestone, 489,
iast_FULL (556.919 µs) : 536, 578
.   : milestone, 557,
iast_GLOBAL (505.86 µs) : 485, 527
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (489.716 µs) : 469, 511
.   : milestone, 490,
iast_INACTIVE (460.745 µs) : 439, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (477.334 µs) : 456, 499
.   : milestone, 477,
tracing (446.951 µs) : 426, 468
.   : milestone, 447,
section candidate
no_agent (374.548 µs) : 354, 396
.   : milestone, 375,
iast (483.063 µs) : 462, 504
.   : milestone, 483,
iast_FULL (555.514 µs) : 534, 577
.   : milestone, 556,
iast_GLOBAL (506.06 µs) : 485, 527
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (488.889 µs) : 468, 510
.   : milestone, 489,
iast_INACTIVE (461.485 µs) : 440, 483
.   : milestone, 461,
iast_TELEMETRY_OFF (481.358 µs) : 460, 503
.   : milestone, 481,
tracing (448.175 µs) : 428, 469
.   : milestone, 448,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.844 µs [348.994 µs, 388.694 µs] -
iast 488.75 µs [467.481 µs, 510.019 µs] 119.906 µs (32.5%)
iast_FULL 556.919 µs [535.852 µs, 577.986 µs] 188.075 µs (51.0%)
iast_GLOBAL 505.86 µs [484.878 µs, 526.842 µs] 137.016 µs (37.1%)
iast_HARDCODED_SECRET_DISABLED 489.716 µs [468.678 µs, 510.754 µs] 120.872 µs (32.8%)
iast_INACTIVE 460.745 µs [439.007 µs, 482.484 µs] 91.901 µs (24.9%)
iast_TELEMETRY_OFF 477.334 µs [455.955 µs, 498.713 µs] 108.49 µs (29.4%)
tracing 446.951 µs [425.784 µs, 468.117 µs] 78.107 µs (21.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.548 µs [353.52 µs, 395.576 µs] -
iast 483.063 µs [462.16 µs, 503.967 µs] 108.516 µs (29.0%)
iast_FULL 555.514 µs [534.463 µs, 576.564 µs] 180.966 µs (48.3%)
iast_GLOBAL 506.06 µs [485.14 µs, 526.979 µs] 131.512 µs (35.1%)
iast_HARDCODED_SECRET_DISABLED 488.889 µs [468.143 µs, 509.634 µs] 114.341 µs (30.5%)
iast_INACTIVE 461.485 µs [439.971 µs, 482.999 µs] 86.937 µs (23.2%)
iast_TELEMETRY_OFF 481.358 µs [459.72 µs, 502.996 µs] 106.81 µs (28.5%)
tracing 448.175 µs [427.519 µs, 468.831 µs] 73.627 µs (19.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master carlosroman/AMLII-1643-bump-jmxfetch
git_commit_date 1717055384 1717056063
git_commit_sha d46ec26 5d2bf85
release_version 1.35.0-SNAPSHOT~d46ec26ae2 1.35.0-SNAPSHOT~5d2bf85915
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1717058332 1717058332
ci_job_id 526868073 526868073
ci_pipeline_id 35430629 35430629
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~5d2bf85915, baseline=1.35.0-SNAPSHOT~d46ec26ae2
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.571 s) : 15571000, 15571000
.   : milestone, 15571000,
appsec (15.191 s) : 15191000, 15191000
.   : milestone, 15191000,
iast (18.928 s) : 18928000, 18928000
.   : milestone, 18928000,
iast_GLOBAL (17.919 s) : 17919000, 17919000
.   : milestone, 17919000,
profiling (15.568 s) : 15568000, 15568000
.   : milestone, 15568000,
tracing (15.119 s) : 15119000, 15119000
.   : milestone, 15119000,
section candidate
no_agent (15.02 s) : 15020000, 15020000
.   : milestone, 15020000,
appsec (15.158 s) : 15158000, 15158000
.   : milestone, 15158000,
iast (18.791 s) : 18791000, 18791000
.   : milestone, 18791000,
iast_GLOBAL (17.895 s) : 17895000, 17895000
.   : milestone, 17895000,
profiling (15.382 s) : 15382000, 15382000
.   : milestone, 15382000,
tracing (15.47 s) : 15470000, 15470000
.   : milestone, 15470000,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.571 s [15.571 s, 15.571 s] -
appsec 15.191 s [15.191 s, 15.191 s] -380.0 ms (-2.4%)
iast 18.928 s [18.928 s, 18.928 s] 3.357 s (21.6%)
iast_GLOBAL 17.919 s [17.919 s, 17.919 s] 2.348 s (15.1%)
profiling 15.568 s [15.568 s, 15.568 s] -3.0 ms (-0.0%)
tracing 15.119 s [15.119 s, 15.119 s] -452.0 ms (-2.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.02 s [15.02 s, 15.02 s] -
appsec 15.158 s [15.158 s, 15.158 s] 138.0 ms (0.9%)
iast 18.791 s [18.791 s, 18.791 s] 3.771 s (25.1%)
iast_GLOBAL 17.895 s [17.895 s, 17.895 s] 2.875 s (19.1%)
profiling 15.382 s [15.382 s, 15.382 s] 362.0 ms (2.4%)
tracing 15.47 s [15.47 s, 15.47 s] 450.0 ms (3.0%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~5d2bf85915, baseline=1.35.0-SNAPSHOT~d46ec26ae2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.456 ms) : 1445, 1468
.   : milestone, 1456,
appsec (2.198 ms) : 2164, 2233
.   : milestone, 2198,
iast (1.953 ms) : 1912, 1994
.   : milestone, 1953,
iast_GLOBAL (1.996 ms) : 1954, 2037
.   : milestone, 1996,
profiling (1.844 ms) : 1811, 1877
.   : milestone, 1844,
tracing (1.825 ms) : 1793, 1857
.   : milestone, 1825,
section candidate
no_agent (1.461 ms) : 1449, 1472
.   : milestone, 1461,
appsec (2.195 ms) : 2161, 2228
.   : milestone, 2195,
iast (1.962 ms) : 1921, 2004
.   : milestone, 1962,
iast_GLOBAL (1.978 ms) : 1938, 2019
.   : milestone, 1978,
profiling (1.843 ms) : 1809, 1876
.   : milestone, 1843,
tracing (1.82 ms) : 1788, 1852
.   : milestone, 1820,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.445 ms, 1.468 ms] -
appsec 2.198 ms [2.164 ms, 2.233 ms] 742.132 µs (51.0%)
iast 1.953 ms [1.912 ms, 1.994 ms] 497.109 µs (34.1%)
iast_GLOBAL 1.996 ms [1.954 ms, 2.037 ms] 539.314 µs (37.0%)
profiling 1.844 ms [1.811 ms, 1.877 ms] 387.59 µs (26.6%)
tracing 1.825 ms [1.793 ms, 1.857 ms] 368.357 µs (25.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.449 ms, 1.472 ms] -
appsec 2.195 ms [2.161 ms, 2.228 ms] 733.964 µs (50.2%)
iast 1.962 ms [1.921 ms, 2.004 ms] 501.324 µs (34.3%)
iast_GLOBAL 1.978 ms [1.938 ms, 2.019 ms] 517.587 µs (35.4%)
profiling 1.843 ms [1.809 ms, 1.876 ms] 381.864 µs (26.1%)
tracing 1.82 ms [1.788 ms, 1.852 ms] 358.974 µs (24.6%)

@carlosroman carlosroman force-pushed the carlosroman/AMLII-1643-bump-jmxfetch branch from 5fc113f to 5d2bf85 Compare May 30, 2024 08:01
@mcculls
Copy link
Contributor

mcculls commented May 30, 2024 •
edited

FYI, the failing tests are because the JMXFetch App class is attempting to register an MBean in its constructor: https://github.com/DataDog/jmxfetch/blob/0.49.1/src/main/java/org/datadog/jmxfetch/App.java#L136

When JMXFetch is embedded and the user's application is using a custom MBean manager this may fail, which is what the failing tests have detected.

Ideally JMXFetch would only attempt to register the telemetry MBean if telemetry was enabled in AppConfig, or perhaps when AppConfig.isEmbedded() is false. That would require a new release of JMXFetch, but would be the cleanest solution.

Alternatively the call to register the telemetry MBean could be moved from the App constructor to the init method (since that would also require a change to JMXFetch it would be good to still add a way to turn off registration of the telemetry MBean as discussed above.)

Without a new release of JMXFetch the two options are:

  • add the updated new-gc-default-jmx-metrics.yaml file to dd-java-agent/agent-jmxfetch/src/main/resources/ so it overrides the file from 0.49.0 when everything is packed into the final dd-java-agent jar (this is the main reason for the upgrade I believe)
    • we'll have to remember to remove this file when we next update JMXFetch, but this is a safe workaround
  • Rework the way we start JMXFetch to catch failures in the constructor and retry
    • This is more risky because the constructor might be setting up other resources, and since the new MBean registration is at the bottom of the constructor those resources might not be cleaned up properly if/when the registration fails

@carlosroman
Copy link
Author

@mcculls I'll have a look and see what can be done. Happy to do a new release of JMXFetch to fix this properly.

@mcculls
Copy link
Contributor

mcculls commented May 30, 2024

thanks @carlosroman!

@carlosroman carlosroman mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls requested changes

@dougqh dougqh dougqh approved these changes

@am312 am312 Awaiting requested review from am312 am312 is a code owner automatically assigned from DataDog/apm-java

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
comp: metrics Metrics tag: dependencies Dependencies related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carlosroman @mcculls @dougqh @PerfectSlayer