Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A prototype to use jfr streaming to produce metrics #6929

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

A prototype to use jfr streaming to produce metrics #6929

wants to merge 1 commit into from

Conversation

jbachorik
Copy link
Contributor

@jbachorik jbachorik commented Apr 19, 2024 •
edited by jira bot

What Does This Do

This is a simple prototype of how to extract JFR data into statsd metrics using JFR streaming.

Motivation

A PoC of the functionality to verify if this approach is acceptable by our customers.

Additional Notes

The feature is guarded by an experimental config option and is disabled by default.

Jira ticket: PROF-9618

@jbachorik jbachorik force-pushed the jb/jfr_metrics branch 3 times, most recently from 5b4ac52 to 75d29aa Compare April 19, 2024 21:48
@jbachorik jbachorik marked this pull request as ready for review April 19, 2024 22:09
@jbachorik jbachorik requested a review from a team as a code owner April 19, 2024 22:09
@pr-commenter
Copy link

pr-commenter bot commented Apr 19, 2024 •
edited

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/jfr_metrics
git_commit_date 1713966590 1713970645
git_commit_sha 5316d23 f93a3c8
release_version 1.34.0-SNAPSHOT~5316d23037 1.34.0-SNAPSHOT~f93a3c8cb8
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1713973088 1713973088
ci_job_id 495830068 495830068
ci_pipeline_id 32826562 32826562
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~f93a3c8cb8, baseline=1.34.0-SNAPSHOT~5316d23037

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1073256
Total [baseline] (10.389 s) : 0, 10388607
Agent [candidate] (1.074 s) : 0, 1073606
Total [candidate] (10.388 s) : 0, 10388116
section appsec
Agent [baseline] (1.194 s) : 0, 1194254
Total [baseline] (10.594 s) : 0, 10594081
Agent [candidate] (1.19 s) : 0, 1189569
Total [candidate] (10.524 s) : 0, 10523535
section iast
Agent [baseline] (1.199 s) : 0, 1199176
Total [baseline] (10.692 s) : 0, 10691983
Agent [candidate] (1.2 s) : 0, 1199615
Total [candidate] (10.805 s) : 0, 10805023
section profiling
Agent [baseline] (1.272 s) : 0, 1272295
Total [baseline] (10.679 s) : 0, 10679404
Agent [candidate] (1.276 s) : 0, 1275869
Total [candidate] (10.742 s) : 0, 10741575
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent appsec 1.194 s 120.998 ms (11.3%)
Agent iast 1.199 s 125.92 ms (11.7%)
Agent profiling 1.272 s 199.039 ms (18.5%)
Total tracing 10.389 s -
Total appsec 10.594 s 205.474 ms (2.0%)
Total iast 10.692 s 303.376 ms (2.9%)
Total profiling 10.679 s 290.798 ms (2.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent appsec 1.19 s 115.963 ms (10.8%)
Agent iast 1.2 s 126.009 ms (11.7%)
Agent profiling 1.276 s 202.264 ms (18.8%)
Total tracing 10.388 s -
Total appsec 10.524 s 135.419 ms (1.3%)
Total iast 10.805 s 416.907 ms (4.0%)
Total profiling 10.742 s 353.459 ms (3.4%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~f93a3c8cb8, baseline=1.34.0-SNAPSHOT~5316d23037

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.379 ms) : 0, 672379
BytebuddyAgent [candidate] (672.286 ms) : 0, 672286
GlobalTracer [baseline] (309.15 ms) : 0, 309150
GlobalTracer [candidate] (309.374 ms) : 0, 309374
AppSec [baseline] (49.233 ms) : 0, 49233
AppSec [candidate] (49.348 ms) : 0, 49348
Remote Config [baseline] (659.417 µs) : 0, 659
Remote Config [candidate] (663.157 µs) : 0, 663
Telemetry [baseline] (7.6 ms) : 0, 7600
Telemetry [candidate] (7.584 ms) : 0, 7584
section appsec
BytebuddyAgent [baseline] (697.532 ms) : 0, 697532
BytebuddyAgent [candidate] (695.532 ms) : 0, 695532
GlobalTracer [baseline] (292.854 ms) : 0, 292854
GlobalTracer [candidate] (291.493 ms) : 0, 291493
AppSec [baseline] (150.095 ms) : 0, 150095
AppSec [candidate] (149.725 ms) : 0, 149725
Remote Config [baseline] (629.745 µs) : 0, 630
Remote Config [candidate] (619.255 µs) : 0, 619
Telemetry [baseline] (8.935 ms) : 0, 8935
Telemetry [candidate] (8.172 ms) : 0, 8172
IAST [baseline] (19.412 ms) : 0, 19412
IAST [candidate] (19.164 ms) : 0, 19164
section iast
BytebuddyAgent [baseline] (794.634 ms) : 0, 794634
BytebuddyAgent [candidate] (795.234 ms) : 0, 795234
GlobalTracer [baseline] (287.616 ms) : 0, 287616
GlobalTracer [candidate] (288.219 ms) : 0, 288219
AppSec [baseline] (50.208 ms) : 0, 50208
AppSec [candidate] (53.106 ms) : 0, 53106
Remote Config [baseline] (575.673 µs) : 0, 576
Remote Config [candidate] (564.358 µs) : 0, 564
Telemetry [baseline] (8.07 ms) : 0, 8070
Telemetry [candidate] (7.304 ms) : 0, 7304
IAST [baseline] (23.703 ms) : 0, 23703
IAST [candidate] (20.828 ms) : 0, 20828
section profiling
BytebuddyAgent [baseline] (680.062 ms) : 0, 680062
BytebuddyAgent [candidate] (681.935 ms) : 0, 681935
GlobalTracer [baseline] (381.142 ms) : 0, 381142
GlobalTracer [candidate] (382.791 ms) : 0, 382791
AppSec [baseline] (50.222 ms) : 0, 50222
AppSec [candidate] (50.551 ms) : 0, 50551
Remote Config [baseline] (710.511 µs) : 0, 711
Remote Config [candidate] (727.109 µs) : 0, 727
Telemetry [baseline] (7.503 ms) : 0, 7503
Telemetry [candidate] (7.469 ms) : 0, 7469
ProfilingAgent [baseline] (96.039 ms) : 0, 96039
ProfilingAgent [candidate] (95.661 ms) : 0, 95661
Profiling [baseline] (96.063 ms) : 0, 96063
Profiling [candidate] (95.685 ms) : 0, 95685
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~f93a3c8cb8, baseline=1.34.0-SNAPSHOT~5316d23037

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085713
Total [baseline] (8.596 s) : 0, 8596327
Agent [candidate] (1.074 s) : 0, 1074448
Total [candidate] (8.548 s) : 0, 8547891
section iast
Agent [baseline] (1.199 s) : 0, 1199185
Total [baseline] (9.013 s) : 0, 9013449
Agent [candidate] (1.199 s) : 0, 1198710
Total [candidate] (8.996 s) : 0, 8995975
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.198 s) : 0, 1198248
Total [baseline] (8.977 s) : 0, 8976672
Agent [candidate] (1.201 s) : 0, 1201311
Total [candidate] (9.013 s) : 0, 9013432
section iast_TELEMETRY_OFF
Agent [baseline] (1.195 s) : 0, 1195102
Total [baseline] (8.996 s) : 0, 8996385
Agent [candidate] (1.198 s) : 0, 1197521
Total [candidate] (8.981 s) : 0, 8981358
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent iast 1.199 s 113.472 ms (10.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.198 s 112.534 ms (10.4%)
Agent iast_TELEMETRY_OFF 1.195 s 109.389 ms (10.1%)
Total tracing 8.596 s -
Total iast 9.013 s 417.122 ms (4.9%)
Total iast_HARDCODED_SECRET_DISABLED 8.977 s 380.345 ms (4.4%)
Total iast_TELEMETRY_OFF 8.996 s 400.057 ms (4.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent iast 1.199 s 124.261 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.201 s 126.863 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.198 s 123.073 ms (11.5%)
Total tracing 8.548 s -
Total iast 8.996 s 448.085 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.013 s 465.541 ms (5.4%)
Total iast_TELEMETRY_OFF 8.981 s 433.467 ms (5.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~f93a3c8cb8, baseline=1.34.0-SNAPSHOT~5316d23037

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.997 ms) : 0, 679997
BytebuddyAgent [candidate] (673.187 ms) : 0, 673187
GlobalTracer [baseline] (312.566 ms) : 0, 312566
GlobalTracer [candidate] (309.335 ms) : 0, 309335
AppSec [baseline] (49.99 ms) : 0, 49990
AppSec [candidate] (49.203 ms) : 0, 49203
Remote Config [baseline] (671.699 µs) : 0, 672
Remote Config [candidate] (665.172 µs) : 0, 665
Telemetry [baseline] (7.658 ms) : 0, 7658
Telemetry [candidate] (7.604 ms) : 0, 7604
section iast
BytebuddyAgent [baseline] (794.036 ms) : 0, 794036
BytebuddyAgent [candidate] (794.147 ms) : 0, 794147
GlobalTracer [baseline] (288.153 ms) : 0, 288153
GlobalTracer [candidate] (288.222 ms) : 0, 288222
AppSec [baseline] (49.75 ms) : 0, 49750
AppSec [candidate] (53.04 ms) : 0, 53040
IAST [baseline] (25.72 ms) : 0, 25720
IAST [candidate] (20.689 ms) : 0, 20689
Remote Config [baseline] (578.922 µs) : 0, 579
Remote Config [candidate] (578.149 µs) : 0, 578
Telemetry [baseline] (6.586 ms) : 0, 6586
Telemetry [candidate] (7.421 ms) : 0, 7421
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (794.493 ms) : 0, 794493
BytebuddyAgent [candidate] (796.487 ms) : 0, 796487
GlobalTracer [baseline] (287.839 ms) : 0, 287839
GlobalTracer [candidate] (289.415 ms) : 0, 289415
AppSec [baseline] (49.348 ms) : 0, 49348
AppSec [candidate] (49.528 ms) : 0, 49528
IAST [baseline] (24.985 ms) : 0, 24985
IAST [candidate] (23.3 ms) : 0, 23300
Remote Config [baseline] (568.359 µs) : 0, 568
Remote Config [candidate] (578.223 µs) : 0, 578
Telemetry [baseline] (6.613 ms) : 0, 6613
Telemetry [candidate] (7.444 ms) : 0, 7444
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (791.448 ms) : 0, 791448
BytebuddyAgent [candidate] (792.516 ms) : 0, 792516
GlobalTracer [baseline] (287.758 ms) : 0, 287758
GlobalTracer [candidate] (288.81 ms) : 0, 288810
AppSec [baseline] (51.68 ms) : 0, 51680
AppSec [candidate] (49.607 ms) : 0, 49607
IAST [baseline] (22.784 ms) : 0, 22784
IAST [candidate] (24.268 ms) : 0, 24268
Remote Config [baseline] (586.33 µs) : 0, 586
Remote Config [candidate] (577.141 µs) : 0, 577
Telemetry [baseline] (6.568 ms) : 0, 6568
Telemetry [candidate] (7.275 ms) : 0, 7275

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-24T15:11:08 2024-04-24T15:17:58
git_branch master jb/jfr_metrics
git_commit_date 1713966590 1713970645
git_commit_sha 5316d23 f93a3c8
release_version 1.34.0-SNAPSHOT~5316d23037 1.34.0-SNAPSHOT~f93a3c8cb8
start_time 2024-04-24T15:10:55 2024-04-24T15:17:45
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1713972223 1713972223
ci_job_id 495830069 495830069
ci_pipeline_id 32826562 32826562
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~f93a3c8cb8, baseline=1.34.0-SNAPSHOT~5316d23037
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.353 ms) : 1333, 1372
.   : milestone, 1353,
appsec (1.729 ms) : 1706, 1753
.   : milestone, 1729,
appsec_no_iast (1.731 ms) : 1706, 1756
.   : milestone, 1731,
iast (1.494 ms) : 1471, 1516
.   : milestone, 1494,
profiling (1.512 ms) : 1486, 1538
.   : milestone, 1512,
tracing (1.486 ms) : 1462, 1510
.   : milestone, 1486,
section candidate
no_agent (1.344 ms) : 1325, 1364
.   : milestone, 1344,
appsec (1.721 ms) : 1696, 1745
.   : milestone, 1721,
appsec_no_iast (1.721 ms) : 1697, 1746
.   : milestone, 1721,
iast (1.504 ms) : 1482, 1527
.   : milestone, 1504,
profiling (1.501 ms) : 1477, 1526
.   : milestone, 1501,
tracing (1.502 ms) : 1478, 1526
.   : milestone, 1502,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.353 ms [1.333 ms, 1.372 ms] -
appsec 1.729 ms [1.706 ms, 1.753 ms] 376.453 µs (27.8%)
appsec_no_iast 1.731 ms [1.706 ms, 1.756 ms] 378.494 µs (28.0%)
iast 1.494 ms [1.471 ms, 1.516 ms] 141.167 µs (10.4%)
profiling 1.512 ms [1.486 ms, 1.538 ms] 159.168 µs (11.8%)
tracing 1.486 ms [1.462 ms, 1.51 ms] 133.273 µs (9.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.325 ms, 1.364 ms] -
appsec 1.721 ms [1.696 ms, 1.745 ms] 376.42 µs (28.0%)
appsec_no_iast 1.721 ms [1.697 ms, 1.746 ms] 376.875 µs (28.0%)
iast 1.504 ms [1.482 ms, 1.527 ms] 160.006 µs (11.9%)
profiling 1.501 ms [1.477 ms, 1.526 ms] 157.005 µs (11.7%)
tracing 1.502 ms [1.478 ms, 1.526 ms] 157.792 µs (11.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~f93a3c8cb8, baseline=1.34.0-SNAPSHOT~5316d23037
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.84 µs) : 348, 388
.   : milestone, 368,
iast (477.455 µs) : 456, 499
.   : milestone, 477,
iast_FULL (541.989 µs) : 520, 564
.   : milestone, 542,
iast_GLOBAL (490.058 µs) : 469, 511
.   : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (474.636 µs) : 453, 496
.   : milestone, 475,
iast_INACTIVE (449.25 µs) : 429, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (474.583 µs) : 454, 496
.   : milestone, 475,
tracing (455.088 µs) : 434, 476
.   : milestone, 455,
section candidate
no_agent (371.861 µs) : 352, 391
.   : milestone, 372,
iast (479.767 µs) : 458, 501
.   : milestone, 480,
iast_FULL (542.671 µs) : 521, 564
.   : milestone, 543,
iast_GLOBAL (501.585 µs) : 480, 523
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (480.371 µs) : 459, 502
.   : milestone, 480,
iast_INACTIVE (448.893 µs) : 428, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (479.342 µs) : 458, 500
.   : milestone, 479,
tracing (451.461 µs) : 430, 473
.   : milestone, 451,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.84 µs [347.868 µs, 387.813 µs] -
iast 477.455 µs [456.135 µs, 498.774 µs] 109.615 µs (29.8%)
iast_FULL 541.989 µs [520.457 µs, 563.521 µs] 174.149 µs (47.3%)
iast_GLOBAL 490.058 µs [468.678 µs, 511.439 µs] 122.218 µs (33.2%)
iast_HARDCODED_SECRET_DISABLED 474.636 µs [453.024 µs, 496.248 µs] 106.796 µs (29.0%)
iast_INACTIVE 449.25 µs [428.553 µs, 469.947 µs] 81.41 µs (22.1%)
iast_TELEMETRY_OFF 474.583 µs [453.547 µs, 495.619 µs] 106.743 µs (29.0%)
tracing 455.088 µs [433.892 µs, 476.284 µs] 87.248 µs (23.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.861 µs [352.28 µs, 391.442 µs] -
iast 479.767 µs [458.198 µs, 501.336 µs] 107.906 µs (29.0%)
iast_FULL 542.671 µs [521.496 µs, 563.846 µs] 170.81 µs (45.9%)
iast_GLOBAL 501.585 µs [480.263 µs, 522.907 µs] 129.723 µs (34.9%)
iast_HARDCODED_SECRET_DISABLED 480.371 µs [458.737 µs, 502.004 µs] 108.51 µs (29.2%)
iast_INACTIVE 448.893 µs [428.003 µs, 469.782 µs] 77.031 µs (20.7%)
iast_TELEMETRY_OFF 479.342 µs [458.278 µs, 500.406 µs] 107.481 µs (28.9%)
tracing 451.461 µs [430.017 µs, 472.906 µs] 79.6 µs (21.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/jfr_metrics
git_commit_date 1713966590 1713970645
git_commit_sha 5316d23 f93a3c8
release_version 1.34.0-SNAPSHOT~5316d23037 1.34.0-SNAPSHOT~f93a3c8cb8
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1713972744 1713972744
ci_job_id 495830070 495830070
ci_pipeline_id 32826562 32826562
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~f93a3c8cb8, baseline=1.34.0-SNAPSHOT~5316d23037
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.458 ms) : 1446, 1469
.   : milestone, 1458,
appsec (2.19 ms) : 2157, 2224
.   : milestone, 2190,
iast (1.871 ms) : 1836, 1905
.   : milestone, 1871,
iast_GLOBAL (1.919 ms) : 1884, 1955
.   : milestone, 1919,
profiling (1.841 ms) : 1808, 1873
.   : milestone, 1841,
tracing (1.829 ms) : 1797, 1861
.   : milestone, 1829,
section candidate
no_agent (1.46 ms) : 1449, 1471
.   : milestone, 1460,
appsec (2.183 ms) : 2150, 2217
.   : milestone, 2183,
iast (1.885 ms) : 1850, 1921
.   : milestone, 1885,
iast_GLOBAL (1.907 ms) : 1873, 1942
.   : milestone, 1907,
profiling (1.844 ms) : 1810, 1878
.   : milestone, 1844,
tracing (1.821 ms) : 1789, 1852
.   : milestone, 1821,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.446 ms, 1.469 ms] -
appsec 2.19 ms [2.157 ms, 2.224 ms] 732.624 µs (50.3%)
iast 1.871 ms [1.836 ms, 1.905 ms] 413.186 µs (28.3%)
iast_GLOBAL 1.919 ms [1.884 ms, 1.955 ms] 461.518 µs (31.7%)
profiling 1.841 ms [1.808 ms, 1.873 ms] 383.043 µs (26.3%)
tracing 1.829 ms [1.797 ms, 1.861 ms] 371.328 µs (25.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.471 ms] -
appsec 2.183 ms [2.15 ms, 2.217 ms] 723.371 µs (49.5%)
iast 1.885 ms [1.85 ms, 1.921 ms] 425.493 µs (29.1%)
iast_GLOBAL 1.907 ms [1.873 ms, 1.942 ms] 447.341 µs (30.6%)
profiling 1.844 ms [1.81 ms, 1.878 ms] 384.151 µs (26.3%)
tracing 1.821 ms [1.789 ms, 1.852 ms] 360.594 µs (24.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~f93a3c8cb8, baseline=1.34.0-SNAPSHOT~5316d23037
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.566 s) : 15566000, 15566000
.   : milestone, 15566000,
appsec (15.236 s) : 15236000, 15236000
.   : milestone, 15236000,
iast (18.744 s) : 18744000, 18744000
.   : milestone, 18744000,
iast_GLOBAL (18.034 s) : 18034000, 18034000
.   : milestone, 18034000,
profiling (15.148 s) : 15148000, 15148000
.   : milestone, 15148000,
tracing (15.562 s) : 15562000, 15562000
.   : milestone, 15562000,
section candidate
no_agent (14.992 s) : 14992000, 14992000
.   : milestone, 14992000,
appsec (15.175 s) : 15175000, 15175000
.   : milestone, 15175000,
iast (18.732 s) : 18732000, 18732000
.   : milestone, 18732000,
iast_GLOBAL (17.99 s) : 17990000, 17990000
.   : milestone, 17990000,
profiling (15.037 s) : 15037000, 15037000
.   : milestone, 15037000,
tracing (15.142 s) : 15142000, 15142000
.   : milestone, 15142000,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.566 s [15.566 s, 15.566 s] -
appsec 15.236 s [15.236 s, 15.236 s] -330.0 ms (-2.1%)
iast 18.744 s [18.744 s, 18.744 s] 3.178 s (20.4%)
iast_GLOBAL 18.034 s [18.034 s, 18.034 s] 2.468 s (15.9%)
profiling 15.148 s [15.148 s, 15.148 s] -418.0 ms (-2.7%)
tracing 15.562 s [15.562 s, 15.562 s] -4.0 ms (-0.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.992 s [14.992 s, 14.992 s] -
appsec 15.175 s [15.175 s, 15.175 s] 183.0 ms (1.2%)
iast 18.732 s [18.732 s, 18.732 s] 3.74 s (24.9%)
iast_GLOBAL 17.99 s [17.99 s, 17.99 s] 2.998 s (20.0%)
profiling 15.037 s [15.037 s, 15.037 s] 45.0 ms (0.3%)
tracing 15.142 s [15.142 s, 15.142 s] 150.0 ms (1.0%)

@jbachorik jbachorik requested a review from a team as a code owner April 24, 2024 14:57
@jbachorik jbachorik requested review from ojung and removed request for a team April 24, 2024 14:57
@PerfectSlayer PerfectSlayer added comp: profiling Profiling tag: experimental Experimental changes labels Apr 25, 2024
ygree
ygree approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygree ygree ygree approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

@richardstartin richardstartin Awaiting requested review from richardstartin

@ojung ojung Awaiting requested review from ojung ojung is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: profiling Profiling tag: experimental Experimental changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbachorik @ygree @PerfectSlayer