Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT][undertow] checking http route #6801

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

[DRAFT][undertow] checking http route #6801

wants to merge 6 commits into from

Conversation

asdftamir
Copy link

What Does This Do

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Mar 12, 2024 •
edited

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master tamir.hyman/test-undertow
git_commit_date 1710236254 1710313743
git_commit_sha a786410 79ae3c3
release_version 1.32.0-SNAPSHOT~a786410129 1.32.0-SNAPSHOT~79ae3c32d9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1710316996 1710316996
ci_job_id 458371982 458371982
ci_pipeline_id 30006496 30006496
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.32.0-SNAPSHOT~79ae3c32d9, baseline=1.32.0-SNAPSHOT~a786410129

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079957
Total [baseline] (9.168 s) : 0, 9167636
Agent [candidate] (1.082 s) : 0, 1082242
Total [candidate] (9.205 s) : 0, 9204830
section appsec
Agent [baseline] (1.211 s) : 0, 1211302
Total [baseline] (9.31 s) : 0, 9309860
Agent [candidate] (1.204 s) : 0, 1203662
Total [candidate] (9.286 s) : 0, 9285893
section iast
Agent [baseline] (1.202 s) : 0, 1202353
Total [baseline] (9.313 s) : 0, 9313065
Agent [candidate] (1.206 s) : 0, 1205929
Total [candidate] (9.317 s) : 0, 9317104
section profiling
Agent [baseline] (1.276 s) : 0, 1275947
Total [baseline] (9.382 s) : 0, 9381805
Agent [candidate] (1.282 s) : 0, 1282298
Total [candidate] (9.413 s) : 0, 9413244
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.211 s 131.345 ms (12.2%)
Agent iast 1.202 s 122.396 ms (11.3%)
Agent profiling 1.276 s 195.99 ms (18.1%)
Total tracing 9.168 s -
Total appsec 9.31 s 142.224 ms (1.6%)
Total iast 9.313 s 145.429 ms (1.6%)
Total profiling 9.382 s 214.17 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent appsec 1.204 s 121.42 ms (11.2%)
Agent iast 1.206 s 123.687 ms (11.4%)
Agent profiling 1.282 s 200.056 ms (18.5%)
Total tracing 9.205 s -
Total appsec 9.286 s 81.063 ms (0.9%)
Total iast 9.317 s 112.274 ms (1.2%)
Total profiling 9.413 s 208.413 ms (2.3%) 
gantt
    title petclinic - break down per module: candidate=1.32.0-SNAPSHOT~79ae3c32d9, baseline=1.32.0-SNAPSHOT~a786410129

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.269 ms) : 0, 696269
BytebuddyAgent [candidate] (697.141 ms) : 0, 697141
GlobalTracer [baseline] (291.765 ms) : 0, 291765
GlobalTracer [candidate] (293.065 ms) : 0, 293065
AppSec [baseline] (49.162 ms) : 0, 49162
AppSec [candidate] (49.282 ms) : 0, 49282
Remote Config [baseline] (739.048 µs) : 0, 739
Remote Config [candidate] (730.948 µs) : 0, 731
Telemetry [baseline] (7.649 ms) : 0, 7649
Telemetry [candidate] (7.679 ms) : 0, 7679
section appsec
BytebuddyAgent [baseline] (702.838 ms) : 0, 702838
BytebuddyAgent [candidate] (697.548 ms) : 0, 697548
GlobalTracer [baseline] (294.6 ms) : 0, 294600
GlobalTracer [candidate] (292.718 ms) : 0, 292718
AppSec [baseline] (153.498 ms) : 0, 153498
AppSec [candidate] (153.589 ms) : 0, 153589
Remote Config [baseline] (614.896 µs) : 0, 615
Remote Config [candidate] (609.164 µs) : 0, 609
Telemetry [baseline] (6.961 ms) : 0, 6961
Telemetry [candidate] (6.941 ms) : 0, 6941
IAST [baseline] (17.99 ms) : 0, 17990
IAST [candidate] (17.927 ms) : 0, 17927
section iast
BytebuddyAgent [baseline] (799.338 ms) : 0, 799338
BytebuddyAgent [candidate] (801.61 ms) : 0, 801610
GlobalTracer [baseline] (287.974 ms) : 0, 287974
GlobalTracer [candidate] (288.909 ms) : 0, 288909
AppSec [baseline] (49.083 ms) : 0, 49083
AppSec [candidate] (47.72 ms) : 0, 47720
Remote Config [baseline] (599.374 µs) : 0, 599
Remote Config [candidate] (608.395 µs) : 0, 608
Telemetry [baseline] (6.595 ms) : 0, 6595
Telemetry [candidate] (6.582 ms) : 0, 6582
IAST [baseline] (24.425 ms) : 0, 24425
IAST [candidate] (26.316 ms) : 0, 26316
section profiling
BytebuddyAgent [baseline] (690.971 ms) : 0, 690971
BytebuddyAgent [candidate] (693.722 ms) : 0, 693722
GlobalTracer [baseline] (376.315 ms) : 0, 376315
GlobalTracer [candidate] (378.52 ms) : 0, 378520
AppSec [baseline] (49.694 ms) : 0, 49694
AppSec [candidate] (49.778 ms) : 0, 49778
Remote Config [baseline] (762.406 µs) : 0, 762
Remote Config [candidate] (719.513 µs) : 0, 720
Telemetry [baseline] (7.475 ms) : 0, 7475
Telemetry [candidate] (7.536 ms) : 0, 7536
ProfilingAgent [baseline] (94.392 ms) : 0, 94392
ProfilingAgent [candidate] (95.431 ms) : 0, 95431
Profiling [baseline] (94.415 ms) : 0, 94415
Profiling [candidate] (95.455 ms) : 0, 95455
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.32.0-SNAPSHOT~79ae3c32d9, baseline=1.32.0-SNAPSHOT~a786410129

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080471
Total [baseline] (8.6 s) : 0, 8600167
Agent [candidate] (1.089 s) : 0, 1089432
Total [candidate] (8.593 s) : 0, 8592881
section iast
Agent [baseline] (1.202 s) : 0, 1202339
Total [baseline] (9.064 s) : 0, 9063638
Agent [candidate] (1.219 s) : 0, 1219064
Total [candidate] (9.104 s) : 0, 9104069
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.213 s) : 0, 1212834
Total [baseline] (9.043 s) : 0, 9042545
Agent [candidate] (1.215 s) : 0, 1214930
Total [candidate] (9.03 s) : 0, 9029519
section iast_TELEMETRY_OFF
Agent [baseline] (1.199 s) : 0, 1198836
Total [baseline] (9.044 s) : 0, 9043533
Agent [candidate] (1.2 s) : 0, 1199575
Total [candidate] (9.037 s) : 0, 9036581
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.202 s 121.868 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.213 s 132.363 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.199 s 118.365 ms (11.0%)
Total tracing 8.6 s -
Total iast 9.064 s 463.471 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.043 s 442.379 ms (5.1%)
Total iast_TELEMETRY_OFF 9.044 s 443.366 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.089 s -
Agent iast 1.219 s 129.632 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.215 s 125.497 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.2 s 110.143 ms (10.1%)
Total tracing 8.593 s -
Total iast 9.104 s 511.188 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.03 s 436.639 ms (5.1%)
Total iast_TELEMETRY_OFF 9.037 s 443.7 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.32.0-SNAPSHOT~79ae3c32d9, baseline=1.32.0-SNAPSHOT~a786410129

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.534 ms) : 0, 696534
BytebuddyAgent [candidate] (703.161 ms) : 0, 703161
GlobalTracer [baseline] (292.099 ms) : 0, 292099
GlobalTracer [candidate] (293.892 ms) : 0, 293892
AppSec [baseline] (49.126 ms) : 0, 49126
AppSec [candidate] (49.427 ms) : 0, 49427
Remote Config [baseline] (731.214 µs) : 0, 731
Remote Config [candidate] (730.193 µs) : 0, 730
Telemetry [baseline] (7.699 ms) : 0, 7699
Telemetry [candidate] (7.681 ms) : 0, 7681
section iast
BytebuddyAgent [baseline] (799.387 ms) : 0, 799387
BytebuddyAgent [candidate] (811.875 ms) : 0, 811875
GlobalTracer [baseline] (288.017 ms) : 0, 288017
GlobalTracer [candidate] (290.929 ms) : 0, 290929
AppSec [baseline] (49.724 ms) : 0, 49724
AppSec [candidate] (51.321 ms) : 0, 51321
IAST [baseline] (23.669 ms) : 0, 23669
IAST [candidate] (22.77 ms) : 0, 22770
Remote Config [baseline] (612.277 µs) : 0, 612
Remote Config [candidate] (624.229 µs) : 0, 624
Telemetry [baseline] (6.569 ms) : 0, 6569
Telemetry [candidate] (6.653 ms) : 0, 6653
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (806.323 ms) : 0, 806323
BytebuddyAgent [candidate] (807.903 ms) : 0, 807903
GlobalTracer [baseline] (290.891 ms) : 0, 290891
GlobalTracer [candidate] (291.667 ms) : 0, 291667
AppSec [baseline] (49.579 ms) : 0, 49579
AppSec [candidate] (50.685 ms) : 0, 50685
IAST [baseline] (24.091 ms) : 0, 24091
IAST [candidate] (22.062 ms) : 0, 22062
Remote Config [baseline] (606.261 µs) : 0, 606
Remote Config [candidate] (604.185 µs) : 0, 604
Telemetry [baseline] (6.656 ms) : 0, 6656
Telemetry [candidate] (7.271 ms) : 0, 7271
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (794.745 ms) : 0, 794745
BytebuddyAgent [candidate] (793.53 ms) : 0, 793530
GlobalTracer [baseline] (289.704 ms) : 0, 289704
GlobalTracer [candidate] (290.192 ms) : 0, 290192
AppSec [baseline] (51.324 ms) : 0, 51324
AppSec [candidate] (49.473 ms) : 0, 49473
IAST [baseline] (20.013 ms) : 0, 20013
IAST [candidate] (24.104 ms) : 0, 24104
Remote Config [baseline] (581.495 µs) : 0, 581
Remote Config [candidate] (578.299 µs) : 0, 578
Telemetry [baseline] (8.028 ms) : 0, 8028
Telemetry [candidate] (7.278 ms) : 0, 7278

Load

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~79ae3c32d9, baseline=1.32.0-SNAPSHOT~a786410129
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.354 ms) : 1335, 1373
.   : milestone, 1354,
appsec (1.76 ms) : 1736, 1783
.   : milestone, 1760,
iast (1.542 ms) : 1519, 1566
.   : milestone, 1542,
profiling (1.541 ms) : 1517, 1565
.   : milestone, 1541,
tracing (1.502 ms) : 1479, 1526
.   : milestone, 1502,
section candidate
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.746 ms) : 1722, 1770
.   : milestone, 1746,
iast (1.515 ms) : 1491, 1539
.   : milestone, 1515,
profiling (1.524 ms) : 1501, 1547
.   : milestone, 1524,
tracing (1.491 ms) : 1468, 1514
.   : milestone, 1491,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.373 ms] -
appsec 1.76 ms [1.736 ms, 1.783 ms] 405.634 µs (30.0%)
iast 1.542 ms [1.519 ms, 1.566 ms] 187.9 µs (13.9%)
profiling 1.541 ms [1.517 ms, 1.565 ms] 186.967 µs (13.8%)
tracing 1.502 ms [1.479 ms, 1.526 ms] 148.007 µs (10.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.362 ms] -
appsec 1.746 ms [1.722 ms, 1.77 ms] 403.467 µs (30.0%)
iast 1.515 ms [1.491 ms, 1.539 ms] 172.016 µs (12.8%)
profiling 1.524 ms [1.501 ms, 1.547 ms] 181.149 µs (13.5%)
tracing 1.491 ms [1.468 ms, 1.514 ms] 148.001 µs (11.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~79ae3c32d9, baseline=1.32.0-SNAPSHOT~a786410129
    dateFormat X
    axisFormat %s
section baseline
no_agent (361.614 µs) : 341, 382
.   : milestone, 362,
iast (466.199 µs) : 446, 486
.   : milestone, 466,
iast_FULL (536.965 µs) : 516, 558
.   : milestone, 537,
iast_GLOBAL (489.998 µs) : 469, 511
.   : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (476.651 µs) : 456, 498
.   : milestone, 477,
iast_INACTIVE (448.128 µs) : 428, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (466.447 µs) : 446, 487
.   : milestone, 466,
tracing (445.841 µs) : 426, 466
.   : milestone, 446,
section candidate
no_agent (372.3 µs) : 352, 393
.   : milestone, 372,
iast (476.21 µs) : 456, 497
.   : milestone, 476,
iast_FULL (535.889 µs) : 515, 556
.   : milestone, 536,
iast_GLOBAL (494.732 µs) : 474, 515
.   : milestone, 495,
iast_HARDCODED_SECRET_DISABLED (475.195 µs) : 455, 496
.   : milestone, 475,
iast_INACTIVE (453.215 µs) : 432, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (472.818 µs) : 451, 494
.   : milestone, 473,
tracing (443.225 µs) : 423, 464
.   : milestone, 443,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 361.614 µs [341.232 µs, 381.997 µs] -
iast 466.199 µs [445.903 µs, 486.494 µs] 104.584 µs (28.9%)
iast_FULL 536.965 µs [516.387 µs, 557.543 µs] 175.35 µs (48.5%)
iast_GLOBAL 489.998 µs [469.137 µs, 510.858 µs] 128.383 µs (35.5%)
iast_HARDCODED_SECRET_DISABLED 476.651 µs [455.762 µs, 497.539 µs] 115.036 µs (31.8%)
iast_INACTIVE 448.128 µs [427.68 µs, 468.577 µs] 86.514 µs (23.9%)
iast_TELEMETRY_OFF 466.447 µs [446.143 µs, 486.75 µs] 104.832 µs (29.0%)
tracing 445.841 µs [425.727 µs, 465.956 µs] 84.227 µs (23.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.3 µs [351.688 µs, 392.912 µs] -
iast 476.21 µs [455.519 µs, 496.901 µs] 103.91 µs (27.9%)
iast_FULL 535.889 µs [515.34 µs, 556.439 µs] 163.59 µs (43.9%)
iast_GLOBAL 494.732 µs [473.976 µs, 515.487 µs] 122.432 µs (32.9%)
iast_HARDCODED_SECRET_DISABLED 475.195 µs [454.5 µs, 495.89 µs] 102.895 µs (27.6%)
iast_INACTIVE 453.215 µs [432.21 µs, 474.22 µs] 80.916 µs (21.7%)
iast_TELEMETRY_OFF 472.818 µs [451.427 µs, 494.208 µs] 100.518 µs (27.0%)
tracing 443.225 µs [422.808 µs, 463.642 µs] 70.925 µs (19.1%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@asdftamir