-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Support Snapshot]log bad payloads - based on 1.20.1 #6535
Draft
nayeem-kamal
wants to merge
1
commit into
release/v1.20.x
Choose a base branch
from
nayeem-kamal/log-bad-payloads-backport
base: release/v1.20.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Support Snapshot]log bad payloads - based on 1.20.1 #6535
nayeem-kamal
wants to merge
1
commit into
release/v1.20.x
from
nayeem-kamal/log-bad-payloads-backport
+32
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 42 performance improvements and 2 performance regressions! Performance is the same for 13 metrics, 5 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.21.0-SNAPSHOT~fd2aa81c5c, baseline=1.29.0-SNAPSHOT~9430bbc87c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060920
Total [baseline] (9.398 s) : 0, 9398249
Agent [candidate] (990.909 ms) : 0, 990909
Total [candidate] (9.242 s) : 0, 9242403
section appsec
Agent [baseline] (1.15 s) : 0, 1150122
Total [baseline] (9.514 s) : 0, 9513633
Agent [candidate] (1.075 s) : 0, 1075462
Total [candidate] (9.352 s) : 0, 9352312
section iast
Agent [baseline] (1.171 s) : 0, 1171153
Total [baseline] (9.563 s) : 0, 9562722
Agent [candidate] (1.109 s) : 0, 1108782
Total [candidate] (9.531 s) : 0, 9530785
section profiling
Agent [baseline] (1.283 s) : 0, 1283199
Total [baseline] (9.643 s) : 0, 9642640
Agent [candidate] (1.171 s) : 0, 1171295
Total [candidate] (9.55 s) : 0, 9549541
gantt
title petclinic - break down per module: candidate=1.21.0-SNAPSHOT~fd2aa81c5c, baseline=1.29.0-SNAPSHOT~9430bbc87c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.006 ms) : 0, 670006
BytebuddyAgent [candidate] (613.326 ms) : 0, 613326
GlobalTracer [baseline] (297.683 ms) : 0, 297683
GlobalTracer [candidate] (287.462 ms) : 0, 287462
AppSec [baseline] (50.819 ms) : 0, 50819
AppSec [candidate] (49.43 ms) : 0, 49430
Remote Config [baseline] (654.21 µs) : 0, 654
Remote Config [candidate] (673.873 µs) : 0, 674
Telemetry [baseline] (7.227 ms) : 0, 7227
Telemetry [candidate] (5.964 ms) : 0, 5964
section appsec
BytebuddyAgent [baseline] (664.867 ms) : 0, 664867
BytebuddyAgent [candidate] (614.057 ms) : 0, 614057
GlobalTracer [baseline] (295.764 ms) : 0, 295764
GlobalTracer [candidate] (287.056 ms) : 0, 287056
AppSec [baseline] (147.791 ms) : 0, 147791
AppSec [candidate] (133.696 ms) : 0, 133696
Remote Config [baseline] (645.142 µs) : 0, 645
Remote Config [candidate] (724.449 µs) : 0, 724
Telemetry [baseline] (6.892 ms) : 0, 6892
Telemetry [candidate] (5.725 ms) : 0, 5725
section iast
BytebuddyAgent [baseline] (771.473 ms) : 0, 771473
BytebuddyAgent [candidate] (730.622 ms) : 0, 730622
GlobalTracer [baseline] (284.748 ms) : 0, 284748
GlobalTracer [candidate] (274.805 ms) : 0, 274805
AppSec [baseline] (51.836 ms) : 0, 51836
AppSec [candidate] (47.33 ms) : 0, 47330
Remote Config [baseline] (599.411 µs) : 0, 599
Remote Config [candidate] (601.487 µs) : 0, 601
Telemetry [baseline] (8.889 ms) : 0, 8889
Telemetry [candidate] (5.952 ms) : 0, 5952
IAST [baseline] (19.56 ms) : 0, 19560
IAST [candidate] (14.74 ms) : 0, 14740
section profiling
ProfilingAgent [baseline] (124.348 ms) : 0, 124348
ProfilingAgent [candidate] (78.94 ms) : 0, 78940
BytebuddyAgent [baseline] (666.555 ms) : 0, 666555
BytebuddyAgent [candidate] (626.722 ms) : 0, 626722
GlobalTracer [baseline] (377.881 ms) : 0, 377881
GlobalTracer [candidate] (356.936 ms) : 0, 356936
AppSec [baseline] (51.388 ms) : 0, 51388
AppSec [candidate] (49.27 ms) : 0, 49270
Remote Config [baseline] (994.03 µs) : 0, 994
Remote Config [candidate] (651.716 µs) : 0, 652
Telemetry [baseline] (7.347 ms) : 0, 7347
Telemetry [candidate] (5.997 ms) : 0, 5997
Profiling [baseline] (124.372 ms) : 0, 124372
Profiling [candidate] (78.964 ms) : 0, 78964
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.21.0-SNAPSHOT~fd2aa81c5c, baseline=1.29.0-SNAPSHOT~9430bbc87c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052336
Total [baseline] (8.783 s) : 0, 8782650
Agent [candidate] (989.342 ms) : 0, 989342
Total [candidate] (8.626 s) : 0, 8626013
section appsec
Agent [baseline] (1.152 s) : 0, 1151952
Total [baseline] (8.85 s) : 0, 8850182
Agent [candidate] (1.075 s) : 0, 1074777
Total [candidate] (8.688 s) : 0, 8687788
section iast
Agent [baseline] (1.175 s) : 0, 1175079
Total [baseline] (9.285 s) : 0, 9285184
Agent [candidate] (1.096 s) : 0, 1095837
Total [candidate] (9.197 s) : 0, 9197456
section profiling
Agent [baseline] (1.284 s) : 0, 1283736
Total [baseline] (8.935 s) : 0, 8935049
Agent [candidate] (1.168 s) : 0, 1168011
Total [candidate] (8.843 s) : 0, 8842873
gantt
title insecure-bank - break down per module: candidate=1.21.0-SNAPSHOT~fd2aa81c5c, baseline=1.29.0-SNAPSHOT~9430bbc87c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.643 ms) : 0, 664643
BytebuddyAgent [candidate] (612.645 ms) : 0, 612645
GlobalTracer [baseline] (295.032 ms) : 0, 295032
GlobalTracer [candidate] (286.552 ms) : 0, 286552
AppSec [baseline] (50.667 ms) : 0, 50667
AppSec [candidate] (49.368 ms) : 0, 49368
Remote Config [baseline] (660.215 µs) : 0, 660
Remote Config [candidate] (671.692 µs) : 0, 672
Telemetry [baseline] (7.184 ms) : 0, 7184
Telemetry [candidate] (5.959 ms) : 0, 5959
section appsec
BytebuddyAgent [baseline] (665.957 ms) : 0, 665957
BytebuddyAgent [candidate] (613.323 ms) : 0, 613323
GlobalTracer [baseline] (295.846 ms) : 0, 295846
GlobalTracer [candidate] (287.044 ms) : 0, 287044
AppSec [baseline] (148.332 ms) : 0, 148332
AppSec [candidate] (133.83 ms) : 0, 133830
Remote Config [baseline] (643.85 µs) : 0, 644
Remote Config [candidate] (726.021 µs) : 0, 726
Telemetry [baseline] (6.9 ms) : 0, 6900
Telemetry [candidate] (5.743 ms) : 0, 5743
section iast
BytebuddyAgent [baseline] (774.87 ms) : 0, 774870
BytebuddyAgent [candidate] (722.315 ms) : 0, 722315
GlobalTracer [baseline] (285.71 ms) : 0, 285710
GlobalTracer [candidate] (271.621 ms) : 0, 271621
AppSec [baseline] (53.871 ms) : 0, 53871
AppSec [candidate] (46.609 ms) : 0, 46609
Remote Config [baseline] (596.071 µs) : 0, 596
Remote Config [candidate] (600.507 µs) : 0, 601
Telemetry [baseline] (7.311 ms) : 0, 7311
Telemetry [candidate] (5.891 ms) : 0, 5891
IAST [baseline] (18.455 ms) : 0, 18455
IAST [candidate] (14.502 ms) : 0, 14502
section profiling
ProfilingAgent [baseline] (124.531 ms) : 0, 124531
ProfilingAgent [candidate] (78.354 ms) : 0, 78354
BytebuddyAgent [baseline] (666.963 ms) : 0, 666963
BytebuddyAgent [candidate] (626.253 ms) : 0, 626253
GlobalTracer [baseline] (378.065 ms) : 0, 378065
GlobalTracer [candidate] (354.993 ms) : 0, 354993
AppSec [baseline] (51.203 ms) : 0, 51203
AppSec [candidate] (49.095 ms) : 0, 49095
Remote Config [baseline] (983.966 µs) : 0, 984
Remote Config [candidate] (645.542 µs) : 0, 646
Telemetry [baseline] (7.314 ms) : 0, 7314
Telemetry [candidate] (5.939 ms) : 0, 5939
Profiling [baseline] (124.557 ms) : 0, 124557
Profiling [candidate] (78.379 ms) : 0, 78379
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 14 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.21.0-SNAPSHOT~fd2aa81c5c, baseline=1.29.0-SNAPSHOT~9430bbc87c
dateFormat X
axisFormat %s
section baseline
no_agent (1.349 ms) : 1330, 1368
. : milestone, 1349,
appsec (1.797 ms) : 1771, 1822
. : milestone, 1797,
iast (1.549 ms) : 1525, 1574
. : milestone, 1549,
profiling (1.583 ms) : 1556, 1609
. : milestone, 1583,
tracing (1.486 ms) : 1462, 1511
. : milestone, 1486,
section candidate
no_agent (1.345 ms) : 1326, 1364
. : milestone, 1345,
appsec (1.747 ms) : 1722, 1772
. : milestone, 1747,
iast (1.549 ms) : 1524, 1574
. : milestone, 1549,
profiling (1.544 ms) : 1517, 1571
. : milestone, 1544,
tracing (1.519 ms) : 1494, 1544
. : milestone, 1519,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.21.0-SNAPSHOT~fd2aa81c5c, baseline=1.29.0-SNAPSHOT~9430bbc87c
dateFormat X
axisFormat %s
section baseline
no_agent (363.871 µs) : 344, 384
. : milestone, 364,
appsec (731.66 µs) : 711, 753
. : milestone, 732,
iast (484.365 µs) : 464, 505
. : milestone, 484,
iast_FULL (546.879 µs) : 526, 567
. : milestone, 547,
iast_INACTIVE (450.038 µs) : 429, 471
. : milestone, 450,
profiling (452.393 µs) : 431, 473
. : milestone, 452,
tracing (446.377 µs) : 426, 467
. : milestone, 446,
section candidate
no_agent (363.472 µs) : 344, 383
. : milestone, 363,
appsec (676.409 µs) : 656, 697
. : milestone, 676,
iast (466.15 µs) : 446, 486
. : milestone, 466,
iast_FULL (537.369 µs) : 517, 558
. : milestone, 537,
iast_INACTIVE (444.482 µs) : 424, 465
. : milestone, 444,
profiling (449.143 µs) : 428, 470
. : milestone, 449,
tracing (446.084 µs) : 426, 466
. : milestone, 446,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Jira ticket: [PROJ-IDENT]