Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump codenarc to 3.4.0 #6505

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

bump codenarc to 3.4.0 #6505

wants to merge 6 commits into from

Conversation

am312
Copy link
Contributor

@am312 am312 commented Jan 16, 2024

What Does This Do

Updates CodeNarc from 2.2.0 -> 3.4.0.

@am312 am312 added the tag: no release notes Changes to exclude from release notes label Jan 16, 2024
@am312 am312 marked this pull request as ready for review January 16, 2024 20:07
@am312 am312 requested a review from a team as a code owner January 16, 2024 20:07
@am312 am312 requested review from mcculls and ygree January 16, 2024 20:07
@am312 am312 marked this pull request as draft January 16, 2024 20:39
@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2024 •
edited

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrew.munn/codenarc-bump
git_commit_date 1706026439 1706030803
git_commit_sha fda2568 d9434b3
release_version 1.29.0-SNAPSHOT~fda2568b4a 1.28.0-SNAPSHOT~d9434b345b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1706033442 1706033442
ci_job_id 416333671 416333671
ci_pipeline_id 27012342 27012342
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.28.0-SNAPSHOT~d9434b345b, baseline=1.29.0-SNAPSHOT~fda2568b4a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052103
Total [baseline] (9.316 s) : 0, 9316440
Agent [candidate] (1.056 s) : 0, 1056389
Total [candidate] (9.337 s) : 0, 9336692
section appsec
Agent [baseline] (1.158 s) : 0, 1157650
Total [baseline] (9.441 s) : 0, 9441396
Agent [candidate] (1.153 s) : 0, 1152959
Total [candidate] (9.439 s) : 0, 9439457
section iast
Agent [baseline] (1.177 s) : 0, 1177216
Total [baseline] (9.64 s) : 0, 9640065
Agent [candidate] (1.19 s) : 0, 1189556
Total [candidate] (9.714 s) : 0, 9713560
section profiling
Agent [baseline] (1.284 s) : 0, 1284193
Total [baseline] (9.662 s) : 0, 9661750
Agent [candidate] (1.283 s) : 0, 1283023
Total [candidate] (9.568 s) : 0, 9567779
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent appsec 1.158 s 105.547 ms (10.0%)
Agent iast 1.177 s 125.113 ms (11.9%)
Agent profiling 1.284 s 232.09 ms (22.1%)
Total tracing 9.316 s -
Total appsec 9.441 s 124.956 ms (1.3%)
Total iast 9.64 s 323.624 ms (3.5%)
Total profiling 9.662 s 345.309 ms (3.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.153 s 96.569 ms (9.1%)
Agent iast 1.19 s 133.166 ms (12.6%)
Agent profiling 1.283 s 226.634 ms (21.5%)
Total tracing 9.337 s -
Total appsec 9.439 s 102.765 ms (1.1%)
Total iast 9.714 s 376.868 ms (4.0%)
Total profiling 9.568 s 231.086 ms (2.5%) 
gantt
    title petclinic - break down per module: candidate=1.28.0-SNAPSHOT~d9434b345b, baseline=1.29.0-SNAPSHOT~fda2568b4a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.559 ms) : 0, 664559
BytebuddyAgent [candidate] (667.065 ms) : 0, 667065
GlobalTracer [baseline] (294.694 ms) : 0, 294694
GlobalTracer [candidate] (296.523 ms) : 0, 296523
AppSec [baseline] (50.704 ms) : 0, 50704
AppSec [candidate] (50.713 ms) : 0, 50713
Remote Config [baseline] (660.168 µs) : 0, 660
Remote Config [candidate] (652.792 µs) : 0, 653
Telemetry [baseline] (7.213 ms) : 0, 7213
Telemetry [candidate] (7.204 ms) : 0, 7204
section appsec
BytebuddyAgent [baseline] (669.578 ms) : 0, 669578
BytebuddyAgent [candidate] (666.409 ms) : 0, 666409
GlobalTracer [baseline] (296.927 ms) : 0, 296927
GlobalTracer [candidate] (296.23 ms) : 0, 296230
AppSec [baseline] (148.993 ms) : 0, 148993
AppSec [candidate] (148.561 ms) : 0, 148561
Remote Config [baseline] (651.341 µs) : 0, 651
Remote Config [candidate] (644.626 µs) : 0, 645
Telemetry [baseline] (6.947 ms) : 0, 6947
Telemetry [candidate] (6.86 ms) : 0, 6860
section iast
BytebuddyAgent [baseline] (776.139 ms) : 0, 776139
BytebuddyAgent [candidate] (782.047 ms) : 0, 782047
GlobalTracer [baseline] (286.563 ms) : 0, 286563
GlobalTracer [candidate] (290.796 ms) : 0, 290796
AppSec [baseline] (52.737 ms) : 0, 52737
AppSec [candidate] (54.108 ms) : 0, 54108
IAST [baseline] (19.54 ms) : 0, 19540
IAST [candidate] (19.993 ms) : 0, 19993
Remote Config [baseline] (585.403 µs) : 0, 585
Remote Config [candidate] (617.955 µs) : 0, 618
Telemetry [baseline] (7.27 ms) : 0, 7270
Telemetry [candidate] (7.468 ms) : 0, 7468
section profiling
BytebuddyAgent [baseline] (666.913 ms) : 0, 666913
BytebuddyAgent [candidate] (664.479 ms) : 0, 664479
GlobalTracer [baseline] (378.101 ms) : 0, 378101
GlobalTracer [candidate] (377.694 ms) : 0, 377694
AppSec [baseline] (51.237 ms) : 0, 51237
AppSec [candidate] (50.978 ms) : 0, 50978
Remote Config [baseline] (1.009 ms) : 0, 1009
Remote Config [candidate] (978.335 µs) : 0, 978
Telemetry [baseline] (7.354 ms) : 0, 7354
Telemetry [candidate] (7.346 ms) : 0, 7346
ProfilingAgent [baseline] (124.766 ms) : 0, 124766
ProfilingAgent [candidate] (127.165 ms) : 0, 127165
Profiling [baseline] (124.793 ms) : 0, 124793
Profiling [candidate] (127.19 ms) : 0, 127190
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.28.0-SNAPSHOT~d9434b345b, baseline=1.29.0-SNAPSHOT~fda2568b4a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049586
Total [baseline] (8.74 s) : 0, 8740213
Agent [candidate] (1.054 s) : 0, 1054352
Total [candidate] (8.74 s) : 0, 8739571
section iast
Agent [baseline] (1.173 s) : 0, 1172911
Total [baseline] (9.245 s) : 0, 9244955
Agent [candidate] (1.176 s) : 0, 1176134
Total [candidate] (9.251 s) : 0, 9251421
section iast_TELEMETRY_OFF
Agent [baseline] (1.181 s) : 0, 1180964
Total [baseline] (9.268 s) : 0, 9267897
Agent [candidate] (1.177 s) : 0, 1177050
Total [candidate] (9.27 s) : 0, 9270398
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent iast 1.173 s 123.326 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.181 s 131.379 ms (12.5%)
Total tracing 8.74 s -
Total iast 9.245 s 504.742 ms (5.8%)
Total iast_TELEMETRY_OFF 9.268 s 527.684 ms (6.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.176 s 121.782 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.177 s 122.699 ms (11.6%)
Total tracing 8.74 s -
Total iast 9.251 s 511.85 ms (5.9%)
Total iast_TELEMETRY_OFF 9.27 s 530.827 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.28.0-SNAPSHOT~d9434b345b, baseline=1.29.0-SNAPSHOT~fda2568b4a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (662.908 ms) : 0, 662908
BytebuddyAgent [candidate] (666.062 ms) : 0, 666062
GlobalTracer [baseline] (294.371 ms) : 0, 294371
GlobalTracer [candidate] (295.483 ms) : 0, 295483
AppSec [baseline] (50.427 ms) : 0, 50427
AppSec [candidate] (50.705 ms) : 0, 50705
Remote Config [baseline] (657.248 µs) : 0, 657
Remote Config [candidate] (657.91 µs) : 0, 658
Telemetry [baseline] (7.161 ms) : 0, 7161
Telemetry [candidate] (7.211 ms) : 0, 7211
section iast
BytebuddyAgent [baseline] (772.886 ms) : 0, 772886
BytebuddyAgent [candidate] (774.534 ms) : 0, 774534
GlobalTracer [baseline] (285.015 ms) : 0, 285015
GlobalTracer [candidate] (286.214 ms) : 0, 286214
AppSec [baseline] (52.753 ms) : 0, 52753
AppSec [candidate] (54.389 ms) : 0, 54389
IAST [baseline] (19.368 ms) : 0, 19368
IAST [candidate] (18.786 ms) : 0, 18786
Remote Config [baseline] (592.178 µs) : 0, 592
Remote Config [candidate] (590.338 µs) : 0, 590
Telemetry [baseline] (8.108 ms) : 0, 8108
Telemetry [candidate] (7.333 ms) : 0, 7333
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (778.17 ms) : 0, 778170
BytebuddyAgent [candidate] (774.217 ms) : 0, 774217
GlobalTracer [baseline] (288.015 ms) : 0, 288015
GlobalTracer [candidate] (288.418 ms) : 0, 288418
AppSec [baseline] (53.992 ms) : 0, 53992
AppSec [candidate] (51.907 ms) : 0, 51907
IAST [baseline] (18.859 ms) : 0, 18859
IAST [candidate] (20.989 ms) : 0, 20989
Remote Config [baseline] (613.918 µs) : 0, 614
Remote Config [candidate] (585.147 µs) : 0, 585
Telemetry [baseline] (6.402 ms) : 0, 6402
Telemetry [candidate] (6.446 ms) : 0, 6446

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-01-23T17:50:03 2024-01-23T18:06:29
git_branch master andrew.munn/codenarc-bump
git_commit_date 1706026439 1706030803
git_commit_sha fda2568 d9434b3
release_version 1.29.0-SNAPSHOT~fda2568b4a 1.28.0-SNAPSHOT~d9434b345b
start_time 2024-01-23T17:49:49 2024-01-23T18:06:15
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1706033442 1706033442
ci_job_id 416333671 416333671
ci_pipeline_id 27012342 27012342
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 14 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.28.0-SNAPSHOT~d9434b345b, baseline=1.29.0-SNAPSHOT~fda2568b4a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.345 ms) : 1326, 1364
.   : milestone, 1345,
appsec (1.775 ms) : 1749, 1801
.   : milestone, 1775,
iast (1.517 ms) : 1492, 1542
.   : milestone, 1517,
profiling (1.5 ms) : 1475, 1525
.   : milestone, 1500,
tracing (1.504 ms) : 1479, 1529
.   : milestone, 1504,
section candidate
no_agent (1.371 ms) : 1352, 1390
.   : milestone, 1371,
appsec (1.764 ms) : 1738, 1789
.   : milestone, 1764,
iast (1.523 ms) : 1499, 1547
.   : milestone, 1523,
profiling (1.512 ms) : 1486, 1537
.   : milestone, 1512,
tracing (1.487 ms) : 1463, 1512
.   : milestone, 1487,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.326 ms, 1.364 ms] -
appsec 1.775 ms [1.749 ms, 1.801 ms] 430.208 µs (32.0%)
iast 1.517 ms [1.492 ms, 1.542 ms] 172.256 µs (12.8%)
profiling 1.5 ms [1.475 ms, 1.525 ms] 154.951 µs (11.5%)
tracing 1.504 ms [1.479 ms, 1.529 ms] 159.051 µs (11.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.371 ms [1.352 ms, 1.39 ms] -
appsec 1.764 ms [1.738 ms, 1.789 ms] 393.128 µs (28.7%)
iast 1.523 ms [1.499 ms, 1.547 ms] 152.307 µs (11.1%)
profiling 1.512 ms [1.486 ms, 1.537 ms] 140.995 µs (10.3%)
tracing 1.487 ms [1.463 ms, 1.512 ms] 116.637 µs (8.5%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.28.0-SNAPSHOT~d9434b345b, baseline=1.29.0-SNAPSHOT~fda2568b4a
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.523 µs) : 347, 386
.   : milestone, 367,
iast (473.873 µs) : 453, 495
.   : milestone, 474,
iast_FULL (543.433 µs) : 523, 564
.   : milestone, 543,
iast_INACTIVE (440.393 µs) : 420, 461
.   : milestone, 440,
iast_TELEMETRY_OFF (464.874 µs) : 444, 486
.   : milestone, 465,
tracing (439.619 µs) : 418, 461
.   : milestone, 440,
section candidate
no_agent (359.978 µs) : 340, 380
.   : milestone, 360,
iast (478.923 µs) : 458, 500
.   : milestone, 479,
iast_FULL (544.516 µs) : 524, 565
.   : milestone, 545,
iast_INACTIVE (447.311 µs) : 427, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (467.621 µs) : 446, 489
.   : milestone, 468,
tracing (439.418 µs) : 418, 461
.   : milestone, 439,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.523 µs [346.713 µs, 386.333 µs] -
iast 473.873 µs [453.065 µs, 494.68 µs] 107.35 µs (29.3%)
iast_FULL 543.433 µs [523.053 µs, 563.812 µs] 176.909 µs (48.3%)
iast_INACTIVE 440.393 µs [420.017 µs, 460.77 µs] 73.87 µs (20.2%)
iast_TELEMETRY_OFF 464.874 µs [444.111 µs, 485.637 µs] 98.35 µs (26.8%)
tracing 439.619 µs [417.906 µs, 461.331 µs] 73.096 µs (19.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 359.978 µs [340.215 µs, 379.741 µs] -
iast 478.923 µs [458.031 µs, 499.815 µs] 118.945 µs (33.0%)
iast_FULL 544.516 µs [524.086 µs, 564.947 µs] 184.538 µs (51.3%)
iast_INACTIVE 447.311 µs [426.584 µs, 468.038 µs] 87.333 µs (24.3%)
iast_TELEMETRY_OFF 467.621 µs [446.384 µs, 488.858 µs] 107.643 µs (29.9%)
tracing 439.418 µs [418.087 µs, 460.749 µs] 79.441 µs (22.1%)

@smola smola added the comp: tooling Build & Tooling label Jan 17, 2024
@am312 am312 requested review from amarziali and removed request for a team, mcculls and ygree January 23, 2024 11:54
amarziali
amarziali approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks for having handled the cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

Assignees
No one assigned
Labels
comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@am312 @amarziali @smola