-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Report host information in telemetry #118
Conversation
- Collect informations on the Operating System and the CPU architecture - Report those informations in telemetry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment, LGTM
src/datadog/tracer_telemetry.h
Outdated
@@ -48,6 +49,7 @@ class TracerTelemetry { | |||
bool debug_ = false; | |||
Clock clock_; | |||
std::shared_ptr<Logger> logger_; | |||
HostInfo host_info_; | |||
TracerSignature tracer_signature_; | |||
std::string hostname_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to remove hostname_
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Thank you.
EDIT: fixed in 316ebbb
- Set debug header only if debug is enabled - Keep in memory uname result
Description
The telemetry implementation was missing some host information. This PR adds those.
Content: