Add Dynasty wrapper #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A wrapper for the Dynesty nested sampler code. Dynesty in general can be found here: https://dynesty.readthedocs.io/en/stable/
Add files via upload
|
Three questions:
|
|
I sent an invite.
Hopefully the correct one ***@***.*** ***@***.***> 😊
|
|
Great! It worked. Still the questions about |
|
In the new class I’m currently writing, I have removed this,
unless specifically asked by the user.
�
Actually, just change whatever.
I’ll sync with the new changes once we are clear on what is required.
�
As it is now, I don’t think this class is so useful.
�
…-- Ira
�
From: Bob Stienen ***@***.***>
Sent: Tuesday, May 24, 2022 2:41 PM
To: DarkMachines/high-dimensional-sampling ***@***.***>
Cc: Ira Wolfson ***@***.***>; Mention ***@***.***>
Subject: Re: [DarkMachines/high-dimensional-sampling] Add Dynasty wrapper (PR #68)
�
Great! It worked. Still the questions about rstate and _rstate, though. If there is a good reason for it, we'll leave it like this, but if not I think I'd prefer to not fix the seed (as this might bias results in repeated experiments).
—
Reply to this email directly, view it on GitHub <#68 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIDJO62EUOCBRWPPX2HTNYLVLTE6FANCNFSM5WY4WB2A> .
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
I'm a bit hesitant in merging code into the framework that is not useful (otherwise the codebase becomes really messy really quickly). I'll leave the pull request open for now, so that you can still make changes to your code. Just for your information: I've moved it to the folder |
|
OK.
I’ll also make efforts to clean up the code before submitting it (in the future).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.