Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate Issue with Tests #2029

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Crisfole
Copy link

There's some level of setup I'm missing to be able to run the tests (futzing around with that right now). But I think this documents my theory correctly so I can find out which of these options this is:

  1. a misunderstanding to be corrected with documentation
  2. a feature request
  3. a bug

I'm not clear on what the expected behavior is for "simple" records. I'd expect the parameter names to get matched up the same way "normal" records do...

@Crisfole
Copy link
Author

I get 675 failures when trying to run this because Kerberos is not setup. I'm not sure how to run just my new specs as dotnet test --filter Name~SimpleRecord says it can't find any specs like it...I'm happy to try something else.

@mgravell
Copy link
Member

mgravell commented Jan 20, 2024

Right; so I think the key topic here is:

  • simple records don't have default constructors
  • if there's no default constructor, there needs to be a constructor that matches the column order (names+types)
  • otherwise, read fails

Is this a correct restatement of what you're seeing? If so: the good news here is that I believe this is already addressed, but: over in Dapper.AOT; I'm trying hard to resist major functionality changes in vanilla Dapper, because touching the IL emit is a major pain point. I'm busy for a few days, but: I can check how these tests behave in AOT after that - or you could give it a whirl and let me know :)

@Crisfole
Copy link
Author

@mgravell I think this is the crux of it. Again, I can't run the tests locally for reasons I haven't figured out yet. Sounds like I could add AOT to my project and see if that resolves it. I can give it a whirl on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants