Escape id column name in Get, GetAsync #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2022 08:41
Get\GetAsync do not work correctly with SQL Server when the Id column is a reserved keyword (e.g. "Key") marked with the `ExplicitKeyAttribute`. Use the adapter specific column name escaping to resolve the issue.
get query caching uses connection type specific formatting so the cache needs to be appropriately scoped in cases of concurrent usage with different connection types. Also split out query for GetAll queries to distinguish those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get\GetAsync do not work correctly with SQL Server when the Id column is a reserved keyword (e.g. "Key") marked with the
ExplicitKeyAttribute.Use the adapter specific column name escaping to resolve the issue.
resolves #150