Redis keys method should not trigger the each key recommendation

DamirSvrtan · Aug 20, 2023 · 304e16d · 304e16d
1 parent 0a23bff
commit 304e16d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/fasterer/scanners/method_call_scanner.rb b/lib/fasterer/scanners/method_call_scanner.rb
@@ -99,7 +99,9 @@ def check_each_offense
       when :reverse
         add_offense(:reverse_each_vs_reverse_each)
       when :keys
-        add_offense(:keys_each_vs_each_key)
+        if method_call.receiver.arguments.count.zero?
+          add_offense(:keys_each_vs_each_key)
+        end
       end
     end
 

diff --git a/spec/support/analyzer/15_keys_each_vs_each_key.rb b/spec/support/analyzer/15_keys_each_vs_each_key.rb
@@ -13,3 +13,7 @@
 end
 
 HASH.each_key(&:to_sym)
+
+@redis.keys('queue:*').each do |queue_name|
+  puts queue_name
+end