Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of implementation and use of the WriteCheck flag #192

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zbigniewj-se
Copy link

@zbigniewj-se zbigniewj-se commented Jan 4, 2024

Example of fix issue @#190

  • Example of passing an using the WarnCheck flag in code
  • Adding sEnum "NA"
  • Modification of the findPropItemforString method
  • Adding the getPropValue method
  • Sets default result value of property on N/A when WriteCheck flag is off
  • Sets default result value of property on False when WriteCheck flag is on
  • Example of updating property of resource.
  • Comment with an example of logic for updating the resource and checking whether the operation was successful, written in pseudocode.

Signed-off-by: Zbigniew Jedliński zbigniew.jedlinski@non.se.com

- Example of passing an using the WarnCheck flag in code
- Adding sEnum "NA"
- Modification of the findPropItemforString method
- Adding the getPropValue method
- Sets default result value of property on N/A when WriteCheck flag is off
- Sets default result value of property on False when WriteCheck flag is on
- Example of updating property of resource.
- Comment with an example of logic for updating the resource and checking whether the operation was successful, written in pseudocode.

Signed-off-by: Zbigniew Jedliński <zbigniew.jedlinski@non.se.com>
@mraineri
Copy link
Contributor

We've been discussing this change and I don't know if we can accept this as-is. The challenge we have with actively performing writes like this is it doesn't take into account if the value being written is something even allowed, or if the value would put the service into a bad state where it cannot continue testing. For example, I can imagine there being a profile requirement to make DHCP properties in EthernetInterface writable, but in doing so you could affect the interface being used for testing and lose connectivity with the service.

This area is definitely a gap in our testing that we'd like to close though; we just haven't figured out a good way of doing this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants