-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Github Actions CI #1008
Draft
joergbrech
wants to merge
16
commits into
master
Choose a base branch
from
1006-fix-ci
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update Github Actions CI #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joergbrech
force-pushed
the
1006-fix-ci
branch
6 times, most recently
from
May 16, 2024 10:24
f6e2dc9
to
5cb93fb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1008 +/- ##
===========================================
- Coverage 68.97% 42.67% -26.31%
===========================================
Files 299 526 +227
Lines 26499 43846 +17347
Branches 0 4722 +4722
===========================================
+ Hits 18277 18710 +433
- Misses 8222 25136 +16914
|
joergbrech
force-pushed
the
1006-fix-ci
branch
5 times, most recently
from
June 6, 2024 12:03
7aa9af1
to
56e1ebf
Compare
note that this requires an update of qt to avoid a depencency conflict by conda, which in turn requires an update of ninja
joergbrech
force-pushed
the
1006-fix-ci
branch
2 times, most recently
from
June 7, 2024 06:58
7957089
to
cc4acbc
Compare
joergbrech
force-pushed
the
1006-fix-ci
branch
2 times, most recently
from
June 7, 2024 08:01
be478a2
to
5f3156d
Compare
joergbrech
force-pushed
the
1006-fix-ci
branch
3 times, most recently
from
June 7, 2024 08:39
087f9b2
to
8f035df
Compare
joergbrech
force-pushed
the
1006-fix-ci
branch
2 times, most recently
from
June 10, 2024 09:25
24c7ef2
to
1d8aaeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1006
Updated action versions to update Node.js
The updated codecov action now needs a token to upload coverage reports. This has been added. At first sight it seems like the coverage report drops by 26.3%, presumably because only the unit test report is considered, and not the integration test report. Not sure why, need to investigate.
Needed to downgrade macos version, because the latest runner updated to the new arm architecture which is not supported by our build system yet (another To-Do for us)
Needed to update boost and gradle to build on macos.
The update of boost had a dependency conflict with qt, so I needed to update qt
In addition, I now got a weird ninja error on all platforms:
ninja: error: build.ninja:6801: multiple outputs aren't (yet?) supported by depslog; bring this up on the mailing list if it affects you
. So I updated ninjaThe newer Qt Version distributed with Anaconda was apparently build with gcc>9, which resulted in a GLIBC and GLIBCXX conflict on the Ubuntu 20.04 runner that only has g++ 9.3 installed. To save myself the trouble, I just removed ubuntu-20.04 from the build matrix. As of now, ubuntu-latest and ubuntu-22.04 are the same, but I suppose github will soon switch ubuntu-latest to ubuntu-24.04 and then we will be testing two different linux configs again.