Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_buffers.py::test_device was not actually checking the device of tensors #1685

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rhaps0dy
Copy link

Description

I added a failure in case of unknown type to test_buffers.py::test_device, and made it iterate correctly through Tensors and dicts.

Motivation and Context

In test_buffers.py::test_device, the assertions that the device be the correct one would not be executed for RolloutBuffer and DictRolloutBuffer: the type of value is RolloutBufferSamples and DictRolloutBufferSamples respectively and so falls to the else case.

I have not raised an issue on purpose, why bother for a tiny bugfix.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

elif isinstance(value, th.Tensor):
assert value.device.type == desired_device
else:
raise ValueError("unknown value type: ", type(value))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use TypeError instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants