New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Multiprocessing section of the Examples #1605
base: master
Are you sure you want to change the base?
Conversation
This page was not fully updated for the passage to gymnasium. Fixed the step() method that now returns a quintuplet and env.reset() that returns a tuple Made render_mode="rgb_array" for the training, but keep it "human" for visual evaluation Passed from SubprocVecEnv to DummyVecEnv as the former raises an Error
I guess that the goal of this code sample is to show how faster a VecEnv can be (in wall clock time), and as such, having a human rendering for training just negates any benefit. I agree that having switching from human rendering to rgb_array was not a bugfix technically (as it worked before), but I believe that the change is actually a "fix" in the intention of this section to showcase a speedup. |
Hello,
Can you elaborate on that? I think the only change that makes sense here is to switch to |
Regarding the error : this is what I get when I run the code
Config
I can revert the changes to |
hmm, might be related to mac os.
yes please, only change the |
This page was not fully updated for the passage to gymnasium.
Fixed the step() method that now returns a quintuplet and env.reset() that returns a tuple Made render_mode="rgb_array" for the training, but keep it "human" for visual evaluation Passed from SubprocVecEnv to DummyVecEnv as the former raises an Error
Description
Motivation and Context
It makes the code in the doc actually work
Types of changes
Checklist
No, it's too small
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)make doc
(required)Note: You can run most of the checks using
make commit-checks
.Note: we are using a maximum length of 127 characters per line