Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a next_observations field to RolloutBufferSamples (closes #1328) #1329

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

euanong
Copy link

@euanong euanong commented Feb 12, 2023

Description

  • Added next_observations field and has_next_observation mask to type_aliases.py
  • Extended generators in buffers.py to return next_observation and has_next_observation
  • Added a test in test_buffers.py

Motivation and Context

Closes #1328

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the SB3-Contrib repository (if necessary)
  • I have opened an associated PR on the RL-Zoo3 repository (if necessary)
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
    • n.b. there is an error C901 'BaseAlgorithm.load' is too complex (19) in a file I did not modify (stable_baselines3/common/base_class.py).
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)
    (I have been unable to run the last three commands due to Python dependency issues, but the PR delta is very small, so I hope this is fine...)
    Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

…utBufferSamples

- Added next_observations field and has_next_observation mask to type_aliases.py
- Extended generators in buffers.py to return next_observation and has_next_observation
- Added a test in test_buffers.py
@araffin araffin added the duplicate This issue or pull request already exists label Feb 13, 2023
@araffin
Copy link
Member

araffin commented Feb 13, 2023

Duplicate of #1267 (although this is a different implementation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add a next_observations field to RolloutBufferSamples
2 participants