Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the way expectations.go initializes the margs variable #254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update the way expectations.go initializes the margs variable #254

wants to merge 1 commit into from

Conversation

sivchari
Copy link

Hi, This is a small change, but it will send a PR.
In the String function of expectations.go, there is a place where it initializes a variable called margs.
I thought this would be better for Go's slice specification, since the capacity of the slice to be appended can be allocated in advance by the length of the args.

@l3pp4rd
Copy link
Member

l3pp4rd commented Feb 17, 2021

Hi, in this program it does not matter at all.
It will not be called millions of times in unit tests and it will have no performance impact. I will not merge this for this very reason, hope it will be a lesson for you

@sivchari
Copy link
Author

I comprehended you said. Thanks for reply.
If there are something , I'll sent PR again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants