#1934: Add parameter to control minimal retention of historical LB data #1996

thearusable · 2022-10-17T12:59:00Z

Closes #1934

github-actions · 2022-10-17T13:28:13Z

Pipelines results

PR tests (gcc-12, ubuntu, mpich)

Build for a8ff97d (2024-01-30 17:22:21 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-3.9, ubuntu, mpich)

Build for 0b5ee2e (2022-11-11 13:45:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 5a725fb (2024-04-30 15:58:47 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-5, ubuntu, mpich)

Build for 0b5ee2e (2022-11-11 13:45:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-6, ubuntu, mpich)

Build for 0b5ee2e (2022-11-11 13:45:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 4e93971 (2023-03-28 10:16:37 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-5.0, ubuntu, mpich)

Build for 0b5ee2e (2022-11-11 13:45:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 4e93971 (2023-03-28 10:16:37 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for dec4a3e (2023-04-04 10:47:19 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 0b5ee2e (2022-11-11 13:45:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for 5a725fb (2024-04-30 15:58:47 UTC)



The following tests FAILED:
  101 - vt:TestLBDataHolder.test_no_metadata_proc_1 (Failed)
  102 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_1 (Failed)
  103 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_1 (Failed)
  104 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_1 (Failed)
  107 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_1 (Failed)
  108 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_1 (Failed)
  109 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_1 (Failed)
  110 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_1 (Failed)
  111 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_1 (Failed)
  112 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_1 (Failed)
  152 - vt:TestLBDataHolder.test_no_metadata_proc_2 (Failed)
  153 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_2 (Failed)
  154 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_2 (Failed)
  155 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_2 (Failed)
  158 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_2 (Failed)
  159 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_2 (Failed)
  160 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_2 (Failed)
  161 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_2 (Failed)
  162 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_2 (Failed)
  163 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_2 (Failed)
  236 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_1 (Failed)
  237 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_1 (Failed)
  266 - vt:*/TestLoadBalancerOther.test_load_balancer_other_1/*_proc_2 (Timeout)
  267 - vt:*/TestLoadBalancerOther.test_load_balancer_other_keep_last_elm/*_proc_2 (Timeout)
  268 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_2/*_proc_2 (Timeout)
  269 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_keep_last_elm/*_proc_2 (Timeout)
  272 - vt:*/TestLBSpecFile.test_node_lb_data_dumping_with_spec_file/*_proc_2 (Timeout)
  273 - vt:*/TestNodeLBDataDumper.test_node_lb_data_dumping_with_interval/*_proc_2 (Timeout)
  274 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_2 (Failed)
  275 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_2 (Failed)
  352 - vt:TestOfflineLB.test_offlinelb_1_proc_1 (Failed)
  362 - vt:TestOfflineLB.test_offlinelb_1_proc_2 (Failed)

Build log

PR tests (clang-13, alpine, mpich)

Build for 5a725fb (2024-04-30 15:58:47 UTC)



The following tests FAILED:
  101 - vt:TestLBDataHolder.test_no_metadata_proc_1 (Failed)
  102 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_1 (Failed)
  103 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_1 (Failed)
  104 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_1 (Failed)
  107 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_1 (Failed)
  108 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_1 (Failed)
  109 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_1 (Failed)
  110 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_1 (Failed)
  111 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_1 (Failed)
  112 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_1 (Failed)
  152 - vt:TestLBDataHolder.test_no_metadata_proc_2 (Failed)
  153 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_2 (Failed)
  154 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_2 (Failed)
  155 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_2 (Failed)
  158 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_2 (Failed)
  159 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_2 (Failed)
  160 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_2 (Failed)
  161 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_2 (Failed)
  162 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_2 (Failed)
  163 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_2 (Failed)
  236 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_1 (Failed)
  237 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_1 (Failed)
  266 - vt:*/TestLoadBalancerOther.test_load_balancer_other_1/*_proc_2 (Timeout)
  267 - vt:*/TestLoadBalancerOther.test_load_balancer_other_keep_last_elm/*_proc_2 (Timeout)
  268 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_2/*_proc_2 (Timeout)
  269 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_keep_last_elm/*_proc_2 (Timeout)
  272 - vt:*/TestLBSpecFile.test_node_lb_data_dumping_with_spec_file/*_proc_2 (Timeout)
  274 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_2 (Failed)
  275 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_2 (Failed)
  352 - vt:TestOfflineLB.test_offlinelb_1_proc_1 (Failed)
  362 - vt:TestOfflineLB.test_offlinelb_1_proc_2 (Failed)

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 5a725fb (2024-04-30 15:58:47 UTC)



The following tests FAILED:
  101 - vt:TestLBDataHolder.test_no_metadata_proc_1 (Failed)
  102 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_1 (Failed)
  103 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_1 (Failed)
  104 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_1 (Failed)
  152 - vt:TestLBDataHolder.test_no_metadata_proc_2 (Failed)
  153 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_2 (Failed)
  154 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_2 (Failed)
  155 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_2 (Failed)
  236 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_1 (Failed)
  237 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_1 (Failed)
  274 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_2 (Failed)
  275 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_2 (Failed)
  352 - vt:TestOfflineLB.test_offlinelb_1_proc_1 (Failed)
  362 - vt:TestOfflineLB.test_offlinelb_1_proc_2 (Failed)

Build log

PR tests (clang-11, ubuntu, mpich)

Build for 5a725fb (2024-04-30 15:58:47 UTC)



The following tests FAILED:
  101 - vt:TestLBDataHolder.test_no_metadata_proc_1 (Failed)
  102 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_1 (Failed)
  103 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_1 (Failed)
  104 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_1 (Failed)
  107 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_1 (Failed)
  108 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_1 (Failed)
  109 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_1 (Failed)
  110 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_1 (Failed)
  111 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_1 (Failed)
  112 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_1 (Failed)
  152 - vt:TestLBDataHolder.test_no_metadata_proc_2 (Failed)
  153 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_2 (Failed)
  154 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_2 (Failed)
  155 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_2 (Failed)
  158 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_2 (Failed)
  159 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_2 (Failed)
  160 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_2 (Failed)
  161 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_2 (Failed)
  162 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_2 (Failed)
  163 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_2 (Failed)
  236 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_1 (Failed)
  237 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_1 (Failed)
  266 - vt:*/TestLoadBalancerOther.test_load_balancer_other_1/*_proc_2 (Timeout)
  267 - vt:*/TestLoadBalancerOther.test_load_balancer_other_keep_last_elm/*_proc_2 (Timeout)
  269 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_keep_last_elm/*_proc_2 (Timeout)
  272 - vt:*/TestLBSpecFile.test_node_lb_data_dumping_with_spec_file/*_proc_2 (Timeout)
  273 - vt:*/TestNodeLBDataDumper.test_node_lb_data_dumping_with_interval/*_proc_2 (Timeout)
  274 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_2 (Failed)
  275 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_2 (Failed)
  352 - vt:TestOfflineLB.test_offlinelb_1_proc_1 (Failed)
  362 - vt:TestOfflineLB.test_offlinelb_1_proc_2 (Failed)

Build log

PR tests (clang-12, ubuntu, mpich)

Build for 5a725fb (2024-04-30 15:58:47 UTC)



The following tests FAILED:
  101 - vt:TestLBDataHolder.test_no_metadata_proc_1 (Failed)
  102 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_1 (Failed)
  103 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_1 (Failed)
  104 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_1 (Failed)
  107 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_1 (Failed)
  108 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_1 (Failed)
  109 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_1 (Failed)
  110 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_1 (Failed)
  111 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_1 (Failed)
  112 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_1 (Failed)
  152 - vt:TestLBDataHolder.test_no_metadata_proc_2 (Failed)
  153 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_2 (Failed)
  154 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_2 (Failed)
  155 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_2 (Failed)
  158 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_2 (Failed)
  159 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_2 (Failed)
  160 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_2 (Failed)
  161 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_2 (Failed)
  162 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_2 (Failed)
  163 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_2 (Failed)
  236 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_1 (Failed)
  237 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_1 (Failed)
  266 - vt:*/TestLoadBalancerOther.test_load_balancer_other_1/*_proc_2 (Timeout)
  267 - vt:*/TestLoadBalancerOther.test_load_balancer_other_keep_last_elm/*_proc_2 (Timeout)
  268 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_2/*_proc_2 (Timeout)
  269 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_keep_last_elm/*_proc_2 (Timeout)
  272 - vt:*/TestLBSpecFile.test_node_lb_data_dumping_with_spec_file/*_proc_2 (Timeout)
  273 - vt:*/TestNodeLBDataDumper.test_node_lb_data_dumping_with_interval/*_proc_2 (Timeout)
  274 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_2 (Failed)
  275 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_2 (Failed)
  352 - vt:TestOfflineLB.test_offlinelb_1_proc_1 (Failed)
  362 - vt:TestOfflineLB.test_offlinelb_1_proc_2 (Failed)

Build log

PR tests (clang-13, ubuntu, mpich)

Build for 5a725fb (2024-04-30 15:58:47 UTC)



The following tests FAILED:
  101 - vt:TestLBDataHolder.test_no_metadata_proc_1 (Failed)
  102 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_1 (Failed)
  103 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_1 (Failed)
  104 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_1 (Failed)
  107 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_1 (Failed)
  108 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_1 (Failed)
  109 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_1 (Failed)
  110 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_1 (Failed)
  111 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_1 (Failed)
  112 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_1 (Failed)
  152 - vt:TestLBDataHolder.test_no_metadata_proc_2 (Failed)
  153 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_2 (Failed)
  154 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_2 (Failed)
  155 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_2 (Failed)
  158 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_2 (Failed)
  159 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_2 (Failed)
  160 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_2 (Failed)
  161 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_2 (Failed)
  162 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_2 (Failed)
  163 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_2 (Failed)
  236 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_1 (Failed)
  237 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_1 (Failed)
  266 - vt:*/TestLoadBalancerOther.test_load_balancer_other_1/*_proc_2 (Timeout)
  267 - vt:*/TestLoadBalancerOther.test_load_balancer_other_keep_last_elm/*_proc_2 (Timeout)
  268 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_2/*_proc_2 (Timeout)
  269 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_keep_last_elm/*_proc_2 (Timeout)
  272 - vt:*/TestLBSpecFile.test_node_lb_data_dumping_with_spec_file/*_proc_2 (Timeout)
  273 - vt:*/TestNodeLBDataDumper.test_node_lb_data_dumping_with_interval/*_proc_2 (Timeout)
  274 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_2 (Failed)
  275 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_2 (Failed)
  352 - vt:TestOfflineLB.test_offlinelb_1_proc_1 (Failed)
  362 - vt:TestOfflineLB.test_offlinelb_1_proc_2 (Failed)

Build log

PR tests (intel icpx, ubuntu, mpich)

Build for 0b5ee2e (2022-11-11 13:45:39 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for a8ff97d (2024-01-30 17:22:21 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for 5a725fb (2024-04-30 15:58:47 UTC)



The following tests FAILED:
  147 - vt:TestLBDataHolder.test_no_metadata_proc_1 (Failed)
  148 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_1 (Failed)
  149 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_1 (Failed)
  150 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_1 (Failed)
  153 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_1 (Failed)
  154 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_1 (Failed)
  155 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_1 (Failed)
  156 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_1 (Failed)
  157 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_1 (Failed)
  158 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_1 (Failed)
  198 - vt:TestLBDataHolder.test_no_metadata_proc_2 (Failed)
  199 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_2 (Failed)
  200 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_2 (Failed)
  201 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_2 (Failed)
  204 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_2 (Failed)
  205 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_2 (Failed)
  206 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_2 (Failed)
  207 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_2 (Failed)
  208 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_2 (Failed)
  209 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_2 (Failed)
  249 - vt:TestLBDataHolder.test_no_metadata_proc_4 (Failed)
  250 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_4 (Failed)
  251 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_4 (Failed)
  252 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_4 (Failed)
  255 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_4 (Failed)
  256 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_4 (Failed)
  257 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_4 (Failed)
  258 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_4 (Failed)
  259 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_4 (Failed)
  260 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_4 (Failed)
  333 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_1 (Failed)
  334 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_1 (Failed)
  363 - vt:*/TestLoadBalancerOther.test_load_balancer_other_1/*_proc_2 (Timeout)
  364 - vt:*/TestLoadBalancerOther.test_load_balancer_other_keep_last_elm/*_proc_2 (Timeout)
  365 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_2/*_proc_2 (Timeout)
  366 - vt:*/TestLoadBalancerGreedy.test_load_balancer_gree%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (gcc-11, ubuntu, mpich, json schema test)

Build for 4e93971 (2023-03-28 10:16:37 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for 5a725fb (2024-04-30 15:58:47 UTC)



The following tests FAILED:
  101 - vt:TestLBDataHolder.test_no_metadata_proc_1 (Failed)
  102 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_1 (Failed)
  103 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_1 (Failed)
  104 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_1 (Failed)
  107 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_1 (Failed)
  108 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_1 (Failed)
  109 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_1 (Failed)
  110 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_1 (Failed)
  111 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_1 (Failed)
  112 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_1 (Failed)
  152 - vt:TestLBDataHolder.test_no_metadata_proc_2 (Failed)
  153 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_2 (Failed)
  154 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_2 (Failed)
  155 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_2 (Failed)
  158 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_2 (Failed)
  159 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_2 (Failed)
  160 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_2 (Failed)
  161 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_2 (Failed)
  162 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_2 (Failed)
  163 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_2 (Failed)
  262 - vt:TestOfflineLB.test_offlinelb_1_proc_1 (Failed)
  272 - vt:TestOfflineLB.test_offlinelb_1_proc_2 (Failed)

Build log

PR tests (nvidia cuda 11.2, ubuntu, mpich)

Build for dec4a3e (2023-04-04 10:47:19 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for 5a725fb (2024-04-30 15:58:47 UTC)



The following tests FAILED:
  101 - vt:TestLBDataHolder.test_no_metadata_proc_1 (Failed)
  102 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_1 (Failed)
  103 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_1 (Failed)
  104 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_1 (Failed)
  107 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_1 (Failed)
  108 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_1 (Failed)
  109 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_1 (Failed)
  110 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_1 (Failed)
  111 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_1 (Failed)
  112 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_1 (Failed)
  152 - vt:TestLBDataHolder.test_no_metadata_proc_2 (Failed)
  153 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_2 (Failed)
  154 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_2 (Failed)
  155 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_2 (Failed)
  158 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_2 (Failed)
  159 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_2 (Failed)
  160 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_2 (Failed)
  161 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_2 (Failed)
  162 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_2 (Failed)
  163 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_2 (Failed)
  236 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_1 (Failed)
  237 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_1 (Failed)
  266 - vt:*/TestLoadBalancerOther.test_load_balancer_other_1/*_proc_2 (Timeout)
  267 - vt:*/TestLoadBalancerOther.test_load_balancer_other_keep_last_elm/*_proc_2 (Timeout)
  268 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_2/*_proc_2 (Timeout)
  269 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_keep_last_elm/*_proc_2 (Timeout)
  272 - vt:*/TestLBSpecFile.test_node_lb_data_dumping_with_spec_file/*_proc_2 (Timeout)
  273 - vt:*/TestNodeLBDataDumper.test_node_lb_data_dumping_with_interval/*_proc_2 (Timeout)
  274 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_2 (Failed)
  275 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_2 (Failed)
  352 - vt:TestOfflineLB.test_offlinelb_1_proc_1 (Failed)
  362 - vt:TestOfflineLB.test_offlinelb_1_proc_2 (Failed)

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for 5a725fb (2024-04-30 15:58:47 UTC)



The following tests FAILED:
  101 - vt:TestLBDataHolder.test_no_metadata_proc_1 (Failed)
  102 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_1 (Failed)
  103 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_1 (Failed)
  104 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_1 (Failed)
  152 - vt:TestLBDataHolder.test_no_metadata_proc_2 (Failed)
  153 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_2 (Failed)
  154 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_2 (Failed)
  155 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_2 (Failed)
  236 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_1 (Failed)
  237 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_1 (Failed)
  266 - vt:*/TestLoadBalancerOther.test_load_balancer_other_1/*_proc_2 (Timeout)
  267 - vt:*/TestLoadBalancerOther.test_load_balancer_other_keep_last_elm/*_proc_2 (Timeout)
  268 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_2/*_proc_2 (Timeout)
  269 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_keep_last_elm/*_proc_2 (Timeout)
  271 - vt:TestLoadBalancerNoWork.test_load_balancer_no_work_proc_2 (Timeout)
  272 - vt:*/TestLBSpecFile.test_node_lb_data_dumping_with_spec_file/*_proc_2 (Timeout)
  273 - vt:*/TestNodeLBDataDumper.test_node_lb_data_dumping_with_interval/*_proc_2 (Timeout)
  274 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_2 (Failed)
  275 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_2 (Failed)
  352 - vt:TestOfflineLB.test_offlinelb_1_proc_1 (Failed)
  362 - vt:TestOfflineLB.test_offlinelb_1_proc_2 (Failed)

Build log

PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for 5a725fb (2024-04-30 15:58:47 UTC)

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(202): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::GreedyLB, f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Op=vt::collective::PlusOp, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>, Args=<vt::vrt::collection::lb::GreedyPayload>]" 
/vt/src/vt/vrt/collection/balance/greedylb/greedylb.cc(222): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (gcc-12, ubuntu, mpich, verbose)

Build for caf2f86 (2024-05-06 12:12:33 UTC)



The following tests FAILED:
  107 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_1 (Failed)
  108 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_1 (Failed)
  109 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_1 (Failed)
  110 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_1 (Failed)
  111 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_1 (Failed)
  112 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_1 (Failed)
  158 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_2 (Failed)
  159 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_2 (Failed)
  160 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_2 (Failed)
  161 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_2 (Failed)
  162 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_2 (Failed)
  163 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_2 (Failed)
  266 - vt:*/TestLoadBalancerOther.test_load_balancer_other_1/*_proc_2 (Timeout)
  267 - vt:*/TestLoadBalancerOther.test_load_balancer_other_keep_last_elm/*_proc_2 (Timeout)
  268 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_2/*_proc_2 (Timeout)
  269 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_keep_last_elm/*_proc_2 (Timeout)
  271 - vt:TestLoadBalancerNoWork.test_load_balancer_no_work_proc_2 (Timeout)
  272 - vt:*/TestLBSpecFile.test_node_lb_data_dumping_with_spec_file/*_proc_2 (Timeout)
  273 - vt:*/TestNodeLBDataDumper.test_node_lb_data_dumping_with_interval/*_proc_2 (Timeout)

Build log

PR tests (intel icpx, ubuntu, mpich, verbose)

Build for 5a725fb (2024-04-30 15:58:47 UTC)



The following tests FAILED:
  101 - vt:TestLBDataHolder.test_no_metadata_proc_1 (Failed)
  102 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_1 (Failed)
  103 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_1 (Failed)
  104 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_1 (Failed)
  107 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_1 (Failed)
  108 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_1 (Failed)
  109 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_1 (Failed)
  110 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_1 (Failed)
  111 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_1 (Failed)
  112 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_1 (Failed)
  152 - vt:TestLBDataHolder.test_no_metadata_proc_2 (Failed)
  153 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_2 (Failed)
  154 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_2 (Failed)
  155 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_2 (Failed)
  158 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_2 (Failed)
  159 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_2 (Failed)
  160 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_2 (Failed)
  161 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_2 (Failed)
  162 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_2 (Failed)
  163 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_2 (Failed)
  262 - vt:TestOfflineLB.test_offlinelb_1_proc_1 (Failed)
  272 - vt:TestOfflineLB.test_offlinelb_1_proc_2 (Failed)

Build log

PR tests (clang-14, ubuntu, mpich, verbose)

Build for 5a725fb (2024-04-30 15:58:47 UTC)



The following tests FAILED:
  101 - vt:TestLBDataHolder.test_no_metadata_proc_1 (Failed)
  102 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_1 (Failed)
  103 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_1 (Failed)
  104 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_1 (Failed)
  107 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_1 (Failed)
  108 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_1 (Failed)
  109 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_1 (Failed)
  110 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_1 (Failed)
  111 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_1 (Failed)
  112 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_1 (Failed)
  152 - vt:TestLBDataHolder.test_no_metadata_proc_2 (Failed)
  153 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_2 (Failed)
  154 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_2 (Failed)
  155 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_2 (Failed)
  158 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_2 (Failed)
  159 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_2 (Failed)
  160 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_2 (Failed)
  161 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_2 (Failed)
  162 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_2 (Failed)
  163 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_2 (Failed)
  236 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_1 (Failed)
  237 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_1 (Failed)
  266 - vt:*/TestLoadBalancerOther.test_load_balancer_other_1/*_proc_2 (Timeout)
  267 - vt:*/TestLoadBalancerOther.test_load_balancer_other_keep_last_elm/*_proc_2 (Timeout)
  268 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_2/*_proc_2 (Timeout)
  269 - vt:*/TestLoadBalancerGreedy.test_load_balancer_greedy_keep_last_elm/*_proc_2 (Timeout)
  272 - vt:*/TestLBSpecFile.test_node_lb_data_dumping_with_spec_file/*_proc_2 (Timeout)
  273 - vt:*/TestNodeLBDataDumper.test_node_lb_data_dumping_with_interval/*_proc_2 (Timeout)
  274 - vt:TestRestoreLBData.test_restore_lb_data_data_1_proc_2 (Failed)
  275 - vt:*/TestDumpUserdefinedData.test_dump_userdefined_json/*_proc_2 (Failed)
  352 - vt:TestOfflineLB.test_offlinelb_1_proc_1 (Failed)
  362 - vt:TestOfflineLB.test_offlinelb_1_proc_2 (Failed)

Build log

PR tests (nvidia cuda 12.2.0, gcc-9, ubuntu, mpich, verbose)

Build for 5a725fb (2024-04-30 15:58:47 UTC)

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "double" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, double> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "int" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, int> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

The following tests FAILED:
  147 - vt:TestLBDataHolder.test_no_metadata_proc_1 (Failed)
  148 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_1 (Failed)
  149 - vt:TestLBDataHolder.test_lb_phases_metadata_empty_proc_1 (Failed)
  150 - vt:TestLBDataHolder.test_lb_phases_metadata_filled_proc_1 (Failed)
  153 - vt:TestLBDataRetention.test_lbdata_retention_last1_proc_1 (Failed)
  154 - vt:TestLBDataRetention.test_lbdata_retention_last2_proc_1 (Failed)
  155 - vt:TestLBDataRetention.test_lbdata_retention_last4_proc_1 (Failed)
  156 - vt:TestLBDataRetention.test_lbdata_config_retention_higher_proc_1 (Failed)
  157 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_1_proc_1 (Failed)
  158 - vt:TestLBDataRetention.test_lbdata_retention_model_switch_2_proc_1 (Failed)
  198 - vt:TestLBDataHolder.test_no_metadata_proc_2 (Failed)
  199 - vt:TestLBDataHolder.test_no_lb_phases_metadata_proc_2 (Failed%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

src/vt/vrt/collection/balance/node_lb_data.cc

tests/unit/collection/test_lb_data_retention.cc

src/vt/vrt/collection/balance/node_lb_data.h

codecov · 2022-10-25T15:33:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.93%. Comparing base (7be56f2) to head (d074668).
Report is 393 commits behind head on develop.

❗ Current head d074668 differs from pull request most recent head caf2f86. Consider uploading reports for the commit caf2f86 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1996      +/-   ##
===========================================
- Coverage    85.48%   84.93%   -0.55%     
===========================================
  Files          722      723       +1     
  Lines        25907    25662     -245     
===========================================
- Hits         22146    21796     -350     
- Misses        3761     3866     +105

Files	Coverage Δ
src/vt/configs/arguments/app_config.h	`100.00% <ø> (ø)`
src/vt/configs/arguments/args.cc	`94.57% <100.00%> (ø)`
.../vt/vrt/collection/balance/lb_invoke/lb_manager.cc	`80.96% <100.00%> (+0.05%)`	⬆️
...c/vt/vrt/collection/balance/lb_invoke/lb_manager.h	`100.00% <100.00%> (ø)`
src/vt/vrt/collection/balance/node_lb_data.cc	`84.45% <100.00%> (+0.10%)`	⬆️
src/vt/vrt/collection/balance/node_lb_data.h	`100.00% <100.00%> (ø)`
tests/unit/collection/test_lb_data_retention.cc	`100.00% <100.00%> (ø)`

... and 271 files with indirect coverage changes

src/vt/vrt/collection/balance/lb_invoke/lb_manager.cc

PhilMiller · 2022-10-26T23:06:03Z

Other than the minor interface thing I noted, I'd approve this.

cz4rs

Looks good to me.

PhilMiller

This looks ready to go.

Could you think through whether there are any weird concerns if a new model gets set and that changes the number of phases retained? In particular, I can think of the possibility that we keep some stale data forever if a new model demands fewer phases than its predecessor.

thearusable · 2022-11-08T12:30:49Z

@PhilMiller Sorry for the delay, I missed your message.

From what I understand the scenario that you described is the only one which can have some weird behaviors. LB data is being cleaned after each phase so that will occur rather frequently. So if there is more data than model needs then it will not be retained for long.
The only way to retain that data even if it is not needed is to use the configuration LBType::NoLB, in this case LB will not be run so also the data will not be removed.

src/vt/vrt/collection/balance/lb_invoke/lb_manager.cc

PhilMiller

See my latest comment about covering the edge case

PhilMiller · 2022-11-11T18:22:14Z

The reason I see the potential for retention is that the cleaning removes data from a particular past phase at a fixed offset from the current phase. if the model's requested retention falls, then there will be a range of phases whose data gets skipped over.

…lementLBData

…ed phases

…il specific size is requested

thearusable requested a review from cz4rs October 17, 2022 12:59

thearusable requested a review from PhilMiller October 17, 2022 13:47

PhilMiller reviewed Oct 18, 2022

View reviewed changes

src/vt/vrt/collection/balance/node_lb_data.cc Outdated Show resolved Hide resolved

PhilMiller reviewed Oct 18, 2022

View reviewed changes

tests/unit/collection/test_lb_data_retention.cc Show resolved Hide resolved

nlslatt mentioned this pull request Oct 18, 2022

Meeting Agenda [do not close] #925

Open

thearusable self-assigned this Oct 24, 2022

cz4rs reviewed Oct 24, 2022

View reviewed changes

src/vt/vrt/collection/balance/node_lb_data.h Outdated Show resolved Hide resolved

thearusable force-pushed the 1934-add-config-parameter-for-lb-data-retention branch from 84321c3 to 1fa5810 Compare October 25, 2022 13:50

thearusable marked this pull request as ready for review October 25, 2022 14:08

thearusable requested review from cz4rs and PhilMiller October 25, 2022 14:09

PhilMiller reviewed Oct 26, 2022

View reviewed changes

src/vt/vrt/collection/balance/lb_invoke/lb_manager.cc Outdated Show resolved Hide resolved

thearusable force-pushed the 1934-add-config-parameter-for-lb-data-retention branch from 181ce43 to 1422bbc Compare October 27, 2022 13:32

cz4rs approved these changes Oct 27, 2022

View reviewed changes

cz4rs requested review from stmcgovern, nlslatt, JacobDomagala, jstrzebonski, lifflander and nmm0 October 27, 2022 14:39

PhilMiller approved these changes Oct 27, 2022

View reviewed changes

thearusable force-pushed the 1934-add-config-parameter-for-lb-data-retention branch from 1422bbc to 0b5ee2e Compare November 11, 2022 13:45

PhilMiller reviewed Nov 11, 2022

View reviewed changes

src/vt/vrt/collection/balance/lb_invoke/lb_manager.cc Outdated Show resolved Hide resolved

PhilMiller requested changes Nov 11, 2022

View reviewed changes

thearusable force-pushed the 1934-add-config-parameter-for-lb-data-retention branch from 0b5ee2e to eee6783 Compare December 6, 2022 10:38

thearusable added 29 commits May 6, 2024 13:39

#1934: Add missing resize in linear model test

bb203e6

#1934: Allow contains to be called when size is zero

1ae144a

#1934: Add iterator support for buffer type

c11488f

#1934: Fix failing tests related to buffers being not initialized

4b19b5c

#1934: Add cosmetic changes and reverse some unneded changes

d6cd760

#1934: Use CircularPhasesBuffer in ElementLBData

eb5f85c

#1934: Pass the requested retention to ElementLBData

dc551a2

#1934: Update retention tests to expect correct amount of phases in E…

86e15f5

…lementLBData

#1934: Adjust buffers size in objs of the collection

f624f1a

#1934: Reaply interface changes after rebase

2daada3

#1934: Synchronize buffer size in TestCol before checking for persist…

2279098

…ed phases

#1934: Set initial timings buffer size to 1

0271b68

#1934: Remove update of the buffers in the group

c815dcb

#1934: Use buffer alias in models

9d86eb3

#1934: Add more tests for circular phases buffer

d2d647e

#1934: Add more test cases for CircularPhasesBuffer

5429bed

#1934: Avoid crashing when container was not resized yet

79c4673

#1934: Finish first version of the CirculaPhasesBuffer

cb82f99

#1934: Update tests for CircularPhasesBuffer

84768e1

#1934: Update implementation of CirculaPhasesBuffer

14e45f4

#1934: Add documentation for CirculalPhasesBuffer

02c575b

#1934: Fix compilation issue on Apple Clang

602d7e9

#1934: Fix NVCC warning related to unsigned variable

76a93e2

#1934: Update implementation after resolving conflicts

517ec32

#1934: Refactor of the CircularPhasesBuffer to be dynamic in size unt…

0cf8cc9

…il specific size is requested

#1934: Remove unnecessary resizes

80c5204

#1934: Update unit tests to check all relevant fields in NodeLBData

18b110a

#1934: Remove trailing whitespaces

bbe61b4

#1934: Remove usage of old LBDataHolder constructor

caf2f86

thearusable force-pushed the 1934-add-config-parameter-for-lb-data-retention branch from 5a725fb to caf2f86 Compare May 6, 2024 12:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1934: Add parameter to control minimal retention of historical LB data #1996

#1934: Add parameter to control minimal retention of historical LB data #1996

thearusable commented Oct 17, 2022

github-actions bot commented Oct 17, 2022 •

edited

codecov bot commented Oct 25, 2022 •

edited

PhilMiller commented Oct 26, 2022

cz4rs left a comment

PhilMiller left a comment

thearusable commented Nov 8, 2022

PhilMiller left a comment

PhilMiller commented Nov 11, 2022

#1934: Add parameter to control minimal retention of historical LB data #1996

Are you sure you want to change the base?

#1934: Add parameter to control minimal retention of historical LB data #1996

Conversation

thearusable commented Oct 17, 2022

github-actions bot commented Oct 17, 2022 • edited

Pipelines results

codecov bot commented Oct 25, 2022 • edited

Codecov Report

PhilMiller commented Oct 26, 2022

cz4rs left a comment

Choose a reason for hiding this comment

PhilMiller left a comment

Choose a reason for hiding this comment

thearusable commented Nov 8, 2022

PhilMiller left a comment

Choose a reason for hiding this comment

PhilMiller commented Nov 11, 2022

github-actions bot commented Oct 17, 2022 •

edited

codecov bot commented Oct 25, 2022 •

edited