SlimPIE and RAM Circle #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ia0e71edd8c0987c9ec6d70bb98da824a8016c243
This commit changes the following: - add possibility to set trigger height on the left and right trigger - add possibility to set gravity on the lef and right trigger - change touch detection logic and calculation (it shows now up immediately...super fast :p) - reduces values in dimens.xml because of the new touch detection much lesser are needed - remove on settings the shown values on the left @Seekbar on entries where it does not make sense - reset menu for trigger dimensions - minor string changes - cleanup - minor bugfixes for me it is now like a PIE should be lol cheers Change-Id: Ib31025a05b94da6718d2ff66178a7657075e4c90
I promissed yesterday to stop working on SlimPIE....but due team and user whishes I decided to do a last tweak so that all are happy. This commit introduces the following: - enable second buttons row - up to 7 buttons + 7 longpress buttons - usual customizations on that buttons - means it is possible to add 5 + 5 on first row and 7 + 7 on second row - resource friendly...reusing most of present code - new introduced observer for second row is just observing when second row is really enabled - due optimizations we can hold the speed and responsive we introduced yesterday on same level - reduce default size back to 1 - some minor changes Now SlimPIE is finished Screenshots (first shows default values for first and second row): https://dl.dropboxusercontent.com/u/106208842/Screenshot_2013-05-01-02-30-47.png https://dl.dropboxusercontent.com/u/106208842/Screenshot_2013-05-01-02-36-25.png cheers Change-Id: Icac694022e051eb3ced986829f7196798c958b8e
due to team request reduce the minimum value to 0.84 (6% lower)...all below big icons will overlap the button border cheers Change-Id: I6a4f25aca0feebf477160df08509a69e5b8d1f4d
due 70% user feedback the wanted to have the right pie mirrored on the horizontal axis because of usability...the other 30% want a visual logic... So a point to make it optional default value is mirrored cheers Change-Id: Id1d9017b7180aa42171abf36721595ab9130d26e
Due team, user and kanger wishes I needed to do again something :p Hopefully now really the last thing :D Is now in full range as well usable for higher dpi then our stock dpi This commit does: - allow bigger size range for SlimPIE layout - icon are now resized on smaller sizes (only then) then default size which allows much smaller overall size - slight better positiong of the icons in the button item - Fix: reported issues custom Icons are sometimes to small - Fix: reported issue that estimated container size took not PIE_SIZE into account (follows now on every dpi and size the activation point) - Fix: Settings style seekbar resets sometimes to last setted value - Settings: a bit code rearrangement (not needed but I was bored :p) And now really finished :p cheers Change-Id: I6917830262f1c1bf31f0175368daa7d9e187ad9c Conflicts: src/com/android/settings/cyanogenmod/PieStyleSettings.java
played so much with the stock dpi values to optimize that I set the default value for our slim dpi a bit to low :p Roms which use stock phon dpi can leaver it like it is But should kang the correspondent frameworks patch which allows more flexible size changes cheers Change-Id: Id251862be544e2408d8059037708ee84868f6b87 Conflicts: src/com/android/settings/cyanogenmod/PieStyleSettings.java
Change-Id: I4ae86f10829ee2c2057e4079d5d25363bb478719 Conflicts: src/com/android/settings/cyanogenmod/PieStyleSettings.java
time for code cleanup projects. Switch to same logic we already use in QS/NT shortcuts. Use only one string for the whole SlimPie config This reduces massive the observer footprint. cheers Change-Id: I967baabd09e6c85b8e857f8f57a096b9b8d48b92
|
will merge asap. good work. I will merge manually because it has some conflicts... next time better separate pull requests for each new feature - not just join all things to one pull requests, but that's ok for now. thanks |
|
Ok but i am not able to send a pull request of base |
|
I've also commited these in my recent update's to Settings and Base, I also have a lot more done, going to work on getting Base updated here soon and I will also test it to make sure that everything is working/not broken (which I'm sure a lot is) So what I can do is once I get it working and building I can pull in the Ram Circle/ Recents Kill All Switcher and then send a completed Pull Request, that way our stuff isn't conflicting. I have the Navbar Settings/Colors reworked as well as SlimPIE in mine. |
|
Great! I'll get few things done today like the active display from chaos and maybe a few other |
|
The base is taking me a while so expect me to have it mergeable sometime next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.