Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send /activity/with-member data to data-sink-worker #2403

Merged
merged 13 commits into from
May 15, 2024
Merged

send /activity/with-member data to data-sink-worker #2403

merged 13 commits into from
May 15, 2024

Conversation

yeganathan18
Copy link
Member

@yeganathan18 yeganathan18 commented May 13, 2024 •
edited

Changes proposed ✍️

What

copilot:summary
​
copilot:poem

Why

How

copilot:walkthrough

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@yeganathan18 yeganathan18 changed the title improve /activity/with-member endpoint and send data to data-sink-worker send /activity/with-member data to data-sink-worker May 14, 2024
epipav
epipav reviewed May 14, 2024
View reviewed changes
Copy link
Collaborator

@epipav epipav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added 2 nits

backend/src/services/activityService.ts Outdated Show resolved Hide resolved
backend/src/services/activityService.ts Show resolved Hide resolved
@yeganathan18 yeganathan18 merged commit fcd6280 into crowd-linux May 15, 2024
8 checks passed
@yeganathan18 yeganathan18 deleted the improve/LFX-1025 branch May 15, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epipav epipav epipav left review comments

@garrrikkotua garrrikkotua garrrikkotua approved these changes

@themarolt themarolt themarolt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yeganathan18 @epipav @garrrikkotua @themarolt