try to add test #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matttbe
reviewed
Mar 19, 2024
| @@ -29,4 +29,4 @@ To use MPTCP for your connections, add the `--mptcp` option when using `curl`: | |||
|
|
|||
| ## Availability | |||
|
|
|||
| The `--mptcp` option is available starting from `curl` version X.XX.XX. | |||
| The `--mptcp` option is available starting from `curl` version 8.6.1. | |||
| ## CURLOPT_MPTCP | ||
|
|
||
| Enable Multipath TCP (MPTCP). See CURLOPT_MPTCP(3) | ||
|
|
docs/libcurl/opts/CMakeCache.txt
Outdated
| @@ -0,0 +1,379 @@ | |||
| # This is the CMakeCache file. | |||
| # For build in directory: /home/dorian/Documents/curlFinal/curl/docs/libcurl/opts | |||
| # It was generated by CMake: /usr/bin/cmake | |||
There was a problem hiding this comment.
should not be included in Git
| @@ -0,0 +1 @@ | |||
| # This file is generated by cmake for dependency checking of the CMakeCache.txt file | |||
There was a problem hiding this comment.
should not be included in Git
| @@ -0,0 +1,451 @@ | |||
| The system is: Linux - 6.5.0-25-generic - x86_64 | |||
There was a problem hiding this comment.
should not be included in Git
tests/servers.pm
Outdated
| # Enregistre les PIDs des processus du serveur gopher pour suivi | ||
| logmsg sprintf ("* pid gopher => %d %d\n", $pid, $pid2) if($verbose); | ||
|
|
||
| # Met à jour l'état du serveur gopher comme étant en cours d'exécution |
There was a problem hiding this comment.
For the whole block above: these modifs should be dropped
tests/servers.pm
Outdated
| $run{'gopher'}="$pid $pid2"; | ||
| } | ||
| } | ||
|
|
||
| elsif($what eq "mptcp") { | ||
| # print "Starting MPTCP server\n"; |
There was a problem hiding this comment.
this modif should be dropped
tests/servers.pm
Outdated
| } | ||
| } | ||
| if(!$run{'mptcp'}) { | ||
| ($serr, $pid, $pid2, $PORT{'mptcp'}) = runhttpserver("mptcp",$verbose, 0); |
There was a problem hiding this comment.
spaces missing before $verbose
tests/servers.pm
Outdated
| @@ -2849,6 +2904,8 @@ sub startservers { | |||
| logmsg "* starts no server\n" if ($verbose); | |||
| } | |||
| else { | |||
| # print "What : $what\n"; | |||
|
|
|||
There was a problem hiding this comment.
this modif should be dropped
tests/servers.pm
Outdated
| logmsg sprintf("* pid mptcp => %d %d\n", $pid, $pid2) if($verbose); | ||
| $run{'mptcp'}="$pid $pid2"; | ||
| } | ||
| } |
There was a problem hiding this comment.
just to be sure: are you sure it is needed? If yes, please move it at the end.
CrapsDorian
pushed a commit
that referenced
this pull request
Mar 20, 2024
In order to make MSAN happy:
==2200945==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x596f3b3ed246 in curlx_strtoofft [...]/libcurl/src/lib/strtoofft.c:239:11
#1 0x596f3b402156 in Curl_httpchunk_read [...]/libcurl/src/lib/http_chunks.c:149:12
#2 0x596f3b348550 in readwrite_data [...]/libcurl/src/lib/transfer.c:607:11
[...]
==2202041==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x5a3fab66a72a in Curl_parse_port [...]/libcurl/src/lib/urlapi.c:547:8
#1 0x5a3fab650645 in parse_authority [...]/libcurl/src/lib/urlapi.c:796:12
#2 0x5a3fab6740f6 in parseurl [...]/libcurl/src/lib/urlapi.c:1176:16
curl#3 0x5a3fab664fc5 in parseurl_and_replace [...]/libcurl/src/lib/urlapi.c:1342:12
[...]
==2202320==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x569076a0d6b0 in ipv4_normalize [...]/libcurl/src/lib/urlapi.c:683:12
#1 0x5690769f2820 in parse_authority [...]/libcurl/src/lib/urlapi.c:803:10
#2 0x569076a160f6 in parseurl [...]/libcurl/src/lib/urlapi.c:1176:16
curl#3 0x569076a06fc5 in parseurl_and_replace [...]/libcurl/src/lib/urlapi.c:1342:12
[...]
Signed-off-by: Louis Solofrizzo <lsolofrizzo@scaleway.com>
Closes curl#12995
try to make mptcp test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.