New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to install (or upgrade) and run Count.ly Server on macOS #1329
base: master
Are you sure you want to change the base?
Conversation
…e ours and restore them after activating nodeenv
This has now been tested with a clean install on macOS, and an upgrade from 19.08.1 to 20.04. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments in code
Requested changes made. |
Remove pure formatting changes and general changes using sudo. # Conflicts: # bin/scripts/mongodb.init.logrotate.sh # bin/scripts/mongodb.install.sh
|
VERSION="$(grep -oP 'version:\s*"\K[0-9\.]*' "$DIR/../../frontend/express/version.info.js")" | ||
VERSION="$(egrep -o 'version: *"[0-9\.]+"' "$DIR/../../frontend/express/version.info.js" | sed -E -e 's,^version: *"([0-9\.]+)"$,\1,')" | ||
|
||
#Activate our nodejs, if using nodeenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using nodeenv on macOS since it provides a nice, clean environment for Count.ly without affecting any other NodeJS applications that may be running. I suggest switching over to nodeenv since Count.ly isn't using the latest NodeJS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In overall nodeenv is useless to Countly, since in production we have control over what is installed and nothing else should be running and preconfigured on the server. It will only be one more dependency to worry about when making offline builts with prebuild binaries, etc
But since here it is optional, should be ok, only not sure about the path, seems to be tailored to your system? Is there some default path to be used in such cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm running a production environment, with multiple versions of NodeJS required for other various low-volume services (most run in 12.x, but a few are running on 14.x). I suppose I could run either Count.ly or those other services in Docker containers, but that adds an overhead that is disproportionate to the load required.
The biggest problem is that Count.ly is currently now several versions behind on NodeJS - requiring 10.x while the most recent LTS is 12.x and release is 14.x.
I'm still in the process of installing 20.04 on my server, but these are the changes I needed to make to upgrade my 18.08 installation to 19.08.1.