Views Rework #189
Open
Views Rework #189
+2,199
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtursKadikis
requested changes
Dec 15, 2023
ArtursKadikis
requested changes
Jan 2, 2024
ArtursKadikis
requested changes
Jan 2, 2024
ArtursKadikis
requested review from
ijunaid,
arifBurakDemiray and
turtledreams
Assets/Countly/Plugins/CountlySDK/Services/EventCountlyService.cs
Outdated
Show resolved
Hide resolved
arifBurakDemiray
requested changes
May 13, 2024
arifBurakDemiray
approved these changes
May 17, 2024
turtledreams
requested changes
May 22, 2024
arifBurakDemiray
approved these changes
May 22, 2024
turtledreams
requested changes
May 23, 2024
| } | ||
|
|
||
| _utils.TruncateSegmentationValues(customViewSegmentation, _configuration.MaxSegmentationValues, "[ViewCountlyService] StartViewInternal, ", Log); | ||
| _utils.RemoveReservedKeysFromSegmentation(customViewSegmentation, reservedSegmentationKeysViews, "[ViewCountlyService] AutoCloseRequiredViews, ", Log); |
There was a problem hiding this comment.
AutoCloseRequiredViews
| } | ||
|
|
||
| lock (LockObj) { | ||
| Log.Info("[ViewCountlyService] Calling SetGlobalViewSegmentation sg[" + (viewSegmentation == null ? "null" : viewSegmentation.Count.ToString()) + "]"); |
There was a problem hiding this comment.
instead of count lets print the stingified version of the segmentation provided
| TestUtility.TestCleanup(); | ||
| Object.DestroyImmediate(Countly.Instance); |
There was a problem hiding this comment.
public static void TestCleanup(){
Countly.Instance.ClearStorage();
UnityEngine.Object.DestroyImmediate(Countly.Instance);
}
this is the function that we want to standardize for each test, which also does this exact same thing. So no need to keep these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.