iOS test fixes and other patches #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijunaid
approved these changes
May 7, 2024
| NSString *key = [command objectAtIndex:i]; | ||
| NSString *valueString = [command objectAtIndex:i + 1]; | ||
| // Convert value string to integer | ||
| NSNumber *value = @([valueString intValue]); |
There was a problem hiding this comment.
Just curious, why we are converting string value to integer?
There was a problem hiding this comment.
i got my answer from flutter code :)
| @@ -689,7 +689,7 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result | |||
| NSString *key = [command objectAtIndex:0]; | |||
| NSString *value = [command objectAtIndex:1]; | |||
|
|
|||
| [Countly.user push:key value:value]; | |||
| [Countly.user pull:key value:value]; | |||
| view = eventList[4]; | ||
| expect(view['key'], '[CLY]_view'); | ||
| expect(view['segmentation']['segment'], Platform.isIOS ? 'iOS' : 'Android'); | ||
| expect(view['segmentation']['name'], 'hawk'); |
There was a problem hiding this comment.
View name is truncated, so it should be 'hawk'.substring(0, MAX_VALUE_SIZE)
There was a problem hiding this comment.
oh this is value limit test. those are truncated at key limit
arifBurakDemiray
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.