Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevGuide] Crash filtering details #637

Merged
merged 3 commits into from May 24, 2024
Merged

[DevGuide] Crash filtering details #637

merged 3 commits into from May 24, 2024

Conversation

arifBurakDemiray
Copy link
Member

No description provided.

@arifBurakDemiray arifBurakDemiray added the SDK Guide Documentation changes to SDK Development Guide label Apr 16, 2024
@turtledreams
Copy link
Contributor

awesome, we might expand it a bit with some

@turtledreams
Copy link
Contributor

Adding the whole team for review because we all will implement this feature in our SDKs. So we better check if everything is clear for us and we can plan or discuss details starting from here.

AliRKat
AliRKat requested changes Apr 18, 2024
View reviewed changes
Copy link
Member

@AliRKat AliRKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content-wise perfect work 🚀

Visual-wise, I feel the language is clear and easy to read. My only suggestion is to turn the normally written lists into bulleted lists. Bulleted lists are much easier to review and wouldn't confuse them with other sections.

sdk_dev_guide/current.md Show resolved Hide resolved
sdk_dev_guide/current.md Show resolved Hide resolved
AliRKat
AliRKat approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@AliRKat AliRKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfecto 👌

@turtledreams turtledreams merged commit 57234d2 into master May 24, 2024
1 check passed
@turtledreams turtledreams deleted the crashfilter branch May 24, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterBrxwn peterBrxwn peterBrxwn approved these changes

@turtledreams turtledreams turtledreams approved these changes

@AliRKat AliRKat AliRKat approved these changes

@ijunaid ijunaid Awaiting requested review from ijunaid

Assignees
No one assigned
Labels
SDK Guide Documentation changes to SDK Development Guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arifBurakDemiray @turtledreams @peterBrxwn @AliRKat