Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing internal limits impl #304

Merged
merged 4 commits into from May 13, 2024
Merged

Fix missing internal limits impl #304

merged 4 commits into from May 13, 2024

Conversation

arifBurakDemiray
Copy link
Member

setMaxSegmentationValues: - custom user properties has no limit
setMaxValueSize: - truncates user property picture (not picture path)
setMaxKeyLength: - Network Trace name not truncated

Copy link

github-actions bot commented May 8, 2024

Unit Test Results 🚀

569 tests  +3   568 ✅ +2   1m 22s ⏱️ -17s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     1 ❌ +1 

For more details on these failures, see this check.

Results for commit f6b67c0. ± Comparison against base commit f25b8b6.

♻️ This comment has been updated with latest results.

Copy link
Member

@AliRKat AliRKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool work! Would love to hear your opinion about my comment on your giant string

@turtledreams turtledreams merged commit 40a4a48 into staging May 13, 2024
2 of 5 checks passed
@turtledreams turtledreams deleted the limits_fixes branch May 13, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants