Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 MakeFile various tweaks #2897

Merged
merged 11 commits into from Apr 30, 2024
Merged

Conversation

Kiirx
Copy link
Contributor

@Kiirx Kiirx commented Jan 14, 2024

  • IL2CPU was using Release config which broke the setup, so now every project will use Debug config.
  • Added build time
  • Added some coloring for easier reading because of the huge amount of warnings

image

@Kiirx
Copy link
Contributor Author

Kiirx commented Jan 14, 2024

it seems like the github actions aren't using the makefile, which is probably why the config problem passed through the test, the github action should be moved to a linux one instead to test both of the platforms

Makefile Outdated Show resolved Hide resolved
@Kiirx
Copy link
Contributor Author

Kiirx commented Jan 23, 2024

so?

Copy link
Member

@valentinbreiz valentinbreiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @Kiirx but could you enable release mode again?

@Kiirx Kiirx marked this pull request as draft February 19, 2024 14:47
@Kiirx Kiirx mentioned this pull request Feb 21, 2024
@Kiirx Kiirx marked this pull request as ready for review March 20, 2024 18:46
@Kiirx Kiirx requested a review from valentinbreiz April 3, 2024 17:22
@Kiirx
Copy link
Contributor Author

Kiirx commented Apr 30, 2024

@valentinbreiz could you please review this PR? As it is ready to merge

@valentinbreiz valentinbreiz merged commit 8adc686 into CosmosOS:master Apr 30, 2024
18 checks passed
@Kiirx Kiirx deleted the fix/warnmake branch April 30, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants