-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Updating russian strings #2565
base: master
Are you sure you want to change the base?
Conversation
choice_2 = " СИНИЙ ЗЕЛЕНЫЙ КРАСНЫЙ ", | ||
choice_1 = " КРАСНЫЙ ", | ||
choice_3 = " ЖЕЛТЫЙ ОРАНЖЕВЫЙ КРАСНЫЙ ", | ||
choice_2 = " Синий, зеленый, красный ", | ||
choice_1 = " Красный ", | ||
choice_3 = " Желтый, оранжевый, красный ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some menu items are intentionally capitalised, but I don't have the documentation to support it. Do we all caps in other languages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some menu items are intentionally capitalised, but I don't have the documentation to support it. Do we all caps in other languages?
Yes in other languages there is caps, but due to option menu was already not using caps in russian.lua, i decided to keep it like that. Also i would notice that Arial (which is a default font for unicode languages) looks... well, not good while being capitalised in a menu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try testing out GoNotoKurrent-Bold.ttf as your Unicode font linked in #2398 ? It'd be interesting how readable russian becomes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try testing out GoNotoKurrent-Bold.ttf as your Unicode font linked in #2398 ? It'd be interesting how readable russian becomes.
It's alright but the text is being a little scattered and sometimes goes beyond of dialog borders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's usually expected with a font change annoyingly. Does GoNotoKurrent-Regular look better (also in that PR I think)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Describe what the proposed change does