Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Updating russian strings #2565

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

Matroftt
Copy link
Contributor

@Matroftt Matroftt commented May 1, 2024

Describe what the proposed change does

  • Fixes some mistakes
  • Translates strings that were added in newer commits

Comment on lines -65 to +75
choice_2 = " СИНИЙ ЗЕЛЕНЫЙ КРАСНЫЙ ",
choice_1 = " КРАСНЫЙ ",
choice_3 = " ЖЕЛТЫЙ ОРАНЖЕВЫЙ КРАСНЫЙ ",
choice_2 = " Синий, зеленый, красный ",
choice_1 = " Красный ",
choice_3 = " Желтый, оранжевый, красный ",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some menu items are intentionally capitalised, but I don't have the documentation to support it. Do we all caps in other languages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some menu items are intentionally capitalised, but I don't have the documentation to support it. Do we all caps in other languages?

Yes in other languages there is caps, but due to option menu was already not using caps in russian.lua, i decided to keep it like that. Also i would notice that Arial (which is a default font for unicode languages) looks... well, not good while being capitalised in a menu.

In this PR
image
In CorsixTH v0.67
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try testing out GoNotoKurrent-Bold.ttf as your Unicode font linked in #2398 ? It'd be interesting how readable russian becomes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try testing out GoNotoKurrent-Bold.ttf as your Unicode font linked in #2398 ? It'd be interesting how readable russian becomes.

It's alright but the text is being a little scattered and sometimes goes beyond of dialog borders

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's usually expected with a font change annoyingly. Does GoNotoKurrent-Regular look better (also in that PR I think)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's usually expected with a font change annoyingly. Does GoNotoKurrent-Regular look better (also in that PR I think)?

It definitely does
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants