-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Spawn changes #1986
base: master
Are you sure you want to change the base?
[RFC] Spawn changes #1986
Conversation
I feel sorry for those lost little lambs (Seriously though, I'll try to look over this tomorrow evening) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR. Not sure World - even though you don't have a staffed desk, TH still counts them towards the statistics, even though no patients are actually spawned.
is actually the right thing to do, but for fidelity I suppose it can stay.
I agree you should remove getRepuationImpact.
hosp_patient_value[s] = value_proposition | ||
end | ||
|
||
local threshold = math.random(0, math.floor(value_proposition - 1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, though clever enough it deserves a comment (or the comment above expanded) i.e. to include that the hospital is chosen randomly with a chance proportional to it's relative value proposition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seconding this... I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the hasStaffedDesk, they don't spawn, but they do count to the visitor count on the annual report but not on the charts/graphs ui, so maybe I should adjust that also. Though I think that will introduce another statistic. Looks like I could repurpose the World.total_population and Hospital.population variables to account for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Hoping the edge spawned patients will be hidden in another patch
CorsixTH/Lua/world.lua
Outdated
|
||
--! Choose hospital for normal patient | ||
--!param disease (table) - the disease assigned to this patient | ||
--!return hospital (Hospital) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidental double space?
hosp_patient_value[s] = value_proposition | ||
end | ||
|
||
local threshold = math.random(0, math.floor(value_proposition - 1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seconding this... I think
e05868a
to
7072085
Compare
@@ -46,6 +46,10 @@ function AIHospital:logTransaction() | |||
-- AI doesn't need a log of transactions, as it is only used for UI purposes | |||
end | |||
|
|||
function AIHospital:hasStaffedDesk() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible future todo?:
Adjust this to only be true when the AI Hospital opens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed this will switch with the AI hospitals change to actually detect a receptionist has been hired and a desk exists again. This just gets it working before they are implemented
Partially Fixes #649
Describe what the proposed change does
Bonus of this one, turn off limit camera and the patients for the AI Hospitals will be strolling around on the edges of the map