New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/53 handle different languages #58

Open

PiaSchroeder wants to merge 17 commits into dev from feat/53-handle-different-languages

Collaborator

PiaSchroeder commented Feb 25, 2024 •

edited by bergnerjonas

Closes #53

used decimal points or commas in pd.read_csv() depending on the chosen language so that floats are read as floats instead of strings
introduced a database and language specific dictionary for column names so that prettify_table works for en and de

PiaSchroeder added 2 commits

February 24, 2024 22:41


          Made pd.read_csv() use decimal points or commas depending on the chos…

79e9239

…en language


          Made prettify table work for de and en

ab75e8b

pmayd reviewed

View reviewed changes

src/pystatis/config.py Outdated Show resolved Hide resolved

pmayd reviewed

View reviewed changes

src/pystatis/table.py Outdated Show resolved Hide resolved

pmayd reviewed

View reviewed changes

src/pystatis/table.py Outdated Show resolved Hide resolved

pmayd reviewed

View reviewed changes

src/pystatis/table.py Outdated Show resolved Hide resolved

pmayd reviewed

View reviewed changes

src/pystatis/table.py Show resolved Hide resolved

pmayd reviewed

View reviewed changes

src/pystatis/table.py Outdated Show resolved Hide resolved

pmayd approved these changes

View reviewed changes

Collaborator

pmayd left a comment

I left a few comments for small improvements but overall, looks good!

pmayd reviewed

View reviewed changes

src/pystatis/config.py Outdated Show resolved Hide resolved

pmayd reviewed

View reviewed changes

src/pystatis/config.py Outdated Show resolved Hide resolved

PiaSchroeder added 3 commits

March 3, 2024 22:17


          Improvements in documentation and code readability in prettify_table

6809cd9


          Made the QueryParameterError inherit from ValueError instead of Excep…

7066d80

…tion


          Removed unused language parameter in parse_zensus_table

675d7a3

bergnerjonas mentioned this pull request

[BUG] get_data method throws KeyError when using language='en' #88

Closed


          Change keys for genesis language mapping to more fitting names.

a96161b

Collaborator

bergnerjonas commented May 13, 2024

Will add tests for language support once #99 is merged.

Jonas Bergner added 6 commits

May 20, 2024 17:33


          Merge branch 'dev' into feat/53-handle-different-languages

5c9f06a


          Add zensus language mapping.

b823bb8


          Replace nonexisting regio table from test

0ddc6a7


          Remove cassette of outdated table.


          Fix formatting errors.

1b3af9a


          Add handling of missing unit information.

63f56eb

Collaborator

bergnerjonas commented May 27, 2024

Will not support language='en' for Regionalstatistik database, since the API responses are of low data quality and handling them is too complicated and error prone.

Jonas Bergner added 5 commits

May 27, 2024 10:59


          Remove language support for regionalstatistik.

15b5cb5


          Add tests for en language.

3c8a33e


          Fix pipeline errors.

e1efdd5


          Fix identation in docstring.

9e9dda3


          Fix typo in unit handling.

761c89e

MarcoHuebner reviewed

View reviewed changes

src/pystatis/table.py


		pretty_data = pd.concat([time, attributes, values], axis=1)
		pretty_data = pd.concat([time, attributes, values], axis=1).dropna(axis=0, how="all")

Collaborator

MarcoHuebner Jun 4, 2024

Not sure whether we actually want dropna, as NaN's contain a lot of "irregular" but relevant information (see other open issues). At first glance, nothing else to complain about :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment